Skip to contentSkip to conversation

char/zftape-buffers: replace schedule_timeout() with msleep_interruptible()

PATCH In review [email protected] 1 participant 1 message Sep 23, 2004 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 26/26 char/zftape-buffers: replace schedule_timeout() with msleep_interruptible()

Any comments would be appreciated. There actually won't be a PATCH 33/33, because I dropped one that even I wouldn't approve :)

Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

---

 linux-2.6.9-rc2-bk7-max/drivers/char/ftape/zftape/zftape-buffers.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/char/ftape/zftape/zftape-buffers.c renamed from drivers/char/ftape/zftape/zftape-buffers.c~msleep_interruptible-drivers_char_zftape-buffers +2 -2
diff -puN drivers/char/ftape/zftape/zftape-buffers.c~msleep_interruptible-drivers_char_zftape-buffers drivers/char/ftape/zftape/zftape-buffers.c
@@ -27,6 +27,7 @@
 #include <linux/errno.h>
 #include <linux/mm.h>
 #include <linux/slab.h>
+#include <linux/delay.h>
 
 #include <linux/zftape.h>
 
@@ -119,8 +120,7 @@ void *zft_kmalloc(size_t size)
 	void *new;
 
 	while ((new = kmalloc(size, GFP_KERNEL)) == NULL) {
-		current->state   = TASK_INTERRUPTIBLE;
-		schedule_timeout(HZ/10);
+		msleep_interruptible(100);
 	}
 	memset(new, 0, size);
 	used_memory += size;

_