media/bttv-i2c: replace schedule_timeout() with msleep_interruptible()

PATCH New [email protected] 1 participant 1 message Sep 23, 2004 Media (V4L/DVB)

lore

Share & tools

lore

[email protected]

author

2004-09-23 23:53 UTC #0 lore raw

PATCH 7/21 media/bttv-i2c: replace schedule_timeout() with msleep_interruptible()

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

Signed-off-by Nishanth Aravamudan <[email protected]>

Signed-off-by Maximilian Attems <[email protected]>

---

 linux-2.6.9-rc2-bk7-max/drivers/media/video/bttv-i2c.c |    4 +---
 1 files changed, 1 insertion(+), 3 deletions(-)

drivers/media/video/bttv-i2c.c renamed from drivers/media/video/bttv-i2c.c~msleep_interruptible-drivers_media_video_bttv-i2c +1 -3

diff -puN drivers/media/video/bttv-i2c.c~msleep_interruptible-drivers_media_video_bttv-i2c drivers/media/video/bttv-i2c.c
@@ -139,10 +139,8 @@ bttv_i2c_wait_done(struct bttv *btv)
 	int rc = 0;
 	
 	add_wait_queue(&btv->i2c_queue, &wait);
-	set_current_state(TASK_INTERRUPTIBLE);
 	if (0 == btv->i2c_done)
-		schedule_timeout(HZ/50+1);
-	set_current_state(TASK_RUNNING);
+		msleep_interruptible(20);
 	remove_wait_queue(&btv->i2c_queue, &wait);
 
 	if (0 == btv->i2c_done)