Skip to contentSkip to conversation

remove weird pmd cast

PATCH New Dave Hansen 1 participant 1 message Oct 7, 2004 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove weird pmd cast

I don't know what this is trying to do. It might be some kind of artifact from when get_pgd_slow() was removed.

The expanded expression with __pa() ends up looking something like this:

	(unsigned long)(u64)(u32)pmd-PAGE_OFFSET

and that is just nutty because pmd is a pointer now, anyway.

Attached patch removes the casts.

---

 memhotplug-dave/arch/i386/mm/pgtable.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
arch/i386/mm/pgtable.c renamed from arch/i386/mm/pgtable.c~A3-remove-weird-pmd-casts-i386 +1 -1
diff -puN arch/i386/mm/pgtable.c~A3-remove-weird-pmd-casts-i386 arch/i386/mm/pgtable.c
@@ -233,7 +233,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm)
 		pmd_t *pmd = kmem_cache_alloc(pmd_cache, GFP_KERNEL);
 		if (!pmd)
 			goto out_oom;
-		set_pgd(&pgd[i], __pgd(1 + __pa((u64)((u32)pmd))));
+		set_pgd(&pgd[i], __pgd(1 + __pa(pmd)));
 	}
 	return pgd;
 

_