scripts - use $OBJDUMP to get correct objdump (cross compile)
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Review
Quoted 3 lines · Keith Owens
(quoted diff) +3
-0+my $objdump; +if (exists($ENV{'OBJDUMP'})) { + $objdump = $ENV{'OBJDUMP'};
Having a typo in the environment shouldn't silently do something different from what's requested. Use something like
my @objdump = ( (defined $ENV{'OBJDUMP'})? $ENV{'OBJDUMP'} :
"/usr/bin/objdump",
'-s', '-j');Review
Quoted 4 lines
(quoted diff) +4
-0+} else { + $objdump = 'objdump'; +} +$objdump .= ' -s -j .comment';
Having a space as the option delimiter will break if the path to objdump contains a space. Therefore you'll need to use an array.
Signature · 2 lines
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF verbreiteten Lügen zu sabotieren.
Quoted 2 lines · Bodo Eggert
Having a space as the option delimiter will break if the path to objdump contains a space. Therefore you'll need to use an array.
No. You need to draw the line somewhere. You let them have a space in the path, the next thing you know the'll be back asking why a UTF-8 encoded non-breaking-white-space in the path doesn't work. :)
Quoted 8 lines · On Tue, 20 Sep 2005 [email protected] wrote:
Quoted 2 lines · Bodo Eggert
Having a space as the option delimiter will break if the path to objdump contains a space. Therefore you'll need to use an array.
No. You need to draw the line somewhere. You let them have a space in the path, the next thing you know the'll be back asking why a UTF-8 encoded non-breaking-white-space in the path doesn't work. :)
Anything not containing '\0' SHOULD work on posix systems. Anything else is a programming error.
Signature · 3 lines
I always tell customers/clients the same thing: "Good, Fast, Cheap. You can pick two." -- randem in <[email protected]>