Skip to contentSkip to conversation

orinoco: Read only needed data in __orinoco_ev_txexc().

PATCH In review Pavel Roskin 1 participant 1 message Sep 23, 2005

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 7/8 orinoco: Read only needed data in __orinoco_ev_txexc().

Read only needed data in __orinoco_ev_txexc().

Don't read the 802.11 header beyond addr1. The rest of the frame is not used currently.

drivers/net/wireless/orinoco.c +3 -3
@@ -623,10 +623,10 @@ static void __orinoco_ev_txexc(struct ne
 	if (fid == DUMMY_FID)
 		return; /* Nothing's really happened */
 
-	/* Read the frame header */
+	/* Read part of the frame header - we need status and addr1 */
 	err = hermes_bap_pread(hw, IRQ_BAP, &hdr,
-			       sizeof(struct hermes_tx_descriptor) +
-			       sizeof(struct ieee80211_hdr_4addr),
+			       offsetof(struct hermes_tx_descriptor_802_11,
+					addr2),
 			       fid, 0);
 
 	hermes_write_regn(hw, TXCOMPLFID, DUMMY_FID);

-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php