Skip to contentSkip to conversation

git-push.sh: Factor out usage statement to function; explain why rsync can't push

PATCH New [email protected] 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 git-push.sh: Factor out usage statement to function; explain why rsync can't push

Signed-off-by Chris Shoemaker <c.shoemaker at cox.net>

---

 git-push.sh |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

cc2f6f361691771cf461df04255a2b842b264371

git-push.sh +9 -3
@@ -1,6 +1,11 @@
 #!/bin/sh
 . git-sh-setup || die "Not a git archive"
 
+usage () {
+    die "Usage: git push [--all] [--force] <repository> [<refspec>]"
+}
+
+
 # Parse out parameters and then stop at remote, so that we can
 # translate it using .git/branches information
 has_all=

@@ -18,8 +23,7 @@ do
 	--exec=*)
 		has_exec="$1" ;;
 	-*)
-		die "Usage: git push [--all] [--force] <repository> <refspec>"
-                ;;
+                usage ;;
         *)
 		set x "$@"
 		shift

@@ -41,8 +45,10 @@ esac
 shift
 
 case "$remote" in
-http://* | https://* | git://* | rsync://* )
+http://* | https://* | git://*)
 	die "Cannot use READ-ONLY transport to push to $remote" ;;
+rsync://*)
+        die "Pushing with rsync transport is deprecated" ;;
 esac
 
 set x "$remote" "$@"; shift