linux-2.6-block: deactivating pagecache for benchmarks
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 11 lines · Dirk Henning Gerdes
For doing benchmarks on the I/O-Schedulers, I thought it would be very useful to disable the pagecache.
I didn't want to make it so complicated so I just mark pages as not-uptodate, so they have to be read again. Another reason was, that I wanted to keep the conditions as near to reality as possible.
Further I thought it would be useful, if you could turn the pagecache on and off without rebooting the system.
I implemented a proc-fs entry "
/proc/benchmark/pagecache" for this.
1) This mail is the only documentation on how to operate your patch. How do you suppose your users to find out how to operate the switch? (I asume it's really a switch, a toggle would be insane.)
Since it's very short and only for special purpose, documenting it in Kconfig mignt be enough.
2) You're seperating your patches by file, not by function. ungood.
3) Your patches introduce a lot of whitespace.
Signature · 2 lines
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF verbreiteten Lügen zu sabotieren.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Review
Quoted 4 lines · Andrew Morton
(quoted diff) +4
-0+ .procname = "drop-pagecache", + .data = NULL, + .maxlen = sizeof(int), + .mode = 0644,
1) Shouldn't this be a trigger? Reading from a trigger doesn't make sense, especially when triggering on a read. .mode = 0200?
2) If you pass an int, wouldn't a bitmask selecting what to free make sense? (off cause -1 == everything)
Maybe this would be overengineered.
Signature · 2 lines
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF verbreiteten Lügen zu sabotieren.