Skip to contentSkip to conversation

bus_add_device() losing an error return from the probe() method

DISCUSSION Bodo Eggert 1 participant 1 message Mar 27, 2006 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 10 lines · Rene Herman
Quoted 2 lines · Andrew Morton

Looks sane, but please don't sprinkle `return' statements all over a function in this manner.

I actually prefer the multiple returns. You then don't have to "visually scroll down" to the label to see what would happen when reading the code. Even when there's common code before the return, I've never seen GCC not optimise that to the goto form itself. You obviously the boss though.

I tried both, and I found out that having multiple non-trivial points of return enables you to easily create a lot of bugs.

Signature · 2 lines
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.