+ git-klibc-mktemp-fix.patch added to -mm tree
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 11 lines · Sam Ravnborg
usr/dash/mkbuiltins Sat Apr 8 14:51:11 2006
Quoted 6 lines · On Sat, Apr 08, 2006 at 12:05:54AM -0700, [email protected] wrote:
diff -puN
usr/dash/mkbuiltins~git-klibc-mktemp-fixusr/dash/mkbuiltinsusr/dash/mkbuiltins Sat Apr 8 14:51:11 2006 renamed from usr/dash/mkbuiltins~git-klibc-mktemp-fix Sat Apr 8 14:51:11 2006 +1
-1- tempfile=mktemp + tempfile="mktemp /tmp/tmp.XXXXXX"Shouldn't that be:
Quoted 1 line
+ tempfile="$(mktemp
/tmp/tmp.XXXXXX)"
No. You should use tempfile="$(mktemp ${TMPDIR:-/tmp}/tmp.XXXXXX)" (or mktemp -t, if it's portable enough)
Besides that, tmp.XXXXXX should be replayed using a better name.
</nitpick>
Signature · 2 lines
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF verbreiteten Lügen zu sabotieren.