no need to wank with task_lock() and pinning task down in audit_syscall_exit()
PATCH 6/14 no need to wank with task_lock() and pinning task down in audit_syscall_exit()
From: Al Viro <[email protected]>
Date: Wed Mar 29 20:26:24 2006 -0500
Signed-off-by Al Viro <[email protected]>
---
kernel/auditsc.c | 10 +--------- 1 files changed, 1 insertions(+), 9 deletions(-)
97e94c453073a2aba4bb5e0825ddc5e923debf11
kernel/auditsc.c +1 -9
@@ -329,7 +329,6 @@ static enum audit_state audit_filter_sysreturn AUDIT_BUILD_CONTEXT ; } -/* This should be called with task_lock() held. */ static inline struct audit_context *audit_get_context (struct task_struct *tsk,int return_valid,int return_code)
@@ -823,15 +822,10 @@ void audit_syscall_exit(int valid, longstruct task_struct *tsk = current;struct audit_context *context; -get_task_struct (tsk); -task_lock (tsk); context =audit_get_context (tsk, valid, return_code); -task_unlock (tsk); -/* Not having a context here is ok, since the parent may have -* called __put_task_struct. */ if (likely (!context)) - goto out; +return ;if (context->in_syscall && context->auditable)audit_log_exit (context, tsk);
@@ -849,8 +843,6 @@ void audit_syscall_exit(int valid, longaudit_free_aux (context); tsk->audit_context = context; } - out: -put_task_struct (tsk); }/**
Signature · 1 line
1.3.0.g0080f