Skip to contentSkip to conversation

Request to mailing list U-Boot-Users rejected

U-Boot-Users Wolfgang Denk 1 participant 1 message May 17, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 4 lines · In message <[email protected]> you wrote:

My idea is:

* First you should fix the au1x00 support with my patch.

Which increases the mess by adding yet another set of mostly duplicated files...

Quoted 7 lines

* Then I'm going to move files ?./cpu/mpc5xxx/usb_ohci.h?, ?./cpu/mips/au1x00_usb_ohci.h? (which are the same file) and the other '*ohci.h' files into ?include/usb_ohci.h?.

* Then I'm going to move file ?cpu/mips/au1x00_usb_ohci.c? into ?common/usb_ohci.c? modifing the functions ?usb_lowlevel_init()? and ?usb_lowlevel_stop()? according to the different platforms.

... before you start to clean it up?

Quoted 1 line

Please, let me know if these steps look sane to you. :)

I would expect that first cleaning up the code, and then adding a new board to the cleaned up version is simpler and easier to understand?

Best regards,

Wolfgang Denk

Signature · 5 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is is no reason for any individual to have a computer in  their
home.      -- Ken Olsen (President of Digital Equipment Corporation),
              Convention of the World Future Society, in Boston, 1977