Skip to contentSkip to conversation

Prevent multiple inclusion of linux/sysrq.h

PATCH In review Thomas Petazzoni 2 participants 4 messages Sep 22, 2006 – Sep 24, 2006 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Prevent multiple inclusion of linux/sysrq.h

Prevent multiple inclusions of include/linux/sysrq.h using traditional #ifndef..#endif.

Index: linux-2.6/include/linux/sysrq.h
=================================--- linux-2.6.orig/include/linux/sysrq.h 2006-09-23 00:04:05.000000000 +0200
+++ linux-2.6/include/linux/sysrq.h 2006-09-23 00:05:27.000000000 +0200
@@ -11,6 +11,8 @@
* based upon discusions in irc://irc.openprojects.net/#kernelnewbies
*/

+#ifndef _LINUX_SYSRQ_H
+#define _LINUX_SYSRQ_H

struct pt_regs;
struct tty_struct;
@@ -57,3 +59,5 @@
#define unregister_sysrq_key(ig,nore) __reterr()

#endif
+
+#endif /* _LINUX_SYSRQ_H */
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

Hi,

Quoted 4 lines · Thomas Petazzoni

Prevent multiple inclusions of include/linux/sysrq.h using traditional #ifndef..#endif.

To who should I send this patch for inclusion ? The include/linux/sysrq.h is not really part of a driver nor a subsystem, so there's seems to be no maintainer listed in the MAINTAINERS file.

Any suggestion ?

Thanks,

Thomas

Signature · 4 lines
PETAZZONI Thomas - [email protected] 
http://{thomas,sos,kos}.enix.org - Jabber: [email protected]
http://{agenda,livret}dulibre.org - http://www.toulibre.org
Fingerprint : 0BE1 4CF3 CEA4 AC9D CC6E  1624 F653 CB30 98D3 F7A7

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Thomas Petazzoni
Quoted 8 lines · Thomas Petazzoni

Hi,

Quoted 3 lines · Thomas Petazzoni

Prevent multiple inclusions of include/linux/sysrq.h using traditional #ifndef..#endif.

Quoted 9 lines
Quoted 1 line

To who should I send this patch for inclusion ? The include/linux/sysrq.h is not really part of a driver nor a subsystem, so there's seems to be no maintainer listed in the MAINTAINERS file.

Any suggestion ?

Well, patches that have no obvious recipients can often go via Andrew Morton or just be send to LKML.

In this case, if you look in the file, there are two names mentioned :

Martin Mares <[email protected]> Crutcher Dunnavant <[email protected]>

So those two might make sense to add to Cc:

There are also some people mentioned in Documentation/sysrq.txt but I suspect they just wrote the documentation and wouldn't be relevant for this patch, but you could still consider adding them to Cc:

Personally I'd probably do this :

To: LKML <[email protected]>
Cc: Martin Mares <[email protected]>,
Crutcher Dunnavant <[email protected]>

And then if I didn't get any response for a week or two I'd resend with Andrew added as well.

Signature · 8 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
#3 lore raw
In reply to Thomas Petazzoni
Quoted 24 lines · Jesper Juhl
Quoted 8 lines · Thomas Petazzoni

Hi,

Quoted 3 lines · Thomas Petazzoni

Prevent multiple inclusions of include/linux/sysrq.h using traditional #ifndef..#endif.

Quoted 9 lines
Quoted 1 line

To who should I send this patch for inclusion ? The include/linux/sysrq.h is not really part of a driver nor a subsystem, so there's seems to be no maintainer listed in the MAINTAINERS file.

Any suggestion ?

Well, patches that have no obvious recipients can often go via Andrew Morton or just be send to LKML.

In this case, if you look in the file, there are two names mentioned :

Quoted 10 lines

Martin Mares <[email protected]> Crutcher Dunnavant <[email protected]>

So those two might make sense to add to Cc:

There are also some people mentioned in Documentation/sysrq.txt but I suspect they just wrote the documentation and wouldn't be relevant for this patch, but you could still consider adding them to Cc:

For trivial patches adding the Trivial Patch Monkey (currently Adrian Bunk) to Cc: is also often a good idea. [email protected]

See Documentation/SubmittingPatches for the details on what qualifies as a trivial patch.

Signature · 8 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors