Add Ultrabay support for the T60p Thinkpad
PATCH 1/1 Add Ultrabay support for the T60p Thinkpad
Add Ultrabay Support for the T60p Thinkpad
The following patch adds support for obtaining the status and ejecting Ultrabay devices for the T60p Thinkpad; my guess is that it probably works on T60 Thinkpads and probably more recent Lenovo latops as well.
With the 2.03 BIOS I have been able to eject a SATA drive in an Ultrabay carrier by using the command:
"echo 1 > /sys/class/scsi_device/1:0:0:0/device/delete"
and upon re-inserting the it back into the device and issuing the command:
"echo 0 0 0 > /sys/class/scsi_host/host1/scan"
have the device appear again. (With the 1.02 BIOS the device does not function when re-inserted, even after a warm boot; a cold reboot is required to store the Ultrabay device's functionality.)
More complicated Ultrabay eject and insert scripts can be found on the ThinkWiki, although it's important to comment out the "hdparm -Y" as it apparently doesn't work or do anything, and causes the eject process to hang for about a minute.
drivers/acpi/ibm_acpi.c +1 -0
@@ -169,6 +169,7 @@#endif IBM_HANDLE (bay, root,"\\_SB.PCI.IDE.SECN.MAST" ,/* 570 */ "\\_SB.PCI0.IDE0.IDES.IDSM" ,/* 600e/x, 770e, 770x */ +"\\_SB.PCI0.IDE0.PRIM.MSTR" ,/* T60p */ "\\_SB.PCI0.IDE0.SCND.MSTR", /* all others */ );/* A21e, R30, R31 */
Quoted 1 line · Theodore Ts'o
Add Ultrabay Support for the T60p Thinkpad
Thanks, an equivalent patch is alredy merged in acpi-test, and waiting a push to linus.
BTW: this is an ACK if you want to merge this patch ahead of the stuff in acpi-test.
Quoted 2 lines
Ultrabay devices for the T60p Thinkpad; my guess is that it probably works on T60 Thinkpads and probably more recent Lenovo latops as well.
It works on all *60 and *61 new ThinkPads, yes.
Quoted 3 lines
have the device appear again. (With the 1.02 BIOS the device does not function when re-inserted, even after a warm boot; a cold reboot is required to store the Ultrabay device's functionality.)
Nice to know that, thanks.
Take a look on the experimental ACPI bay and dock support in acpi-test, it is even better than ibm-acpi's builtin support... and in fact, deprecates it.
Signature · 4 lines
"One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
PATCH 1/1 Add Ultrabay support for the T60p Thinkpad
Quoted 6 lines · Henrique de Moraes Holschuh
Thanks, an equivalent patch is alredy merged in acpi-test, and waiting a push to linus.
BTW: this is an ACK if you want to merge this patch ahead of the stuff in acpi-test.
Great, I don't think I saw any mention of T60 support on the linux-thinkpad mailing list, so I didn't realize this work had already been done. Would have saved me all of 15 minutes or so. :-)
When is acpi-test scehduled to be merged? If it's going to be pushed soon into mainline, then I don't want to make any extra work for folks. If it's going to be a while, the patch is pretty simple and low-risk, so hopefully it can get merged quickly.
Quoted 5 lines
Quoted 3 lines
have the device appear again. (With the 1.02 BIOS the device does not function when re-inserted, even after a warm boot; a cold reboot is required to store the Ultrabay device's functionality.)
Nice to know that, thanks.
I wasn't quite exact in describing the problem originally, so for the record, if you are using a 1.02/1.04 BIOS, if all you do is disassociate the device using:
"echo 1 > /sys/class/scsi_device/1:0:0:0/device/delete"
it's fine. But if you apply this patch and then actually shut the bay using:
"echo eject > /proc/acpi/ibm/bay"
Then when you re-insert the disk, it will appear to be probed, but any attempt to read or write from the disk will return an error, and doing a shutdown and trying to boot off of the device will also result in an error. Only a power-cycle will restore the Ultrabay to usability. When I upgraded to the 2.03 BIOS, it worked just fine, so I assume this was a BIOS and/or DSDT bug fix.
Quoted 3 lines
Take a look on the experimental ACPI bay and dock support in acpi-test, it is even better than ibm-acpi's builtin support... and in fact, deprecates it.
Great, I'll have to look at it. In the meantime, here's an updated patch which only changes the documentation and comments. I'll leave it to Andrew/Linus to decide whether they want to merge this patch or acpi-test.
- Ted
Add Ultrabay Support for the T60p Thinkpad
The following patch adds support for obtaining the status and ejecting Ultrabay devices for the T60p Thinkpad; my guess is that it probably works on T60 Thinkpads and probably more recent Lenovo latops as well.
With the 2.03 BIOS I have been able to eject a SATA drive in an Ultrabay carrier by using the commands:
"echo 1 > /sys/class/scsi_device/1:0:0:0/device/delete" "echo eject > /proc/acpi/ibm/bay"
and upon re-inserting the it back into the device and issuing the command:
"echo 0 0 0 > /sys/class/scsi_host/host1/scan"
have the device appear again. (With the 1.02 BIOS the device does not function when re-inserted, even after a warm boot; a cold reboot is required to store the Ultrabay device's functionality.)
More complicated Ultrabay eject and insert scripts can be found on the ThinkWiki, although it's important to comment out the "hdparm -Y" as it apparently doesn't work or do anything, and causes the eject process to hang for about a minute.
drivers/acpi/ibm_acpi.c +1 -0
@@ -169,6 +169,7 @@#endif IBM_HANDLE (bay, root,"\\_SB.PCI.IDE.SECN.MAST" ,/* 570 */ "\\_SB.PCI0.IDE0.IDES.IDSM" ,/* 600e/x, 770e, 770x */ +"\\_SB.PCI0.IDE0.PRIM.MSTR" ,/* {T,Z}]6{0,1}[p] */ "\\_SB.PCI0.IDE0.SCND.MSTR", /* all others */ );/* A21e, R30, R31 */
Whoopie from ThinkWiki just sent me an email, calling my attention to the fact that the patch you submitted is in fact different from the one I merged... something I should have triple-verified. It appears the t60p has the bay in a different ACPI node than some other *60 ThinkPads. Either that, or the node moves depending on ICHR mode set in the BIOS.
So I apologise for the screw up, and:
I am merging your patch into the ibm-acpi tree and will ask Len to push it to Linus. Now, please excuse me while I go look for a new brown-paperbag hat...
Quoted 39 lines · Theodore Ts'o
Add Ultrabay Support for the T60p Thinkpad
The following patch adds support for obtaining the status and ejecting Ultrabay devices for the T60p Thinkpad; my guess is that it probably works on T60 Thinkpads and probably more recent Lenovo latops as well.
With the 2.03 BIOS I have been able to eject a SATA drive in an Ultrabay carrier by using the command:
"echo 1 > /sys/class/scsi_device/1:0:0:0/device/delete"
and upon re-inserting the it back into the device and issuing the command:
"echo 0 0 0 >
/sys/class/scsi_host/host1/scan"have the device appear again. (With the 1.02 BIOS the device does not function when re-inserted, even after a warm boot; a cold reboot is required to store the Ultrabay device's functionality.)
More complicated Ultrabay eject and insert scripts can be found on the ThinkWiki, although it's important to comment out the "hdparm -Y" as it apparently doesn't work or do anything, and causes the eject process to hang for about a minute.
Signed-off-by "Theodore Ts'o" <[email protected]>Index:
2.6.19/drivers/acpi/ibm_acpi.c
===================================================================drivers/acpi/ibm_acpi.c +1
-0@@ -169,6 +169,7 @@#endif IBM_HANDLE (bay, root,"\\_SB.PCI.IDE.SECN.MAST" ,/* 570 */ "\\_SB.PCI0.IDE0.IDES.IDSM" ,/* 600e/x, 770e, 770x */ +"\\_SB.PCI0.IDE0.PRIM.MSTR" ,/* T60p */ "\\_SB.PCI0.IDE0.SCND.MSTR", /* all others */ );/* A21e, R30, R31 */
Signature · 4 lines
"One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh