make pipefs do lazy i_ino assignment and hashing
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 10 lines · Jeff Layton
This patch updates pipefs to do defer assigning an
i_inovalue to its inodes until someone actually tries to stat it. This allows us to have uniquei_inovalues for the inodes here, without the performance impact for anyone who doesn't actually care about it.Since we don't have an
i_inovalue at pipe creation time, we need something else to stuff into the dentry name. Here, I'm using the pointer address of the inode xor'ed with a random value. There are certainly better hashing schemes, so if someone wants to propose a better way to do this, then I'm open to looking at it (maybe halfmd4?).
Why XOR? To pretend a non-existent level of security?
Either you can't use the address, or you can read the obfusicator value, too.
OTOH, if sizeof(void*) <= sieof(ino_t), using the address will result in a unique inode number without need for expensive hashing algorithms.
Signature · 4 lines
Why did the hacker cross the road? To get to the other side.
Why did the cracker cross the road? To get what was on the other side.
The difference is small, but important.
-- Gandalf Parker