Skip to contentSkip to conversation

wrong order of kzalloc arguments

PATCH In review Al Viro 2 participants 2 messages Feb 9, 2007 ACPI

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 wrong order of kzalloc arguments

---
 drivers/acpi/bay.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/bay.c +1 -1
index 667fa1d..91082ce 100644
@@ -296,7 +296,7 @@ static int bay_add(acpi_handle handle, int id)
 	/*
 	 * Initialize bay device structure
 	 */
-	new_bay = kzalloc(GFP_ATOMIC, sizeof(*new_bay));
+	new_bay = kzalloc(sizeof(*new_bay), GFP_ATOMIC);
 	INIT_LIST_HEAD(&new_bay->list);
 	new_bay->handle = handle;
 	new_bay->name = (char *)nbuffer.pointer;
Signature · 1 line
1.5.0-rc2.GIT
#1 lore raw
Quoted 23 lines · Al Viro
---
 drivers/acpi/bay.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/bay.c +1 -2
index 667fa1d..91082ce 100644
@@ -296,7 +296,7 @@ static int bay_add(acpi_handle handle, int id)
        /*
         * Initialize bay device structure
         */
-       new_bay = kzalloc(GFP_ATOMIC, sizeof(*new_bay));
+       new_bay = kzalloc(sizeof(*new_bay), GFP_ATOMIC);
        INIT_LIST_HEAD(&new_bay->list);
        new_bay->handle = handle;
        new_bay->name = (char *)nbuffer.pointer;
--

1.5.0-rc2.GIT

Quoted 6 lines

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Oops. thanks for taking the time to review and fix this.

Kristen