Skip to contentSkip to conversation

zatm __init abuse

PATCH NAK Al Viro 2 participants 2 messages Mar 14, 2007 ATM

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 5/13 zatm __init abuse

zatm_init() and zatm_start() should be __devinit (the former is not module init, despite the name - it's a helper for PCI ->probe())

Signed-off-by Al Viro <[email protected]>
---
 drivers/atm/zatm.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/atm/zatm.c +2 -2
index 0d7091e..2ad2527 100644
@@ -1177,7 +1177,7 @@ static void __devinit eprom_get_esi(struct atm_dev *dev)
 /*--------------------------------- entries ---------------------------------*/
 
 
-static int __init zatm_init(struct atm_dev *dev)
+static int __devinit zatm_init(struct atm_dev *dev)
 {
 	struct zatm_dev *zatm_dev;
 	struct pci_dev *pci_dev;

@@ -1256,7 +1256,7 @@ static int __init zatm_init(struct atm_dev *dev)
 }
 
 
-static int __init zatm_start(struct atm_dev *dev)
+static int __devinit zatm_start(struct atm_dev *dev)
 {
 	struct zatm_dev *zatm_dev = ZATM_DEV(dev);
 	struct pci_dev *pdev = zatm_dev->pci_dev;
Signature · 1 line
1.5.0-rc2.GIT
#1 lore raw
Quoted 7 lines · Al Viro

zatm_init() and zatm_start() should be __devinit (the former is not module init, despite the name - it's a helper for PCI ->probe())

Signed-off-by Al Viro <[email protected]>
---
 drivers/atm/zatm.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

ACK