Skip to contentSkip to conversation

Kconfig style question

DISCUSSION Bodo Eggert 2 participants 2 messages Mar 16, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 9 lines · Kumar Gala

For source lines I've seen both:

source "arch/powerpc/platforms/52xx/Kconfig"

and

source arch/powerpc/platforms/85xx/Kconfig

Is there a preferred style? Quotes or not?

$ find . -name Kconfig -exec grep ^source '{}' \;|grep \"|wc -l
    732
$ find . -name Kconfig -exec grep ^source '{}' \;|grep -v \"|wc -l
     44
Signature · 4 lines
Funny quotes:
18. Mind like a steel trap - rusty and illegal in 37 states.

Friß, Spammer: [email protected] [email protected]
#2 lore raw
Quoted 8 lines · Bodo Eggert
Quoted 6 lines · Kumar Gala

For source lines I've seen both:

source "arch/powerpc/platforms/52xx/Kconfig"

and

Quoted 8 lines
Quoted 3 lines

source arch/powerpc/platforms/85xx/Kconfig

Is there a preferred style? Quotes or not?

$ find . -name Kconfig -exec grep ^source '{}' \;|grep \"|wc -l
    732
$ find . -name Kconfig -exec grep ^source '{}' \;|grep -v \"|wc -l
     44

Which is somewaht funny.
source is defined like this:
"source" <prompt>

Where <prompt> may be a single string without spaces or a quoted string with spaces.
So kconfig allow you to use spaces in the path/filename. But then most users uses "" despite it is not needed since we obviously do not use spaces in path/filename in the kernel due to make limitations (and good taste).

Sam