removing -S option from dtc?
Jon,
Any thoughts on removing the -S option from dtc. It always seemed confusing to me and not sure if any really uses it.
- k
A message that is not in the archive (sent off-list or not yet received): 9E2D1AC5-F98F-431B-9361-9EA4765785F9-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org
Quoted 6 lines
Jon,
Any thoughts on removing the -S option from dtc. It always seemed confusing to me and not sure if any really uses it.
- k
Well, not yet.
jdl
A message that is not in the archive (sent off-list or not yet received): E1KOBRr-0002ku-UK-CYoMK+44s/[email protected]
Quoted 8 lines
Quoted 6 lines
Jon,
Any thoughts on removing the -S option from dtc. It always seemed confusing to me and not sure if any really uses it.
- k
Well, not yet.
Well, that was vague in its conciseness.
I meant, it's not time to remove it yet.
There are still plenty of lingering users that
have not figured out U-Boot has improved yet.
jdl
A message that is not in the archive (sent off-list or not yet received): E1KOBTw-0002lU-LL-CYoMK+44s/[email protected]
Quoted 7 lines · Jon Loeliger
Quoted 7 lines
Quoted 6 lines
Jon,
Any thoughts on removing the -S option from dtc. It always seemed confusing to me and not sure if any really uses it.
- k
Quoted 7 lines
Quoted 1 line
Well, not yet.
Well, that was vague in its conciseness.
I meant, it's not time to remove it yet.
There are still plenty of lingering users that
have not figured out U-Boot has improved yet.
I was thinking we'd keep -p (for padding) but remove -S (pad to a fixed size).
- k
A message that is not in the archive (sent off-list or not yet received): 7EE6D71E-3074-4DCF-A279-15E91825B0A7-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org
Quoted 3 lines
I was thinking we'd keep -p (for padding) but remove -S (pad to a fixed size).
Oh, we can deprecate it and start beating people over the head with removal and upgrade avice tell we are blue.
Start by telling Stuart H to remove it. I already tried.
jdl
PATCH 1/1 dtc: give advance warning that "-S" is going away.
The "-S" option allowed the specification of a minimum size for the blob, however the main reason for caring about the size is so there is enough padding to add a chosen node by u-boot or whoever. In which case, folks don't really care about the absolute size, but rather the size of the padding added for this -- which is what the "-p" option does. Having the "-S" just confuses people.
--- dtc.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
dtc.c +3 -0
@@ -182,6 +182,9 @@ int main(int argc, char *argv[])if (minsize && padsize)die ("Can't set both -p and -S\n" ); +if (minsize) +fprintf (stderr,"DTC: Use of \"-S\" is deprecated; it will be removed soon, use \"-p\" instead\n" ); +fprintf (stderr,"DTC: %s->%s on file \"%s\"\n" , inform, outform, arg);
Signature · 1 line
1.5.6.2
A message that is not in the archive (sent off-list or not yet received): 1217426356-1248-1-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org
Re: [PATCH] dtc: give advance warning that "-S" is going away.
Quoted 8 lines
The "-S" option allowed the specification of a minimum size for the blob, however the main reason for caring about the size is so there is enough padding to add a chosen node by u-boot or whoever. In which case, folks don't really care about the absolute size, but rather the size of the padding added for this -- which is what the "-p" option does. Having the "-S" just confuses people.
Signed-off-by Paul Gortmaker <[email protected]>
You rock.
Quoted 4 lines
(quoted diff) +2
-0+ if (minsize) + fprintf(stderr, "DTC: Use of \"-S\" is deprecated; it will be removed soon, use \"-p\" instead\n");
+
Or use a U-boot that handles re-sizing automatically.
jdl
Jon Loeliger
AppliedRe: [PATCH] dtc: give advance warning that "-S" is going away.
In reply to a message not in the archiveQuoted 8 lines
The "-S" option allowed the specification of a minimum size for the blob, however the main reason for caring about the size is so there is enough padding to add a chosen node by u-boot or whoever. In which case, folks don't really care about the absolute size, but rather the size of the padding added for this -- which is what the "-p" option does. Having the "-S" just confuses people.
Signed-off-by Paul Gortmaker <[email protected]>
Applied.
jdl
A message that is not in the archive (sent off-list or not yet received): E1KOBwm-0002vc-CT-CYoMK+44s/[email protected]
Quoted 6 lines
Quoted 3 lines
I was thinking we'd keep -p (for padding) but remove -S (pad to a fixed size).
Oh, we can deprecate it and start beating people over the head with removal and upgrade avice tell we are blue.
s/avice/advice
s/tell/until/
Rough day.
jdl