Skip to contentSkip to conversation

powerpc set_huge_psize() false positive

PATCH Applied Al Viro 1 participant 1 message Nov 22, 2008 PowerPC

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 3/32 powerpc set_huge_psize() false positive

called only from __init, calls __init. Incidentally, it ought to be static in file.

---
 arch/powerpc/include/asm/mmu-hash64.h |    1 -
 arch/powerpc/mm/hugetlbpage.c         |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)
arch/powerpc/include/asm/mmu-hash64.h +0 -1
@@ -280,7 +280,6 @@ extern int hash_huge_page(struct mm_struct *mm, unsigned long access,
 extern int htab_bolt_mapping(unsigned long vstart, unsigned long vend,
 			     unsigned long pstart, unsigned long prot,
 			     int psize, int ssize);
-extern void set_huge_psize(int psize);
 extern void add_gpage(unsigned long addr, unsigned long page_size,
 			  unsigned long number_of_pages);
 extern void demote_segment_4k(struct mm_struct *mm, unsigned long addr);
arch/powerpc/mm/hugetlbpage.c +1 -1
@@ -677,7 +677,7 @@ repeat:
 	return err;
 }
 
-void set_huge_psize(int psize)
+static void __init set_huge_psize(int psize)
 {
 	/* Check that it is a page size supported by the hardware and
 	 * that it fits within pagetable limits. */