Skip to contentSkip to conversation

Remove the RAMROOT function for msp71xx

MIPS Applied Shane McDonald 3 participants 4 messages Apr 28, 2009 – Apr 29, 2009 MIPS

lore
Share & tools
lore

Shane McDonald

author
#0 lore raw

The RAMROOT function was a successful but non-portable attempt to append the root filesystem to the end of the kernel image. The preferred and portable solution is to use an initramfs instead. This patch removes the RAMROOT functionality.

This patch has been compile-tested against the current HEAD.

Signed-off-by Shane McDonald <[email protected]>
---
 arch/mips/pmc-sierra/Kconfig            |   12 ------
 arch/mips/pmc-sierra/msp71xx/msp_prom.c |   60 +------------------------------
 2 files changed, 1 insertions(+), 71 deletions(-)
arch/mips/pmc-sierra/Kconfig +0 -12
index 90261b8..c139988 100644
@@ -36,18 +36,6 @@ config PMC_MSP7120_FPGA
 
 endchoice
 
-menu "Options for PMC-Sierra MSP chipsets"
-	depends on PMC_MSP
-
-config PMC_MSP_EMBEDDED_ROOTFS
-	bool "Root filesystem embedded in kernel image"
-	select MTD
-	select MTD_BLOCK
-	select MTD_PMC_MSP_RAMROOT
-	select MTD_RAM
-
-endmenu
-
 config HYPERTRANSPORT
 	bool "Hypertransport Support for PMC-Sierra Yosemite"
 	depends on PMC_YOSEMITE
arch/mips/pmc-sierra/msp71xx/msp_prom.c +1 -59

81 lines not on this page · raw message

Signature · 1 line
1.6.2.4
Applied
#1 lore raw
Quoted 6 lines · Shane McDonald

The RAMROOT function was a successful but non-portable attempt to append the root filesystem to the end of the kernel image. The preferred and portable solution is to use an initramfs instead. This patch removes the RAMROOT functionality.

This patch has been compile-tested against the current HEAD.

Thanks, applied!

Ralf

#2 lore raw
In reply to Shane McDonald
Quoted 11 lines · Shane McDonald

The RAMROOT function was a successful but non-portable attempt to append the root filesystem to the end of the kernel image. The preferred and portable solution is to use an initramfs instead. This patch removes the RAMROOT functionality.

This patch has been compile-tested against the current HEAD.

Signed-off-by Shane McDonald <[email protected]>
---
 arch/mips/pmc-sierra/Kconfig            |   12 ------
 arch/mips/pmc-sierra/msp71xx/msp_prom.c |   60 +------------------------------

Looks good to me, but now a build of drivers/mtd/maps/pmcmsp-ramroot.c will fail. Given that it's useless now you should probably remove it, too.

author
#3 lore raw

Hi Christoph:

Quoted 12 lines · Christoph Hellwig
Quoted 11 lines · Shane McDonald

The RAMROOT function was a successful but non-portable attempt to append the root filesystem to the end of the kernel image. The preferred and portable solution is to use an initramfs instead. This patch removes the RAMROOT functionality.

This patch has been compile-tested against the current HEAD.

Signed-off-by Shane McDonald <[email protected]>
---
 arch/mips/pmc-sierra/Kconfig            |   12 ------
 arch/mips/pmc-sierra/msp71xx/msp_prom.c |   60
Quoted 5 lines

+------------------------------

Looks good to me, but now a build of drivers/mtd/maps/pmcmsp-ramroot.c will fail. Given that it's useless now you should probably remove it, too.

Yes, definitely. I wanted to get this patch through before submitting the
mtd patch. Now that this one is accepted, I'll send off the other patch soon.

Shane