Skip to contentSkip to conversation

Fix QCOW2 debugging code to compile again

PATCH In review Filip Navara 2 participants 3 messages Jun 23, 2009 – Jun 24, 2009 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Fix QCOW2 debugging code to compile again

Updated to use C99 comments.

---
 block/qcow2-snapshot.c |    6 +++---
 block/qcow2.c          |    6 +-----
 block/qcow2.h          |    4 ++++
 3 files changed, 8 insertions(+), 8 deletions(-)
block/qcow2-snapshot.c +3 -3
index e1e4d89..94cb838 100644
@@ -288,7 +288,7 @@ int qcow2_snapshot_create(BlockDriverState *bs, QEMUSnapshotInfo *sn_info)
     if (qcow_write_snapshots(bs) < 0)
         goto fail;
 #ifdef DEBUG_ALLOC
-    check_refcounts(bs);
+    qcow2_check_refcounts(bs);
 #endif
     return 0;
  fail:
@@ -332,7 +332,7 @@ int qcow2_snapshot_goto(BlockDriverState *bs, const char *snapshot_id)
         goto fail;
 
 #ifdef DEBUG_ALLOC
-    check_refcounts(bs);
+    qcow2_check_refcounts(bs);
 #endif
     return 0;
  fail:
@@ -369,7 +369,7 @@ int qcow2_snapshot_delete(BlockDriverState *bs, const char *snapshot_id)
         return ret;
     }
 #ifdef DEBUG_ALLOC
-    check_refcounts(bs);
+    qcow2_check_refcounts(bs);
 #endif
     return 0;
 }
block/qcow2.c +1 -5
index 9acbddf..20c114b 100644
@@ -44,10 +44,6 @@
   - L2 tables have always a size of one cluster.
 */
 
-//#define DEBUG_ALLOC
-//#define DEBUG_ALLOC2
-//#define DEBUG_EXT
-
 
 typedef struct {
     uint32_t magic;
@@ -251,7 +247,7 @@ static int qcow_open(BlockDriverState *bs, const char *filename, int flags)
         goto fail;
 
 #ifdef DEBUG_ALLOC
-    check_refcounts(bs);
+    qcow2_check_refcounts(bs);
 #endif
     return 0;
 
block/qcow2.h +4 -0
index d734003..8624e0c 100644
@@ -27,6 +27,10 @@
 
 #include "aes.h"
 
+//#define DEBUG_ALLOC
+//#define DEBUG_ALLOC2
+//#define DEBUG_EXT
+
 #define QCOW_MAGIC (('Q' << 24) | ('F' << 16) | ('I' << 8) | 0xfb)
 #define QCOW_VERSION 2
 
Signature · 1 line
1.6.3.msysgit.0
#1 lore raw
Quoted 1 line · Filip Navara

Updated to use C99 comments.

I don't see any _change_ to the use of C99 comments in the patch below. Some C99 comments are moved from one place to another, that's all.

And some function renaming.

-- Jamie

Quoted 77 lines
---
 block/qcow2-snapshot.c |    6 +++---
 block/qcow2.c          |    6 +-----
 block/qcow2.h          |    4 ++++
 3 files changed, 8 insertions(+), 8 deletions(-)
block/qcow2-snapshot.c +3 -3
index e1e4d89..94cb838 100644
@@ -288,7 +288,7 @@ int qcow2_snapshot_create(BlockDriverState *bs, QEMUSnapshotInfo *sn_info)
     if (qcow_write_snapshots(bs) < 0)
         goto fail;
 #ifdef DEBUG_ALLOC
-    check_refcounts(bs);
+    qcow2_check_refcounts(bs);
 #endif
     return 0;
  fail:
@@ -332,7 +332,7 @@ int qcow2_snapshot_goto(BlockDriverState *bs, const char *snapshot_id)
         goto fail;
 
 #ifdef DEBUG_ALLOC
-    check_refcounts(bs);
+    qcow2_check_refcounts(bs);
 #endif
     return 0;
  fail:
@@ -369,7 +369,7 @@ int qcow2_snapshot_delete(BlockDriverState *bs, const char *snapshot_id)
         return ret;
     }
 #ifdef DEBUG_ALLOC
-    check_refcounts(bs);
+    qcow2_check_refcounts(bs);
 #endif
     return 0;
 }
block/qcow2.c +1 -5
index 9acbddf..20c114b 100644
@@ -44,10 +44,6 @@
   - L2 tables have always a size of one cluster.
 */
 
-//#define DEBUG_ALLOC
-//#define DEBUG_ALLOC2
-//#define DEBUG_EXT
-
 
 typedef struct {
     uint32_t magic;
@@ -251,7 +247,7 @@ static int qcow_open(BlockDriverState *bs, const char *filename, int flags)
         goto fail;
 
 #ifdef DEBUG_ALLOC
-    check_refcounts(bs);
+    qcow2_check_refcounts(bs);
 #endif
     return 0;
 
block/qcow2.h +4 -0
index d734003..8624e0c 100644
@@ -27,6 +27,10 @@
 
 #include "aes.h"
 
+//#define DEBUG_ALLOC
+//#define DEBUG_ALLOC2
+//#define DEBUG_EXT
+
 #define QCOW_MAGIC (('Q' << 24) | ('F' << 16) | ('I' << 8) | 0xfb)
 #define QCOW_VERSION 2
 
#2 lore raw
Quoted 5 lines · Jamie Lokier
Quoted 1 line · Filip Navara

Updated to use C99 comments.

I don't see any _change_ to the use of C99 comments in the patch below. Some C99 comments are moved from one place to another, that's all.

It's a change from the first version of the patch that used C89 comments and which people complained about.

Best regards,
Filip Navara