Skip to contentSkip to conversation

switch do_brk() to get_unmapped_area()

RFC PATCH In review Al Viro 1 participant 1 message Dec 5, 2009

Subsystems (3)
lore
Share & tools
lore

Al Viro

author
#0 lore raw

RFC PATCH 16/18 switch do_brk() to get_unmapped_area()

---
 mm/mmap.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)
mm/mmap.c +2 -8
index e92cbe5..f364677 100644
@@ -1989,20 +1989,14 @@ unsigned long do_brk(unsigned long addr, unsigned long len)
 	if (!len)
 		return addr;
 
-	if ((addr + len) > TASK_SIZE || (addr + len) < addr)
-		return -EINVAL;
-
-	if (is_hugepage_only_range(mm, addr, len))
-		return -EINVAL;
-
 	error = security_file_mmap(NULL, 0, 0, 0, addr, 1);
 	if (error)
 		return error;
 
 	flags = VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT | mm->def_flags;
 
-	error = arch_mmap_check(addr, len, flags);
-	if (error)
+	error = get_unmapped_area(NULL, addr, len, 0, MAP_FIXED | flags);
+	if (error & ~PAGE_MASK)
 		return error;
 
 	/*
Signature · 1 line
1.5.6.5