Skip to contentSkip to conversation

carl9170: reduce channel change delay

PATCH In review Christian Lamparter 2 participants 2 messages Dec 26, 2010 – Dec 29, 2010 CARL9170 Linux community wireless driver

lore
Share & tools
lore

Christian Lamparter

author maintainer
#0 lore raw

PATCH 2/3 carl9170: reduce channel change delay

By removing two "safety" msleeps (and an echo nop), the channel change delay is effectively halved. Previously, the delay could be as long as 260 ms and the device could not go off-channel without risking to miss the next DTIM beacon [interval ~307 ms].

---
Hi Felix,

It seems that removing the msleeps doesn't have ANY negative effect on the operation. Furthermore ath9k doesn't need the 20ms+ msleeps in the phy codepaths either. So, I wonder if this is just some old "safety" buffers which survived otus and ar9170usb development phases, or is there some merit to them?

Regards,
Chr

---
 drivers/net/wireless/ath/carl9170/phy.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
drivers/net/wireless/ath/carl9170/phy.c +0 -8
index 122e75e..b6b0de6 100644
@@ -1029,8 +1029,6 @@ static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz,
 	if (err)
 		return err;
 
-	msleep(20);
-
 	return 0;
 }
 
@@ -1660,12 +1658,6 @@ int carl9170_set_channel(struct ar9170 *ar, struct ieee80211_channel *channel,
 			return err;
 
 		cmd = CARL9170_CMD_RF_INIT;
-
-		msleep(100);
-
-		err = carl9170_echo_test(ar, 0xaabbccdd);
-		if (err)
-			return err;
 	} else {
 		cmd = CARL9170_CMD_FREQUENCY;
 	}
Signature · 1 line
1.7.2.3
#1 lore raw

Hi Christian,

in 2006 people didn't worry about bg-scan yet, so this stuff didn't get optimized. Make it look like ath9k for ar9001. Btw I deeply appreciate your work.

Best regards, Felix

Quoted 48 lines · Christian Lamparter

By removing two "safety" msleeps (and an echo nop), the channel change delay is effectively halved. Previously, the delay could be as long as 260 ms and the device could not go off-channel without risking to miss the next DTIM beacon [interval ~307 ms].

---
Hi Felix,

It seems that removing the msleeps doesn't have ANY negative effect on the operation. Furthermore ath9k doesn't need the 20ms+ msleeps in the phy codepaths either. So, I wonder if this is just some old "safety" buffers which survived otus and ar9170usb development phases, or is there some merit to them?

Regards,
Chr

---
 drivers/net/wireless/ath/carl9170/phy.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
drivers/net/wireless/ath/carl9170/phy.c +0 -8
index 122e75e..b6b0de6 100644
@@ -1029,8 +1029,6 @@ static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz,
 	if (err)
 		return err;
 
-	msleep(20);
-
 	return 0;
 }
 
@@ -1660,12 +1658,6 @@ int carl9170_set_channel(struct ar9170 *ar, struct ieee80211_channel *channel,
 			return err;
 
 		cmd = CARL9170_CMD_RF_INIT;
-
-		msleep(100);
-
-		err = carl9170_echo_test(ar, 0xaabbccdd);
-		if (err)
-			return err;
 	} else {
 		cmd = CARL9170_CMD_FREQUENCY;
 	}