Skip to contentSkip to conversation

kexec x86: drop truncation warning for crash kernel

PATCH Applied Cliff Wickman 2 participants 2 messages Feb 25, 2013 – Mar 5, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kexec x86: drop truncation warning for crash kernel

From: Cliff Wickman <[email protected]>

On kexec set-up of a crash kernel on a very large memory machine we sometimes see the worrisome warning:
Too many memory ranges, truncating...
meaning that the total count of e820 ram, reserved and ACPI spaces is over 128.

Per the comment in do_bzImage_load():
/* If using bzImage for capture kernel, then we will not be
* executing real mode code. setup segment can be loaded
* anywhere as we will be just reading command line. */
So if I understand, the e820 table built here and added to the 'real_mode' area is not going to be used.
So the warning message can be omitted.

---
 kexec/arch/i386/x86-linux-setup.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
kexec/arch/i386/x86-linux-setup.c +8 -1
Index: kexec-tools-2.0.4-rc1/kexec/arch/i386/x86-linux-setup.c
===================================================================
@@ -34,6 +34,7 @@
 #include "../../kexec.h"
 #include "kexec-x86.h"
 #include "x86-linux-setup.h"
+#include "../../kexec/kexec-syscall.h"
 
 void init_linux_parameters(struct x86_linux_param_header *real_mode)
 {
@@ -491,7 +492,13 @@ void setup_linux_system_parameters(struc
 		die("Cannot get memory information\n");
 	}
 	if (ranges > E820MAX) {
-		fprintf(stderr, "Too many memory ranges, truncating...\n");
+		if (!(kexec_flags & KEXEC_ON_CRASH))
+			/*
+			 * this e820 not used for capture kernel, see
+			 * do_bzImage_load()
+			 */
+			fprintf(stderr,
+				"Too many memory ranges, truncating...\n");
 		ranges = E820MAX;
 	}
 	real_mode->e820_map_nr = ranges;

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Applied
#1 lore raw
Quoted 7 lines · Cliff Wickman

From: Cliff Wickman <[email protected]>

On kexec set-up of a crash kernel on a very large memory machine we sometimes see the worrisome warning:
Too many memory ranges, truncating...
meaning that the total count of e820 ram, reserved and ACPI spaces is over 128.

Quoted 8 lines

Per the comment in do_bzImage_load():
/* If using bzImage for capture kernel, then we will not be
* executing real mode code. setup segment can be loaded
* anywhere as we will be just reading command line. */
So if I understand, the e820 table built here and added to the 'real_mode' area is not going to be used.
So the warning message can be omitted.

Thanks, applied.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec