Skip to contentSkip to conversation

phy: Add XGMII phy interface type

PATCH In review Ben Collins 3 participants 7 messages Mar 22, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: Add XGMII phy interface type

Used by systems based on certain Freescale SoCs (specifically the Servergy CTS-1000 system).

---
 include/linux/phy.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/phy.h +1 -0
index 33999ad..5a94ec7 100644
@@ -64,6 +64,7 @@ typedef enum {
 	PHY_INTERFACE_MODE_RGMII_TXID,
 	PHY_INTERFACE_MODE_RTBI,
 	PHY_INTERFACE_MODE_SMII,
+	PHY_INTERFACE_MODE_XGMII,
 } phy_interface_t;
 
 
Signature · 1 line
1.8.1.2
maintainer
#1 lore raw

From: Ben Collins <[email protected]>
Date: Mon, 18 Mar 2013 19:53:42 -0400

Quoted 4 lines

Used by systems based on certain Freescale SoCs (specifically the Servergy CTS-1000 system).

You can resubmit this patch when you submit a driver upstream that uses it, so we can see what the use case looks like.

#2 lore raw
Quoted 10 lines · David Miller

From: Ben Collins <[email protected]>
Date: Mon, 18 Mar 2013 19:53:42 -0400

Quoted 4 lines

Used by systems based on certain Freescale SoCs (specifically the Servergy CTS-1000 system).

You can resubmit this patch when you submit a driver upstream that uses it, so we can see what the use case looks like.

That patch is getting sent soon. It's starting out in staging. Should I Cc you on that?

--
Servergy : http://www.servergy.com/
SwissDisk : http://www.swissdisk.com/
Ubuntu : http://www.ubuntu.com/
My Blog : http://ben-collins.blogspot.com/

maintainer
#3 lore raw

From: Ben Collins <[email protected]>
Date: Fri, 22 Mar 2013 10:17:35 -0400

Quoted 8 lines · David Miller
Quoted 7 lines

From: Ben Collins <[email protected]>
Date: Mon, 18 Mar 2013 19:53:42 -0400

Quoted 3 lines

Used by systems based on certain Freescale SoCs (specifically the Servergy CTS-1000 system).

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

You can resubmit this patch when you submit a driver upstream that uses it, so we can see what the use case looks like.

That patch is getting sent soon. It's starting out in staging. Should I Cc you on that?

Why don't you wait until the driver is good enough for drivers/net proper?

#4 lore raw
Quoted 11 lines · David Miller

From: Ben Collins <[email protected]>
Date: Fri, 22 Mar 2013 10:17:35 -0400

Quoted 8 lines · David Miller
Quoted 7 lines

From: Ben Collins <[email protected]>
Date: Mon, 18 Mar 2013 19:53:42 -0400

Quoted 3 lines

Used by systems based on certain Freescale SoCs (specifically the Servergy CTS-1000 system).

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

You can resubmit this patch when you submit a driver upstream that uses it, so we can see what the use case looks like.

That patch is getting sent soon. It's starting out in staging. Should I Cc you on that?

Why don't you wait until the driver is good enough for drivers/net proper?

It's code that I've manually stripped down as a subset of a larger code base for Freescale's DPAA driver. I've only tested it on our (Servergy's) platform, so until it gets more broad testing (and some code review), I want to at least get it into staging so our hardware is supported.

--
Servergy : http://www.servergy.com/
SwissDisk : http://www.swissdisk.com/
Ubuntu : http://www.ubuntu.com/
My Blog : http://ben-collins.blogspot.com/

maintainer Acked-by
#5 lore raw

From: Ben Collins <[email protected]>
Date: Fri, 22 Mar 2013 10:22:05 -0400

Quoted 5 lines

It's code that I've manually stripped down as a subset of a larger code base for Freescale's DPAA driver. I've only tested it on our (Servergy's) platform, so until it gets more broad testing (and some code review), I want to at least get it into staging so our hardware is supported.

Then why don't you submit the PHY type addition with the staging driver, which will be the only user, and you can add my:

to that.

Thanks.

#6 lore raw
Quoted 9 lines · David Miller

From: Ben Collins <[email protected]>
Date: Fri, 22 Mar 2013 10:22:05 -0400

Quoted 5 lines

It's code that I've manually stripped down as a subset of a larger code base for Freescale's DPAA driver. I've only tested it on our (Servergy's) platform, so until it gets more broad testing (and some code review), I want to at least get it into staging so our hardware is supported.

Quoted 4 lines

Then why don't you submit the PHY type addition with the staging driver, which will be the only user, and you can add my:

That I can do. Greg had asked I get all the rest of this signed off before he could take the driver into staging.

--
Servergy : http://www.servergy.com/
SwissDisk : http://www.swissdisk.com/
Ubuntu : http://www.ubuntu.com/
My Blog : http://ben-collins.blogspot.com/