drivers/base: fix devres handling for master device
Subsystems (2)
PATCH 1/1 drivers/base: fix devres handling for master device
We weren't handling the devres issues for the master device failing a bind, or being unbound properly. Add a devres group to contain these, and release the resources at the appropriate points.
Signed-off-by Russell King <[email protected]>
---
Greg, if you'd be kind enough to queue this for an -rc release, it'd help plug a hole I discovered earlier this week in the component helper. Thanks.
drivers/base/component.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/base/component.c +8 -0
@@ -133,9 +133,16 @@ static int try_to_bring_up_master(struct master *master, goto out; } +if (!devres_open_group (master->dev,NULL ,GFP_KERNEL )) { + ret = -ENOMEM ; + goto out; + } +/* Found all components */ ret = master->ops->bind (master->dev);if (ret <0 ) { +devres_release_group (master->dev,NULL ); +dev_info (master->dev,"master bind failed: %d\n" , ret);master_remove_components (master); goto out; }
@@ -166,6 +173,7 @@ static void take_down_master(struct master *master) {if (master->bound) { master->ops->unbind (master->dev); +devres_release_group (master->dev,NULL ); master->bound = false; }
Signature · 1 line
1.8.3.1