Skip to contentSkip to conversation

mmc: sdhci-bcm-kona: fix build errors when built-in

PATCH New Russell King 1 participant 1 message Feb 26, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: sdhci-bcm-kona: fix build errors when built-in

sdhci_bcm_kona_remove' referenced in section .data' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o

Fixes 058feb53666f ("mmc: sdhci-bcm-kona: make linker-section warning go away")
Cc Markus Mayer <[email protected]>
Cc Christian Daudt <[email protected]>
Cc Matt Porter <[email protected]>

---
Spotted in nightly build testing, this really should not have happened. The commit which caused it does more damage than good by changing more than it should have to fix the warning it reports to have fixed, by turning it into a build error instead. Please be more careful in future when making such changes to fully understand what the section mismatch errors mean and more importantly, exactly what they're referring to. Thanks.

 drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-bcm-kona.c +1 -1
index 20096aaf14b4..e05c39e6292f 100644
@@ -318,7 +318,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
 	return ret;
 }
 
-static int __exit sdhci_bcm_kona_remove(struct platform_device *pdev)
+static int sdhci_bcm_kona_remove(struct platform_device *pdev)
 {
 	return sdhci_pltfm_unregister(pdev);
 }
Signature · 1 line
1.8.3.1