Skip to contentSkip to conversation

arch/arm: Add individual TLB size support.

PATCH New Xiubo Li 2 participants 5 messages Jul 7, 2014 – Sep 18, 2014 Arm (32-bit)

lore
Share & tools
lore

Xiubo Li

author
#0 lore raw

PATCH 1/1 arch/arm: Add individual TLB size support.

This adds CONFIG_TLB_SIZE for individual board, whose TLB size maybe larger than PGTABLE_SIZE.

---
 arch/arm/lib/board.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/lib/board.c +4 -0
index dc34190..b7327ce 100644
@@ -353,7 +353,11 @@ void board_init_f(ulong bootflag)
 
 #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF))
 	/* reserve TLB table */
+#ifdef CONFIG_TLB_SIZE
+	gd->arch.tlb_size = CONFIG_TLB_SIZE;
+#else
 	gd->arch.tlb_size = PGTABLE_SIZE;
+#endif
 	addr -= gd->arch.tlb_size;
 
 	/* round down to next 64 kB limit */
Signature · 1 line
1.8.5
#1 lore raw

PATCH 1/1 arch/arm: Add individual TLB size support.

Hi Xiubo,

Quoted 14 lines · Xiubo Li

This adds CONFIG_TLB_SIZE for individual board, whose TLB size maybe larger than PGTABLE_SIZE.

---
 arch/arm/lib/board.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/lib/board.c +0 -0
index dc34190..b7327ce 100644
@@ -353,7 +353,11 @@ void board_init_f(ulong bootflag)
 

arch/arm/lib/board.c void board_init_f(ulong bootflag) · line 363

Quoted 10 lines
arch/arm/lib/board.c +4 -0
 #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF))
 	/* reserve TLB table */
+#ifdef CONFIG_TLB_SIZE
+	gd->arch.tlb_size = CONFIG_TLB_SIZE;
+#else
 	gd->arch.tlb_size = PGTABLE_SIZE;
+#endif
 	addr -= gd->arch.tlb_size;
 
 	/* round down to next 64 kB limit */

There is no code in current mainline which defines CONFIG_TLB_SIZE; that makes the patch a dead code addition.

Besides, what's the point of this as opposed to, e.g., just defining the right PGTABLE_SIZE, or renaming PGTABLE_SIZE as CONFIG_TLB_SIZE?

Amicalement,

Signature · 1 line
Albert.
#2 lore raw

PATCH 1/1 arch/arm: Add individual TLB size support.

Hi Albert,

Quoted 30 lines

Subject: Re: [PATCH] arch/arm: Add individual TLB size support.

Hi Xiubo,

Quoted 23 lines · Xiubo Li

This adds CONFIG_TLB_SIZE for individual board, whose TLB size maybe larger than PGTABLE_SIZE.

---
 arch/arm/lib/board.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/lib/board.c +4 -0
index dc34190..b7327ce 100644
@@ -353,7 +353,11 @@ void board_init_f(ulong bootflag)
 
 #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF))
 	/* reserve TLB table */
+#ifdef CONFIG_TLB_SIZE
+	gd->arch.tlb_size = CONFIG_TLB_SIZE;
+#else
 	gd->arch.tlb_size = PGTABLE_SIZE;
+#endif
 	addr -= gd->arch.tlb_size;
 
Quoted 5 lines

arch/arm/lib/board.c void board_init_f(ulong bootflag) · line 363

Quoted 1 line
arch/arm/lib/board.c +0 -0
 	/* round down to next 64 kB limit */

There is no code in current mainline which defines CONFIG_TLB_SIZE; that makes the patch a dead code addition.

Yes, this will be used by our LS1 SoC first, and it is still doing The upstream.

Quoted 3 lines

Besides, what's the point of this as opposed to, e.g., just defining the right PGTABLE_SIZE, or renaming PGTABLE_SIZE as CONFIG_TLB_SIZE?

We'll add the LPAE support in uboot and need more space for tlb.

Thanks very much,

BRs
Xiubo

#3 lore raw

PATCH 1/1 arch/arm: Add individual TLB size support.

Hi Li.Xiubo at freescale.com,

Quoted 32 lines · Li.Xiubo at freescale.com

Hi Albert,

Quoted 30 lines

Subject: Re: [PATCH] arch/arm: Add individual TLB size support.

Hi Xiubo,

Quoted 23 lines · Xiubo Li

This adds CONFIG_TLB_SIZE for individual board, whose TLB size maybe larger than PGTABLE_SIZE.

---
 arch/arm/lib/board.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/lib/board.c +4 -0
index dc34190..b7327ce 100644
@@ -353,7 +353,11 @@ void board_init_f(ulong bootflag)
 
 #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF))
 	/* reserve TLB table */
+#ifdef CONFIG_TLB_SIZE
+	gd->arch.tlb_size = CONFIG_TLB_SIZE;
+#else
 	gd->arch.tlb_size = PGTABLE_SIZE;
+#endif
 	addr -= gd->arch.tlb_size;
 
Quoted 8 lines
Quoted 5 lines

arch/arm/lib/board.c void board_init_f(ulong bootflag) · line 363

Quoted 1 line
arch/arm/lib/board.c +0 -0
 	/* round down to next 64 kB limit */

There is no code in current mainline which defines CONFIG_TLB_SIZE; that makes the patch a dead code addition.

Yes, this will be used by our LS1 SoC first, and it is still doing The upstream.

Then please sumbit this patch as part of the LS1 SoC support series, where the code it creates will actually be used.

Quoted 5 lines
Quoted 3 lines

Besides, what's the point of this as opposed to, e.g., just defining the right PGTABLE_SIZE, or renaming PGTABLE_SIZE as CONFIG_TLB_SIZE?

We'll add the LPAE support in uboot and need more space for tlb.

I still don't get it. Is gd->arch.tlb_size the size of a page table or of a translation lookahead buffer?

Quoted 4 lines

Thanks very much,

BRs
Xiubo

Amicalement,

Signature · 1 line
Albert.
#4 lore raw

PATCH 1/1 arch/arm: Add individual TLB size support.

Hi Albert,

Quoted 49 lines · Albert ARIBAUD

Hi Li.Xiubo at freescale.com,

Quoted 32 lines · Li.Xiubo at freescale.com

Hi Albert,

Quoted 30 lines

Subject: Re: [PATCH] arch/arm: Add individual TLB size support.

Hi Xiubo,

Quoted 23 lines · Xiubo Li

This adds CONFIG_TLB_SIZE for individual board, whose TLB size maybe larger than PGTABLE_SIZE.

---
 arch/arm/lib/board.c | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/lib/board.c +4 -0
index dc34190..b7327ce 100644
@@ -353,7 +353,11 @@ void board_init_f(ulong bootflag)
 
 #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF))
 	/* reserve TLB table */
+#ifdef CONFIG_TLB_SIZE
+	gd->arch.tlb_size = CONFIG_TLB_SIZE;
+#else
 	gd->arch.tlb_size = PGTABLE_SIZE;
+#endif
 	addr -= gd->arch.tlb_size;
 
Quoted 8 lines
Quoted 5 lines

arch/arm/lib/board.c void board_init_f(ulong bootflag) · line 363

Quoted 1 line
arch/arm/lib/board.c +0 -0
 	/* round down to next 64 kB limit */

There is no code in current mainline which defines CONFIG_TLB_SIZE; that makes the patch a dead code addition.

Yes, this will be used by our LS1 SoC first, and it is still doing The upstream.

Then please sumbit this patch as part of the LS1 SoC support series, where the code it creates will actually be used.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Besides, what's the point of this as opposed to, e.g., just defining the right PGTABLE_SIZE, or renaming PGTABLE_SIZE as CONFIG_TLB_SIZE?

We'll add the LPAE support in uboot and need more space for tlb.

I still don't get it. Is gd->arch.tlb_size the size of a page table or of a translation lookahead buffer?

Ping on both points. Meanwhile I've put the patch in 'Changes Requested' state.

Quoted 6 lines
Quoted 4 lines

Thanks very much,

BRs
Xiubo

Amicalement,

Amicalement,

Signature · 1 line
Albert.