Skip to contentSkip to conversation

arm: ls102xa: Fixed a register definition error

PATCH New Tang Yuantian 3 participants 6 messages Sep 18, 2014 – Sep 22, 2014 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: ls102xa: Fixed a register definition error

There are 8 SCFG_SPARECR registers in SCFG memory block, not just one.

---
 arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h +1 -1
index 7995fe2..b5db720 100644
@@ -182,7 +182,7 @@ struct ccsr_scfg {
 	u32 etsecmcr;
 	u32 sdhciovserlcr;
 	u32 resv14[61];
-	u32 sparecr;
+	u32 sparecr[8];
 };
 
 /* Clocking */
Signature · 1 line
2.1.0.27.g96db324
#1 lore raw

PATCH 1/1 arm: ls102xa: Fixed a register definition error

Hi Tang,

Quoted 13 lines · Tang Yuantian

There are 8 SCFG_SPARECR registers in SCFG memory block, not just one.

---
 arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h +0 -0
index 7995fe2..b5db720 100644

arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h struct ccsr_scfg { · line 188

Quoted 8 lines
arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h +1 -1
@@ -182,7 +182,7 @@ struct ccsr_scfg {
 	u32 etsecmcr;
 	u32 sdhciovserlcr;
 	u32 resv14[61];
-	u32 sparecr;
+	u32 sparecr[8];
 };
 
 /* Clocking */

Obviously the original code was not problematic as sparecr was not used. Is your change dictated by a patch or series that you are preparing and that will use sparecr?

Amicalement,

Signature · 1 line
Albert.
#2 lore raw

PATCH 1/1 arm: ls102xa: Fixed a register definition error

Quoted 34 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, September 18, 2014 7:25 PM
To: Tang Yuantian-B29983
Cc: Wang Huan-B18965; Lu Jingchang-B35083; Jin Zhengxiong-R64188; Kushwaha Prabhakar-B32579; u-boot at lists.denx.de
Subject: Re: [PATCH] arm: ls102xa: Fixed a register definition error

Hi Tang,

Quoted 20 lines · Tang Yuantian

There are 8 SCFG_SPARECR registers in SCFG memory block, not just one.

---
 arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h +1 -1
index 7995fe2..b5db720 100644
@@ -182,7 +182,7 @@ struct ccsr_scfg {
 	u32 etsecmcr;
 	u32 sdhciovserlcr;
 	u32 resv14[61];
-	u32 sparecr;
+	u32 sparecr[8];
 };
 
Quoted 6 lines

arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h struct ccsr_scfg { · line 188

Quoted 1 line
arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h +0 -0
 /* Clocking */

Obviously the original code was not problematic as sparecr was not used. Is your change dictated by a patch or series that you are preparing and that will use sparecr?

Yes, they will be used by deep sleep patches I am preparing.

Thanks,
Yuantian

Quoted 3 lines

Amicalement,
--
Albert.

#3 lore raw

PATCH 1/1 arm: ls102xa: Fixed a register definition error

Hi Yuantian,

Quoted 34 lines · Yuantian Tang
Quoted 34 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, September 18, 2014 7:25 PM
To: Tang Yuantian-B29983
Cc: Wang Huan-B18965; Lu Jingchang-B35083; Jin Zhengxiong-R64188; Kushwaha Prabhakar-B32579; u-boot at lists.denx.de
Subject: Re: [PATCH] arm: ls102xa: Fixed a register definition error

Hi Tang,

Quoted 20 lines · Tang Yuantian

There are 8 SCFG_SPARECR registers in SCFG memory block, not just one.

---
 arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h +1 -1
index 7995fe2..b5db720 100644
@@ -182,7 +182,7 @@ struct ccsr_scfg {
 	u32 etsecmcr;
 	u32 sdhciovserlcr;
 	u32 resv14[61];
-	u32 sparecr;
+	u32 sparecr[8];
 };
 
Quoted 7 lines
Quoted 6 lines

arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h struct ccsr_scfg { · line 188

Quoted 1 line
arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h +0 -0
 /* Clocking */

Obviously the original code was not problematic as sparecr was not used. Is your change dictated by a patch or series that you are preparing and that will use sparecr?

Yes, they will be used by deep sleep patches I am preparing.

Then please post them inside the deep sleep patch series.

Quoted 4 lines

Thanks,
Yuantian

Quoted 1 line

Amicalement,

Amicalement,

Signature · 1 line
Albert.
#4 lore raw

PATCH 1/1 arm: ls102xa: Fixed a register definition error

OK, if you say so.

Thanks,
Yuantian

Quoted 65 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Friday, September 19, 2014 11:59 PM
To: Tang Yuantian-B29983
Cc: Wang Huan-B18965; Lu Jingchang-B35083; Jin Zhengxiong-R64188; Kushwaha Prabhakar-B32579; u-boot at lists.denx.de
Subject: Re: [PATCH] arm: ls102xa: Fixed a register definition error

Hi Yuantian,

Quoted 34 lines · Yuantian Tang
Quoted 34 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, September 18, 2014 7:25 PM
To: Tang Yuantian-B29983
Cc: Wang Huan-B18965; Lu Jingchang-B35083; Jin Zhengxiong-R64188; Kushwaha Prabhakar-B32579; u-boot at lists.denx.de
Subject: Re: [PATCH] arm: ls102xa: Fixed a register definition error

Hi Tang,

Quoted 20 lines · Tang Yuantian

There are 8 SCFG_SPARECR registers in SCFG memory block, not just one.

---
 arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h +1 -1
index 7995fe2..b5db720 100644
@@ -182,7 +182,7 @@ struct ccsr_scfg {
 	u32 etsecmcr;
 	u32 sdhciovserlcr;
 	u32 resv14[61];
-	u32 sparecr;
+	u32 sparecr[8];
 };
 
Quoted 7 lines
Quoted 6 lines

arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h struct ccsr_scfg { · line 188

Quoted 1 line
arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h +0 -0
 /* Clocking */

Obviously the original code was not problematic as sparecr was not used. Is your change dictated by a patch or series that you are preparing and that will use sparecr?

Yes, they will be used by deep sleep patches I am preparing.

Then please post them inside the deep sleep patch series.

Quoted 4 lines

Thanks,
Yuantian

Quoted 1 line

Amicalement,

Amicalement,
--
Albert.

#5 lore raw

PATCH 1/1 arm: ls102xa: Fixed a register definition error

In reply to Albert ARIBAUD

Verified on board ls1021qds.

Regards,
Alison.

Quoted 42 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, September 18, 2014 7:25 PM
To: Tang Yuantian-B29983
Cc: Wang Huan-B18965; Lu Jingchang-B35083; Jin Zhengxiong-R64188; Kushwaha Prabhakar-B32579; u-boot at lists.denx.de
Subject: Re: [PATCH] arm: ls102xa: Fixed a register definition error

Hi Tang,

Quoted 13 lines · Tang Yuantian

There are 8 SCFG_SPARECR registers in SCFG memory block, not just one.

---
 arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h +0 -0
index 7995fe2..b5db720 100644

arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h struct ccsr_scfg { · line 188

Quoted 8 lines
arch/arm/include/asm/arch-ls102xa/immap_ls102xa.h +1 -1
@@ -182,7 +182,7 @@ struct ccsr_scfg {
 	u32 etsecmcr;
 	u32 sdhciovserlcr;
 	u32 resv14[61];
-	u32 sparecr;
+	u32 sparecr[8];
 };
 
 /* Clocking */

Obviously the original code was not problematic as sparecr was not used. Is your change dictated by a patch or series that you are preparing and that will use sparecr?

Amicalement,
--
Albert.