Skip to contentSkip to conversation

um: enable trace irqflags support

PATCH Thomas Meyer 2 participants 3 messages Oct 20, 2014 User-mode Linux (UML)

lore
Share & tools
lore
#0 lore raw

Am 20.10.2014 11:28 schrieb Daniel Walter <[email protected]>:

Quoted 7 lines

----- Original Message -----

Quoted 5 lines

From: "Thomas Meyer" <[email protected]>
To: "user-mode-linux-devel" <[email protected]>
Sent: Sunday, October 19, 2014 4:14:13 PM
Subject: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support

Quoted 7 lines
Quoted 2 lines

Add TRACE_IRQFLAGS_SUPPORT to UML.
This enables LOCKDEP_SUPPORT and TRACING_SUPPORT.

FYI: I'm currently working on porting ftrace() support to uml. It will take another week or two since I don't have enough time to debug, and it isn't stable yet (read as is panic()ing randomly)

Good to know :-)

Thanks for you stack trace support work!

BTW. When triggering a sysrq t with the uml console the stack trace is not displayed, it says that the stack trace failed because a sigsegv happens in the stack trace or something like that. Bug or feature?

Quoted 33 lines
Quoted 33 lines

---

arch/um/Kconfig.common +0 -0
index 87bc868..6a33c3a 100644 
@@ -28,10 +28,9 @@ config PCI 

  config PCMCIA
  bool

-# Yet to do!
  config TRACE_IRQFLAGS_SUPPORT
  bool
- default n
+ default y

  config LOCKDEP_SUPPORT
  bool

arch/um/include/asm/irqflags.h +0 -0
index c780d8a..c5b636e 100644 
@@ -34,9 +34,9 @@ static inline unsigned long 
 arch_local_irq_save(void) 
   return flags; 
   } 

arch/um/include/asm/irqflags.h +1 -1
-static inline bool arch_irqs_disabled(void) 
+static inline int arch_irqs_disabled_flags(unsigned long flags) 

  {

Quoted 8 lines
Quoted 5 lines

- return arch_local_save_flags() == 0;
+ return flags == 0;
  }

  #endif

I'm not sure if this is correct. I'd rather would have another function implemented instead of removing the check for disabled irqs.

There is a default coding for arch_irqs_disabled which calls arch_irqs_disabled_flags.

The logic after above change should be the same as before.

Quoted 5 lines

cheers,

daniel

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

#1 lore raw
Quoted 16 lines · Thomas Meyer

Am 20.10.2014 11:28 schrieb Daniel Walter <[email protected]>:

Quoted 7 lines

----- Original Message -----

Quoted 5 lines

From: "Thomas Meyer" <[email protected]>
To: "user-mode-linux-devel" <[email protected]>
Sent: Sunday, October 19, 2014 4:14:13 PM
Subject: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support

Quoted 7 lines
Quoted 2 lines

Add TRACE_IRQFLAGS_SUPPORT to UML.
This enables LOCKDEP_SUPPORT and TRACING_SUPPORT.

FYI: I'm currently working on porting ftrace() support to uml. It will take another week or two since I don't have enough time to debug, and it isn't stable yet (read as is panic()ing randomly)

Quoted 5 lines

Good to know :-)

Thanks for you stack trace support work!

BTW. When triggering a sysrq t with the uml console the stack trace is not displayed, it says that the stack trace failed because a sigsegv happens in the stack trace or something like that. Bug or feature?

Huh? More details please. uml_mconsole's sysrq t works fine here with both x86 and x86_86 uml.

Signature · 13 lines
Thanks,
//richard

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
#2 lore raw

Am 20.10.2014 um 14:13 schrieb Richard Weinberger:

Quoted 17 lines · Thomas Meyer
Quoted 16 lines

Am 20.10.2014 11:28 schrieb Daniel Walter <[email protected]>:

Quoted 14 lines

----- Original Message -----

Quoted 7 lines

From: "Thomas Meyer" <[email protected]>
To: "user-mode-linux-devel" <[email protected]>
Sent: Sunday, October 19, 2014 4:14:13 PM
Subject: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support

Add TRACE_IRQFLAGS_SUPPORT to UML.
This enables LOCKDEP_SUPPORT and TRACING_SUPPORT.

FYI: I'm currently working on porting ftrace() support to uml. It will take another week or two since I don't have enough time to debug, and it isn't stable yet (read as is panic()ing randomly)

Quoted 8 lines
Quoted 5 lines

Good to know :-)

Thanks for you stack trace support work!

BTW. When triggering a sysrq t with the uml console the stack trace is not displayed, it says that the stack trace failed because a sigsegv happens in the stack trace or something like that. Bug or feature?

Huh? More details please. uml_mconsole's sysrq t works fine here with both x86 and x86_86 uml.

Hi,

sorry about the fuss. everything seems to work correctly.

Maybe I did see this while doing some testing with some fixes.

sorry.

Quoted 4 lines
Signature · 3 lines
-- 
Thanks,
//richard

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel