Applied "ASoC: zx: spdif: Fix devm_ioremap_resource return value check" to the asoc tree
Mark Brown
maintainerThe patch
ASoC: zx: spdif: Fix devm_ioremap_resource return value check
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
2dfbe9afcda3243dd309826cbbb8ae9e9f602006Mon Sep 17 00:00:00 2001
From: Krzysztof Kozlowski <[email protected]>
Date: Thu, 9 Jul 2015 22:19:29 +0900
Subject: [PATCH] ASoC: zx: spdif: Fix devm_ioremap_resource return value check
Value returned by devm_ioremap_resource() was checked for non-NULL but devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of error this could lead to dereference of ERR_PTR.
--- sound/soc/zte/zx296702-spdif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/zte/zx296702-spdif.c +2 -2
@@ -322,9 +322,9 @@ static int zx_spdif_probe(struct platform_device *pdev) res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); zx_spdif->mapbase = res->start; zx_spdif->reg_base =devm_ioremap_resource (&pdev->dev, res); -if (!zx_spdif->reg_base) { +if (IS_ERR (zx_spdif->reg_base)) {dev_err (&pdev->dev,"ioremap failed!\n" ); -return -EIO ; +return PTR_ERR (zx_spdif->reg_base); }zx_spdif_dev_init (zx_spdif->reg_base);
Signature · 1 line
2.1.4