regmap: Silence warning on invalid zero length read
Subsystems (2)
Mark Brown
maintainerPATCH 1/1 regmap: Silence warning on invalid zero length read
Zero length reads make no sense in a regmap context and are likely to trigger bugs further down the stack so insert an error check, also silencing compiler warnings about use of ret in cases where we iterate per register.
---
Not even compile tested yet.
drivers/base/regmap/regmap.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/base/regmap/regmap.c +2 -0
@@ -2179,6 +2179,8 @@ int regmap_raw_read(struct regmap *map, unsigned int reg, void *val,return -EINVAL ;if (reg % map->reg_stride)return -EINVAL ; +if (val_count ==0 ) +return -EINVAL ; map->lock (map->lock_arg);
Signature · 1 line
2.1.4
Mark Brown
maintainerApplied "regmap: Silence warning on invalid zero length read" to the regmap tree
The patch
regmap: Silence warning on invalid zero length read
has been applied to the regmap tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
fa3eec7791b0fe27e3112804a71ba445ff336a6bMon Sep 17 00:00:00 2001
From: Mark Brown <[email protected]>
Date: Wed, 1 Jul 2015 23:51:43 +0100
Subject: [PATCH] regmap: Silence warning on invalid zero length read
Zero length reads make no sense in a regmap context and are likely to trigger bugs further down the stack so insert an error check, also silencing compiler warnings about use of ret in cases where we iterate per register.
--- drivers/base/regmap/regmap.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/base/regmap/regmap.c +2 -0
@@ -2180,6 +2180,8 @@ int regmap_raw_read(struct regmap *map, unsigned int reg, void *val,return -EINVAL ;if (reg % map->reg_stride)return -EINVAL ; +if (val_count ==0 ) +return -EINVAL ; map->lock (map->lock_arg);
Signature · 1 line
2.1.4