Skip to contentSkip to conversation

ASoC: Fix sparse warnings

PATCH In review Lars-Peter Clausen 7 participants 19 messages Jul 27, 2015 – Jul 29, 2015

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

cover ASoC: Fix sparse warnings

Hi,

This series fixes a couple of sparse warnings that have appeared recently in the ASoC tree. Non of them are critical mostly just missing annotations or storage qualifiers. It still makes sense to fix those though since it reduces the noise that has to be filtered through when checking new code for new (potentially critical) warnings.

- Lars

Lars-Peter Clausen (6):
ASoC: wm8804: Drop dublicate const
ASoC: lpass-ipq806x: Staticise local symbols
ASoC: rcar ctu: Staticise local symbols
ASoC: uniperf: Add missing __iomem annotation
ASoC: uniperf: Staticise local symbols
ASoC: xtfpga-i2s: Add missing __rcu annotation

 sound/soc/codecs/wm8804.c       | 2 +-
 sound/soc/qcom/lpass-ipq806x.c  | 2 +-
 sound/soc/sh/rcar/ctu.c         | 2 +-
 sound/soc/sti/uniperif.h        | 2 +-
 sound/soc/sti/uniperif_player.c | 2 +-
 sound/soc/xtensa/xtfpga-i2s.c   | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/6 ASoC: wm8804: Drop dublicate const

SOC_ENUM_SINGLE_DECL() already includes a const, drop the extra const. Fixes the following sparse warning:

	sound/soc/codecs/wm8804.c:101:14: warning: duplicate const
---
 sound/soc/codecs/wm8804.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/wm8804.c +1 -1
index c195c2e..8d91470 100644
@@ -98,7 +98,7 @@ WM8804_REGULATOR_EVENT(0)
 WM8804_REGULATOR_EVENT(1)
 
 static const char *txsrc_text[] = { "S/PDIF RX", "AIF" };
-static const SOC_ENUM_SINGLE_DECL(txsrc, WM8804_SPDTX4, 6, txsrc_text);
+static SOC_ENUM_SINGLE_DECL(txsrc, WM8804_SPDTX4, 6, txsrc_text);
 
 static const struct snd_kcontrol_new wm8804_tx_source_mux[] = {
 	SOC_DAPM_ENUM_EXT("Input Source", txsrc,
Signature · 1 line
2.1.4
maintainer
#3 lore raw

Applied "ASoC: wm8804: Drop duplicate const" to the asoc tree

In reply to Lars-Peter Clausen

The patch

ASoC: wm8804: Drop duplicate const

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From c8a6b92be8516c92cf46bc127fa0adf53a05d31c Mon Sep 17 00:00:00 2001

From: Lars-Peter Clausen <[email protected]>
Date: Mon, 27 Jul 2015 10:56:23 +0200
Subject: [PATCH] ASoC: wm8804: Drop duplicate const

SOC_ENUM_SINGLE_DECL() already includes a const, drop the extra const. Fixes the following sparse warning:

	sound/soc/codecs/wm8804.c:101:14: warning: duplicate const
---
 sound/soc/codecs/wm8804.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/wm8804.c +1 -1
index c195c2e..8d91470 100644
@@ -98,7 +98,7 @@ WM8804_REGULATOR_EVENT(0)
 WM8804_REGULATOR_EVENT(1)
 
 static const char *txsrc_text[] = { "S/PDIF RX", "AIF" };
-static const SOC_ENUM_SINGLE_DECL(txsrc, WM8804_SPDTX4, 6, txsrc_text);
+static SOC_ENUM_SINGLE_DECL(txsrc, WM8804_SPDTX4, 6, txsrc_text);
 
 static const struct snd_kcontrol_new wm8804_tx_source_mux[] = {
 	SOC_DAPM_ENUM_EXT("Input Source", txsrc,
Signature · 1 line
2.1.4
#4 lore raw

PATCH 2/6 ASoC: lpass-ipq806x: Staticise local symbols

In reply to Lars-Peter Clausen

ipq806x_data is not used outside this file, so it can be static. Fixes the following sparse warning:

	sound/soc/qcom/lpass-ipq806x.c:76:22: warning: symbol 'ipq806x_data'
		was not declared. Should it be static?
---
 sound/soc/qcom/lpass-ipq806x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/qcom/lpass-ipq806x.c +1 -1
index 7356d3a..7a41679 100644
@@ -73,7 +73,7 @@ static int ipq806x_lpass_free_dma_channel(struct lpass_data *drvdata, int chan)
 	return 0;
 }
 
-struct lpass_variant ipq806x_data = {
+static struct lpass_variant ipq806x_data = {
 	.i2sctrl_reg_base	= 0x0010,
 	.i2sctrl_reg_stride	= 0x04,
 	.i2s_ports		= 5,
Signature · 1 line
2.1.4
Acked-by on v1 2/6
#5 lore raw

Re: [PATCH 2/6] ASoC: lpass-ipq806x: Staticise local symbols

Quoted 17 lines · Lars-Peter Clausen

ipq806x_data is not used outside this file, so it can be static. Fixes the following sparse warning:

	sound/soc/qcom/lpass-ipq806x.c:76:22: warning: symbol 'ipq806x_data'
		was not declared. Should it be static?
---
  sound/soc/qcom/lpass-ipq806x.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/qcom/lpass-ipq806x.c +0 -0
index 7356d3a..7a41679 100644

sound/soc/qcom/lpass-ipq806x.c static int ipq806x_lpass_free_dma_channel(struct lpass_data *drvdata, int chan) · line 79

Quoted 8 lines
sound/soc/qcom/lpass-ipq806x.c +1 -1
@@ -73,7 +73,7 @@ static int ipq806x_lpass_free_dma_channel(struct lpass_data *drvdata, int chan)
  	return 0;
  }
 
-struct lpass_variant ipq806x_data = {
+static struct lpass_variant ipq806x_data = {
  	.i2sctrl_reg_base	= 0x0010,
  	.i2sctrl_reg_stride	= 0x04,
  	.i2s_ports		= 5,

Thanks Lars for the patch, Looks good to me.

--srini

maintainer
#6 lore raw

Applied "ASoC: lpass-ipq806x: Staticise local symbols" to the asoc tree

In reply to Lars-Peter Clausen

The patch

ASoC: lpass-ipq806x: Staticise local symbols

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From eccad574ef2d74e7519a092d9822932a27c6f165 Mon Sep 17 00:00:00 2001

From: Lars-Peter Clausen <[email protected]>
Date: Mon, 27 Jul 2015 10:56:24 +0200
Subject: [PATCH] ASoC: lpass-ipq806x: Staticise local symbols

ipq806x_data is not used outside this file, so it can be static. Fixes the following sparse warning:

	sound/soc/qcom/lpass-ipq806x.c:76:22: warning: symbol 'ipq806x_data'
		was not declared. Should it be static?
---
 sound/soc/qcom/lpass-ipq806x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/qcom/lpass-ipq806x.c +1 -1
index 7356d3a..7a41679 100644
@@ -73,7 +73,7 @@ static int ipq806x_lpass_free_dma_channel(struct lpass_data *drvdata, int chan)
 	return 0;
 }
 
-struct lpass_variant ipq806x_data = {
+static struct lpass_variant ipq806x_data = {
 	.i2sctrl_reg_base	= 0x0010,
 	.i2sctrl_reg_stride	= 0x04,
 	.i2s_ports		= 5,
Signature · 1 line
2.1.4
#7 lore raw

PATCH 3/6 ASoC: rcar ctu: Staticise local symbols

In reply to Lars-Peter Clausen

rsnd_of_parse_ctu() is not used outside this file so it can be static. Fixes the following sparse warning:

sound/soc/sh/rcar/ctu.c:72:6: warning: symbol 'rsnd_of_parse_ctu' was
not declared. Should it be static?

---
 sound/soc/sh/rcar/ctu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sh/rcar/ctu.c +1 -1
index 05edd20..05498bb 100644
@@ -69,7 +69,7 @@ struct rsnd_mod *rsnd_ctu_mod_get(struct rsnd_priv *priv, int id)
 	return &((struct rsnd_ctu *)(priv->ctu) + id)->mod;
 }
 
-void rsnd_of_parse_ctu(struct platform_device *pdev,
+static void rsnd_of_parse_ctu(struct platform_device *pdev,
 		       const struct rsnd_of_data *of_data,
 		       struct rsnd_priv *priv)
 {
Signature · 1 line
2.1.4
maintainer
#9 lore raw

Applied "ASoC: rcar ctu: Staticise local symbols" to the asoc tree

In reply to Lars-Peter Clausen

The patch

ASoC: rcar ctu: Staticise local symbols

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From e773c2f964640e103cc75a45aa4555c73ba55c29 Mon Sep 17 00:00:00 2001

From: Lars-Peter Clausen <[email protected]>
Date: Mon, 27 Jul 2015 10:56:25 +0200
Subject: [PATCH] ASoC: rcar ctu: Staticise local symbols

rsnd_of_parse_ctu() is not used outside this file so it can be static. Fixes the following sparse warning:

sound/soc/sh/rcar/ctu.c:72:6: warning: symbol 'rsnd_of_parse_ctu' was
not declared. Should it be static?

---
 sound/soc/sh/rcar/ctu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sh/rcar/ctu.c +1 -1
index 05edd20..05498bb 100644
@@ -69,7 +69,7 @@ struct rsnd_mod *rsnd_ctu_mod_get(struct rsnd_priv *priv, int id)
 	return &((struct rsnd_ctu *)(priv->ctu) + id)->mod;
 }
 
-void rsnd_of_parse_ctu(struct platform_device *pdev,
+static void rsnd_of_parse_ctu(struct platform_device *pdev,
 		       const struct rsnd_of_data *of_data,
 		       struct rsnd_priv *priv)
 {
Signature · 1 line
2.1.4
#10 lore raw

PATCH 4/6 ASoC: uniperf: Add missing __iomem annotation

In reply to Lars-Peter Clausen

base referes to a iomem region, so it should have the __iomem annotation. Fixes the following warnings from sparse:

sound/soc/sti/sti_uniperif.c:169:19: warning: incorrect type in
assignment (different address spaces)
sound/soc/sti/sti_uniperif.c:169:19: expected void *base
sound/soc/sti/sti_uniperif.c:169:19: got void [noderef] <asn:2>*
sound/soc/sti/uniperif_player.c:104:18: warning: incorrect type in
argument 1 (different address spaces)
sound/soc/sti/uniperif_player.c:104:18: expected void const volatile
[noderef] <asn:2>*addr
sound/soc/sti/uniperif_player.c:104:18: got void *
[...]

---
 sound/soc/sti/uniperif.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sti/uniperif.h +1 -1
index ee462f7..f0fd5a9 100644
@@ -1168,7 +1168,7 @@ struct uniperif {
 
 	/* Resources */
 	struct resource *mem_region;
-	void *base;
+	void __iomem *base;
 	unsigned long fifo_phys_address;
 	int irq;
 
Signature · 1 line
2.1.4
Acked-by on v1 4/6
#11 lore raw

Re: [PATCH 4/6] ASoC: uniperf: Add missing __iomem annotation

Hi

Quoted 25 lines · Lars-Peter Clausen

base referes to a iomem region, so it should have the __iomem annotation. Fixes the following warnings from sparse:

sound/soc/sti/sti_uniperif.c:169:19: warning: incorrect type in
assignment (different address spaces)
sound/soc/sti/sti_uniperif.c:169:19: expected void *base
sound/soc/sti/sti_uniperif.c:169:19: got void [noderef] <asn:2>*
sound/soc/sti/uniperif_player.c:104:18: warning: incorrect type in
argument 1 (different address spaces)
sound/soc/sti/uniperif_player.c:104:18: expected void const volatile
[noderef] <asn:2>*addr
sound/soc/sti/uniperif_player.c:104:18: got void *
[...]

---
  sound/soc/sti/uniperif.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sti/uniperif.h +0 -0
index ee462f7..f0fd5a9 100644

sound/soc/sti/uniperif.h struct uniperif { · line 1174

Quoted 8 lines
sound/soc/sti/uniperif.h +1 -1
@@ -1168,7 +1168,7 @@ struct uniperif {
 
  	/* Resources */
  	struct resource *mem_region;
-	void *base;
+	void __iomem *base;
  	unsigned long fifo_phys_address;
  	int irq;
 

Thanks for the patch,

Br,
Arnaud

maintainer
#12 lore raw

Applied "ASoC: uniperf: Add missing __iomem annotation" to the asoc tree

In reply to Lars-Peter Clausen

The patch

ASoC: uniperf: Add missing __iomem annotation

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From b917abb4064b38b0613e953b09213e788ad94ad0 Mon Sep 17 00:00:00 2001

From: Lars-Peter Clausen <[email protected]>
Date: Mon, 27 Jul 2015 10:56:26 +0200
Subject: [PATCH] ASoC: uniperf: Add missing __iomem annotation

base referes to a iomem region, so it should have the __iomem annotation. Fixes the following warnings from sparse:

sound/soc/sti/sti_uniperif.c:169:19: warning: incorrect type in
assignment (different address spaces)
sound/soc/sti/sti_uniperif.c:169:19: expected void *base
sound/soc/sti/sti_uniperif.c:169:19: got void [noderef] <asn:2>*
sound/soc/sti/uniperif_player.c:104:18: warning: incorrect type in
argument 1 (different address spaces)
sound/soc/sti/uniperif_player.c:104:18: expected void const volatile
[noderef] <asn:2>*addr
sound/soc/sti/uniperif_player.c:104:18: got void *
[...]

---
 sound/soc/sti/uniperif.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sti/uniperif.h +1 -1
index ee462f7..f0fd5a9 100644
@@ -1168,7 +1168,7 @@ struct uniperif {
 
 	/* Resources */
 	struct resource *mem_region;
-	void *base;
+	void __iomem *base;
 	unsigned long fifo_phys_address;
 	int irq;
 
Signature · 1 line
2.1.4
#13 lore raw

PATCH 5/6 ASoC: uniperf: Staticise local symbols

In reply to Lars-Peter Clausen

uni_player_dai_ops is not used outside of this file so it should be static. Fixes the following sparse warning:

	sound/soc/sti/uniperif_player.c:959:30: warning: symbol
		'uni_player_dai_ops' was not declared. Should it be static?
---
 sound/soc/sti/uniperif_player.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sti/uniperif_player.c +1 -1
index f609089..d8df906 100644
@@ -956,7 +956,7 @@ static int uni_player_parse_dt(struct platform_device *pdev,
 	return 0;
 }
 
-const struct snd_soc_dai_ops uni_player_dai_ops = {
+static const struct snd_soc_dai_ops uni_player_dai_ops = {
 		.startup = uni_player_startup,
 		.shutdown = uni_player_shutdown,
 		.prepare = uni_player_prepare,
Signature · 1 line
2.1.4
Acked-by on v1 5/6
#14 lore raw

Re: [PATCH 5/6] ASoC: uniperf: Staticise local symbols

Hi,

Quoted 8 lines · Lars-Peter Clausen

uni_player_dai_ops is not used outside of this file so it should be static. Fixes the following sparse warning:

	sound/soc/sti/uniperif_player.c:959:30: warning: symbol
		'uni_player_dai_ops' was not declared. Should it be static?

---

Thanks for this one also

Br
Arnaud

maintainer
#15 lore raw

Applied "ASoC: uniperf: Staticise local symbols" to the asoc tree

In reply to Lars-Peter Clausen

The patch

ASoC: uniperf: Staticise local symbols

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 85cf604edc18722140f73e225394722801e55de0 Mon Sep 17 00:00:00 2001

From: Lars-Peter Clausen <[email protected]>
Date: Mon, 27 Jul 2015 10:56:27 +0200
Subject: [PATCH] ASoC: uniperf: Staticise local symbols

uni_player_dai_ops is not used outside of this file so it should be static. Fixes the following sparse warning:

	sound/soc/sti/uniperif_player.c:959:30: warning: symbol
		'uni_player_dai_ops' was not declared. Should it be static?
---
 sound/soc/sti/uniperif_player.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sti/uniperif_player.c +1 -1
index f609089..d8df906 100644
@@ -956,7 +956,7 @@ static int uni_player_parse_dt(struct platform_device *pdev,
 	return 0;
 }
 
-const struct snd_soc_dai_ops uni_player_dai_ops = {
+static const struct snd_soc_dai_ops uni_player_dai_ops = {
 		.startup = uni_player_startup,
 		.shutdown = uni_player_shutdown,
 		.prepare = uni_player_prepare,
Signature · 1 line
2.1.4
#16 lore raw

PATCH 6/6 ASoC: xtfpga-i2s: Add missing __rcu annotation

In reply to Lars-Peter Clausen

tx_substeam is accessed using the RCU API and hence should have the __rcu annotation. Fixes the following sparse warnings:

	sound/soc/xtensa/xtfpga-i2s.c:165:24: error: incompatible types in
		comparison expression (different address spaces)
	sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream
		[noderef] <asn:4>*' versus
	sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream *'
	sound/soc/xtensa/xtfpga-i2s.c:255:24: error: incompatible types in
		comparison expression (different address spaces)
	sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream
		[noderef] <asn:4>*' versus
	sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream *'
---
 sound/soc/xtensa/xtfpga-i2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/xtensa/xtfpga-i2s.c +1 -1
index 039f65e..8382ffa 100644
@@ -75,7 +75,7 @@ struct xtfpga_i2s {
 	 * stream in the pcm_close callback it synchronizes with the interrupt
 	 * handler by means of synchronize_rcu call.
 	 */
-	struct snd_pcm_substream *tx_substream;
+	struct snd_pcm_substream __rcu *tx_substream;
 	unsigned (*tx_fn)(struct xtfpga_i2s *i2s,
 			  struct snd_pcm_runtime *runtime,
 			  unsigned tx_ptr);
Signature · 1 line
2.1.4
maintainer Acked-by on v1 6/6
#17 lore raw

Re: [PATCH 6/6] ASoC: xtfpga-i2s: Add missing __rcu annotation

Quoted 14 lines · Lars-Peter Clausen

tx_substeam is accessed using the RCU API and hence should have the __rcu annotation. Fixes the following sparse warnings:

        sound/soc/xtensa/xtfpga-i2s.c:165:24: error: incompatible types in
                comparison expression (different address spaces)
        sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream
                [noderef] <asn:4>*' versus
        sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream *'
        sound/soc/xtensa/xtfpga-i2s.c:255:24: error: incompatible types in
                comparison expression (different address spaces)
        sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream
                [noderef] <asn:4>*' versus
        sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream *'
Quoted 4 lines
---
 sound/soc/xtensa/xtfpga-i2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thank you for the fix, Lars-Peter.

Signature · 2 lines
Thanks.
-- Max
maintainer
#18 lore raw

Applied "ASoC: xtfpga-i2s: Add missing __rcu annotation" to the asoc tree

In reply to Lars-Peter Clausen

The patch

ASoC: xtfpga-i2s: Add missing __rcu annotation

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From d32e03f0b6f9b4ad260feca1c5c938a882066de9 Mon Sep 17 00:00:00 2001

From: Lars-Peter Clausen <[email protected]>
Date: Mon, 27 Jul 2015 10:56:28 +0200
Subject: [PATCH] ASoC: xtfpga-i2s: Add missing __rcu annotation

tx_substeam is accessed using the RCU API and hence should have the __rcu annotation. Fixes the following sparse warnings:

	sound/soc/xtensa/xtfpga-i2s.c:165:24: error: incompatible types in
		comparison expression (different address spaces)
	sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream
		[noderef] <asn:4>*' versus
	sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream *'
	sound/soc/xtensa/xtfpga-i2s.c:255:24: error: incompatible types in
		comparison expression (different address spaces)
	sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream
		[noderef] <asn:4>*' versus
	sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream *'
---
 sound/soc/xtensa/xtfpga-i2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/xtensa/xtfpga-i2s.c +1 -1
index 039f65e..8382ffa 100644
@@ -75,7 +75,7 @@ struct xtfpga_i2s {
 	 * stream in the pcm_close callback it synchronizes with the interrupt
 	 * handler by means of synchronize_rcu call.
 	 */
-	struct snd_pcm_substream *tx_substream;
+	struct snd_pcm_substream __rcu *tx_substream;
 	unsigned (*tx_fn)(struct xtfpga_i2s *i2s,
 			  struct snd_pcm_runtime *runtime,
 			  unsigned tx_ptr);
Signature · 1 line
2.1.4