Skip to contentSkip to conversation

ASoC: simple-card: Add pm callbacks to platform driver

PATCH In review Peter Ujfalusi 2 participants 2 messages May 9, 2016 – May 10, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: simple-card: Add pm callbacks to platform driver

Set snd_soc_pm_ops for the pm ops to make sure that the ASoC level of PM operations are going to happen. This is needed to get suspend/resume working correctly when the audio is using simple-card.

---
Hi Mark,

we have moved most of the TI boards to use simple-card and I have noticed that we have quite bad regression because of it caused by simple-card not having the pm ops configured. This will render audio to not recover after suspend/resume when the audio IP is loosing context.

Regards,
Peter

 sound/soc/generic/simple-card.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/generic/simple-card.c +1 -0
index c6111e7a6d93..52a1e1ff3c62 100644
@@ -658,6 +658,7 @@ MODULE_DEVICE_TABLE(of, asoc_simple_of_match);
 static struct platform_driver asoc_simple_card = {
 	.driver = {
 		.name = "asoc-simple-card",
+		.pm = &snd_soc_pm_ops,
 		.of_match_table = asoc_simple_of_match,
 	},
 	.probe = asoc_simple_card_probe,
Signature · 1 line
2.8.1
maintainer
#1 lore raw

Applied "ASoC: simple-card: Add pm callbacks to platform driver" to the asoc tree

The patch

ASoC: simple-card: Add pm callbacks to platform driver

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 7c3767115a04bc7aa87bdbd3352d1801d4bbeea4 Mon Sep 17 00:00:00 2001

From: Peter Ujfalusi <[email protected]>
Date: Mon, 9 May 2016 13:38:10 +0300
Subject: [PATCH] ASoC: simple-card: Add pm callbacks to platform driver

Set snd_soc_pm_ops for the pm ops to make sure that the ASoC level of PM operations are going to happen. This is needed to get suspend/resume working correctly when the audio is using simple-card.

---
 sound/soc/generic/simple-card.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/generic/simple-card.c +1 -0
index 2389ab47e25f..466492b7d4f5 100644
@@ -643,6 +643,7 @@ MODULE_DEVICE_TABLE(of, asoc_simple_of_match);
 static struct platform_driver asoc_simple_card = {
 	.driver = {
 		.name = "asoc-simple-card",
+		.pm = &snd_soc_pm_ops,
 		.of_match_table = asoc_simple_of_match,
 	},
 	.probe = asoc_simple_card_probe,
Signature · 1 line
2.8.1