kuser updates for ARM-only vs Thumb
Russell King - ARM Linux
maintainercover kuser updates for ARM-only vs Thumb
A while back, an issue was raised about the return instruction used in the kuser page when building an ARMv4 and later environment.
In order to fix this, I suggested building the kuser code for both variants and selecting the appropriate version at run time. This seemed to be a simple solution, but due to the fix-ups and need to build the appropriate version for the Kconfig options selected, turned out to be not quite as trivial as I hoped.
Nevertheless, this patch series provides that solution.
As a side effect of this, the first patch is one which should be merged irrespective of the remainder as it provides a useful cleanup to the large number of dependencies for the ARM_THUMB option.
arch/arm/kernel/Makefile | 10 +++ arch/arm/kernel/entry-armv.S | 198 ------------------------------------------- arch/arm/kernel/kuser-t.S | 13 +++ arch/arm/kernel/kuser-v4.S | 11 +++ arch/arm/kernel/kuser.S | 196 ++++++++++++++++++++++++++++++++++++++++++ arch/arm/kernel/traps.c | 37 +++++++- arch/arm/mm/Kconfig | 31 +++++-- 7 files changed, 289 insertions(+), 207 deletions(-) create mode 100644 arch/arm/kernel/kuser-t.S create mode 100644 arch/arm/kernel/kuser-v4.S create mode 100644 arch/arm/kernel/kuser.S
Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
PATCH 1/4 ARM: add CPU_THUMB_CAPABLE to indicate possible Thumb support
Clean up arch/arm/mm/Kconfig a little to provide a symbol which indicates whether the CPU may support the Thumb instruction set. This gets rid of the growing dependencies on ARM_THUMB, and also gives us a useful Kconfig symbol for choosing the kuser code.
--- arch/arm/mm/Kconfig | 31 ++++++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-)
arch/arm/mm/Kconfig +26 -5
@@ -29,6 +29,7 @@ config CPU_ARM720T select CPU_COPY_V4WT if MMU select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WT if MMU help A 32-bit RISC processor with 8kByte Cache, Write Buffer and
@@ -46,6 +47,7 @@ config CPU_ARM740T select CPU_CACHE_V4 select CPU_CP15_MPU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE help A 32-bit RISC processor with 8KB cache or 4KB variants, write buffer and MPU(Protection Unit) built around
@@ -79,6 +81,7 @@ config CPU_ARM920T select CPU_COPY_V4WB if MMU select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WBI if MMU help The ARM920T is licensed to be produced by numerous vendors,
@@ -97,6 +100,7 @@ config CPU_ARM922T select CPU_COPY_V4WB if MMU select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WBI if MMU help The ARM922T is a version of the ARM920T, but with smaller
@@ -116,6 +120,7 @@ config CPU_ARM925T select CPU_COPY_V4WB if MMU select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WBI if MMU help The ARM925T is a mix between the ARM920T and ARM926T, but with
@@ -134,6 +139,7 @@ config CPU_ARM926T select CPU_COPY_V4WB if MMU select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WBI if MMU help This is a variant of the ARM920. It has slightly different
@@ -170,6 +176,7 @@ config CPU_ARM940T select CPU_CACHE_VIVT select CPU_CP15_MPU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE help ARM940T is a member of the ARM9TDMI family of general- purpose microprocessors with MPU and separate 4KB
@@ -188,6 +195,7 @@ config CPU_ARM946E select CPU_CACHE_VIVT select CPU_CP15_MPU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE help ARM946E-S is a member of the ARM9E-S family of high- performance, 32-bit system-on-chip processor solutions.
@@ -206,6 +214,7 @@ config CPU_ARM1020 select CPU_COPY_V4WB if MMU select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WBI if MMU help The ARM1020 is the 32K cached version of the ARM10 processor,
@@ -225,6 +234,7 @@ config CPU_ARM1020E select CPU_COPY_V4WB if MMU select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WBI if MMU # ARM1022E
@@ -236,6 +246,7 @@ config CPU_ARM1022 select CPU_COPY_V4WB if MMU # can probably do better select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WBI if MMU help The ARM1022E is an implementation of the ARMv5TE architecture
@@ -254,6 +265,7 @@ config CPU_ARM1026 select CPU_COPY_V4WB if MMU # can probably do better select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WBI if MMU help The ARM1026EJ-S is an implementation of the ARMv5TEJ architecture
@@ -302,6 +314,7 @@ config CPU_XSCALE select CPU_CACHE_VIVT select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WBI if MMU # XScale Core Version 3
@@ -312,6 +325,7 @@ config CPU_XSC3 select CPU_CACHE_VIVT select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WBI if MMU select IO_36
@@ -324,6 +338,7 @@ config CPU_MOHAWK select CPU_COPY_V4WB if MMU select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_V4WBI if MMU # Feroceon
@@ -335,6 +350,7 @@ config CPU_FEROCEON select CPU_COPY_FEROCEON if MMU select CPU_CP15_MMU select CPU_PABRT_LEGACY + select CPU_THUMB_CAPABLE select CPU_TLB_FEROCEON if MMU config CPU_FEROCEON_OLD_ID
@@ -367,6 +383,7 @@ config CPU_V6 select CPU_CP15_MMU select CPU_HAS_ASID if MMU select CPU_PABRT_V6 + select CPU_THUMB_CAPABLE select CPU_TLB_V6 if MMU # ARMv6k
@@ -381,6 +398,7 @@ config CPU_V6K select CPU_CP15_MMU select CPU_HAS_ASID if MMU select CPU_PABRT_V6 + select CPU_THUMB_CAPABLE select CPU_TLB_V6 if MMU # ARMv7
@@ -396,6 +414,7 @@ config CPU_V7 select CPU_CP15_MPU if !MMU select CPU_HAS_ASID if MMU select CPU_PABRT_V7 + select CPU_THUMB_CAPABLE select CPU_TLB_V7 if MMU # ARMv7M
@@ -410,11 +429,17 @@ config CPU_V7M config CPU_THUMBONLY bool + select CPU_THUMB_CAPABLE # There are no CPUs available with MMU that don't implement an ARM ISA: depends on !MMU help Select this if your CPU doesn't support the 32 bit ARM instructions. +config CPU_THUMB_CAPABLE + bool + help + Selected this if your CPU can support Thumb mode + # Figure out what processor architecture version we should be using. # This defines the compiler instruction set which depends on the machine type. config CPU_32v3
@@ -655,11 +680,7 @@ config ARCH_DMA_ADDR_T_64BIT config ARM_THUMB bool "Support Thumb user binaries" if !CPU_THUMBONLY - depends on CPU_ARM720T || CPU_ARM740T || CPU_ARM920T || CPU_ARM922T || \ - CPU_ARM925T || CPU_ARM926T || CPU_ARM940T || CPU_ARM946E || \ - CPU_ARM1020 || CPU_ARM1020E || CPU_ARM1022 || CPU_ARM1026 || \ - CPU_XSCALE || CPU_XSC3 || CPU_MOHAWK || CPU_V6 || CPU_V6K || \ - CPU_V7 || CPU_FEROCEON || CPU_V7M + depends on CPU_THUMB_CAPABLE default y help Say Y if you want to include kernel support for running user space
Signature · 1 line
2.7.4
PATCH 1/4 ARM: add CPU_THUMB_CAPABLE to indicate possible Thumb support
Quoted 4 lines · Russell King
arch/arm/mm/Kconfig +0
-0@@ -410,11 +429,17 @@ config CPU_V7M config CPU_THUMBONLY bool
arch/arm/mm/Kconfig config CPU_V7M · line 441
Quoted 10 lines
arch/arm/mm/Kconfig +5
-0+ select CPU_THUMB_CAPABLE # There are no CPUs available with MMU that don't implement an ARM ISA: depends on !MMU help Select this if your CPU doesn't support the 32 bit ARM instructions. +config CPU_THUMB_CAPABLE + bool + help + Selected this if your CPU can support Thumb mode
s/Selected/Select/ ?Also add the full stop like the previous help text?
Quoted 5 lines
arch/arm/mm/Kconfig +1
-0+ # Figure out what processor architecture version we should be using. # This defines the compiler instruction set which depends on the machine type. config CPU_32v3
arch/arm/mm/Kconfig config ARCH_DMA_ADDR_T_64BIT · line 683
Quoted 9 lines
arch/arm/mm/Kconfig +1
-5@@ -655,11 +680,7 @@ config ARCH_DMA_ADDR_T_64BIT config ARM_THUMB bool "Support Thumb user binaries" if !CPU_THUMBONLY - depends on CPU_ARM720T || CPU_ARM740T || CPU_ARM920T || CPU_ARM922T || \ - CPU_ARM925T || CPU_ARM926T || CPU_ARM940T || CPU_ARM946E || \ - CPU_ARM1020 || CPU_ARM1020E || CPU_ARM1022 || CPU_ARM1026 || \ - CPU_XSCALE || CPU_XSC3 || CPU_MOHAWK || CPU_V6 || CPU_V6K || \ - CPU_V7 || CPU_FEROCEON || CPU_V7M + depends on CPU_THUMB_CAPABLE
Nice!
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH 2/4 ARM: kuser: split out kuser code
In reply to Russell King - ARM Linux--- arch/arm/kernel/Makefile | 2 + arch/arm/kernel/entry-armv.S | 198 ------------------------------------------- arch/arm/kernel/kuser.S | 197 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 199 insertions(+), 198 deletions(-) create mode 100644 arch/arm/kernel/kuser.S
arch/arm/kernel/Makefile +2 -0
@@ -30,6 +30,8 @@ else obj-y += entry-armv.o endif +obj-$(CONFIG_KUSER_HELPERS) += kuser.o + obj-$(CONFIG_CPU_IDLE) += cpuidle.o obj-$(CONFIG_ISA_DMA_API) += dma.o obj-$(CONFIG_FIQ) += fiq.o
arch/arm/kernel/entry-armv.S +0 -198
204 lines not on this page · raw message
arch/arm/kernel/kuser.S new file +197 -0
197 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH 3/4 ARM: kuser: simplify kuser_cmpxchg* preprocessor conditionals
In reply to Russell King - ARM LinuxSimplify the kuser_cmpxchg* preprocessor conditionals by arranging the ARMv6+ code first. This gives us one level of preprocessor conditional nesting, rather than two levels.
--- arch/arm/kernel/kuser.S | 42 ++++++++++++++++++------------------------ 1 file changed, 18 insertions(+), 24 deletions(-)
arch/arm/kernel/kuser.S +18 -24
@@ -2,6 +2,10 @@ #include <asm/assembler.h> +#if defined(CONFIG_SMP) && !defined(CONFIG_CPU_32v6K) +#error "incoherent kernel configuration" +#endif + __INIT /*
@@ -63,9 +67,7 @@ __kuser_cmpxchg64: @ 0xffff0f60 ldmfd sp!, {r4, r5, r6, r7} usr_ret lr -#elif !defined(CONFIG_SMP) - -#ifdef CONFIG_MMU +#elif defined(CONFIG_MMU) /* * The only thing that can break atomicity in this cmpxchg64
@@ -109,10 +111,6 @@ __kuser_cmpxchg64: @ 0xffff0f60 usr_ret lr #endif -#else -#error "incoherent kernel configuration" -#endif - kuser_pad __kuser_cmpxchg64, 64 __kuser_memory_barrier: @ 0xffff0fa0
@@ -123,9 +121,20 @@ __kuser_memory_barrier: @ 0xffff0fa0 __kuser_cmpxchg: @ 0xffff0fc0 -#if __LINUX_ARM_ARCH__ < 6 +#if __LINUX_ARM_ARCH__ >= 6 -#ifdef CONFIG_MMU + smp_dmb arm +1: ldrex r3, [r2] + subs r3, r3, r0 + strexeq r3, r1, [r2] + teqeq r3, #1 + beq 1b + rsbs r0, r3, #0 + /* beware -- each __kuser slot must be 8 instructions max */ + ALT_SMP(b __kuser_memory_barrier) + ALT_UP(usr_ret lr) + +#elif defined(CONFIG_MMU) /* * The only thing that can break atomicity in this cmpxchg
@@ -164,21 +173,6 @@ __kuser_cmpxchg: @ 0xffff0fc0 usr_ret lr #endif -#else - - smp_dmb arm -1: ldrex r3, [r2] - subs r3, r3, r0 - strexeq r3, r1, [r2] - teqeq r3, #1 - beq 1b - rsbs r0, r3, #0 - /* beware -- each __kuser slot must be 8 instructions max */ - ALT_SMP(b __kuser_memory_barrier) - ALT_UP(usr_ret lr) - -#endif - kuser_pad __kuser_cmpxchg, 32 __kuser_get_tls: @ 0xffff0fe0
Signature · 1 line
2.7.4
PATCH 4/4 ARM: kuser: split the kuser support for Thumb-capable and ARM-only
In reply to Russell King - ARM LinuxWe need to build the kuser code differently for Thumb-capable CPUs vs ARM-capable CPUs. However, we do not want to require two different kernel configurations to support this - we want to choose between the two variants at run time.
In order to achieve this, we build the kuser.S code differently, and choose to copy the appropriate version into the kuser page.
However, there is a twist - there are fixups within this code that are needed for supporting some of the operations, and these end up duplicated, which leads to a linker error. Thankfully, the fixups result in identical code, so we choose to drop one set of these.
--- arch/arm/kernel/Makefile | 10 +++++++++- arch/arm/kernel/kuser-t.S | 13 ++++++++++++ arch/arm/kernel/kuser-v4.S | 11 +++++++++++ arch/arm/kernel/kuser.S | 49 +++++++++++++++++++++++++--------------------- arch/arm/kernel/traps.c | 37 ++++++++++++++++++++++++++++++---- 5 files changed, 93 insertions(+), 27 deletions(-) create mode 100644 arch/arm/kernel/kuser-t.S create mode 100644 arch/arm/kernel/kuser-v4.S
arch/arm/kernel/Makefile +9 -1
@@ -30,7 +30,15 @@ else obj-y += entry-armv.o endif -obj-$(CONFIG_KUSER_HELPERS) += kuser.o +# Build non-Thumb variant for non-Thumb CPUs +kuser-$(CONFIG_CPU_32v3) += kuser-v4.o +kuser-$(CONFIG_CPU_32v4) += kuser-v4.o + +# Always build kuser-t for an arch that includes Thumb support +AFLAGS_kuser-t.o := -march=armv7-a +kuser-$(CONFIG_CPU_THUMB_CAPABLE) += kuser-t.o + +obj-$(CONFIG_KUSER_HELPERS) += $(kuser-y) obj-$(CONFIG_CPU_IDLE) += cpuidle.o obj-$(CONFIG_ISA_DMA_API) += dma.o
arch/arm/kernel/kuser-t.S new file +13 -0
@@ -0,0 +1,13 @@ +#include <asm/assembler.h> + +#if !(defined(CONFIG_CPU_32v3) || defined(CONFIG_CPU_32v4)) +#define GENERATE_FIXUPS +#endif + +#define SYM(x) x##_thumb + + .macro usr_ret, reg + bx \reg + .endm + +#include "kuser.S"
arch/arm/kernel/kuser-v4.S new file +11 -0
@@ -0,0 +1,11 @@ +#include <asm/assembler.h> + +#define GENERATE_FIXUPS + +#define SYM(x) x##_v4 + + .macro usr_ret, reg + mov pc, \reg + .endm + +#include "kuser.S"
arch/arm/kernel/kuser.S +27 -22
101 lines not on this page · raw message
arch/arm/kernel/traps.c +33 -4
@@ -792,12 +792,41 @@ void __init trap_init(void) }#ifdef CONFIG_KUSER_HELPERS -static void __init kuser_init (void *vectors) +#ifdef CONFIG_CPU_THUMB_CAPABLE +static void __init kuser_thumb_init (void *vectors) +{ +extern char __kuser_helper_start_thumb[], __kuser_helper_end_thumb[]; +int kuser_sz = __kuser_helper_end_thumb - __kuser_helper_start_thumb; + +memcpy (vectors +0x1000 - kuser_sz, __kuser_helper_start_thumb, + kuser_sz); +} +#else +static void __init kuser_thumb_init (void *vectors) +{ +} +#endif + +#if defined(CONFIG_CPU_32v3) || defined(CONFIG_CPU_32v4) +static void __init kuser_v4_init (void *vectors) { -extern char __kuser_helper_start[], __kuser_helper_end[]; -int kuser_sz = __kuser_helper_end - __kuser_helper_start; +extern char __kuser_helper_start_v4[], __kuser_helper_end_v4[]; +int kuser_sz = __kuser_helper_end_v4 - __kuser_helper_start_v4; -memcpy (vectors +0x1000 - kuser_sz, __kuser_helper_start, kuser_sz); +memcpy (vectors +0x1000 - kuser_sz, __kuser_helper_start_v4, kuser_sz); +} +#else +static void __init kuser_v4_init (void *vectors) +{ +} +#endif + +static void __init kuser_init (void *vectors) +{ +if (!(elf_hwcap &HWCAP_THUMB )) +kuser_v4_init (vectors); +else +kuser_thumb_init (vectors);/* * vectors + 0xfe0 = __kuser_get_tls
Signature · 1 line
2.7.4
PATCH 4/4 ARM: kuser: split the kuser support for Thumb-capable and ARM-only
On Thu, 9 Feb 2017, Russell King wrote:
[...]
Quoted 9 lines
arch/arm/kernel/kuser.S +9
-0+#ifdef GENERATE_FIXUPS +/* + * The .text section in this file is used for fixups of the various + * helpers. Do not place anything else in the .text section within + * this file. + */ + .globl kuser_cmpxchg64_fixup +kuser_cmpxchg64_fixup: +#endif
[...]
Quoted 8 lines
arch/arm/kernel/kuser.S +1
-2+#ifdef GENERATE_FIXUPS .text - .globl kuser_cmpxchg64_fixup -kuser_cmpxchg64_fixup: @ Called from kuser_cmpxchg_check macro. @ r4 = address of interrupted insn (must be preserved). @ sp = saved regs. r7 and r8 are clobbered.
arch/arm/kernel/kuser.S __kuser_cmpxchg64: @ 0xffff0f60 · line 102
Quoted 10 lines
arch/arm/kernel/kuser.S +2
-4@@ -98,11 +97,9 @@ __kuser_cmpxchg64: @ 0xffff0f60 subs r8, r4, r7 rsbcss r8, r8, #(2b - 1b) strcs r7, [sp, #S_PC] -#if __LINUX_ARM_ARCH__ < 6 - bcc kuser_cmpxchg32_fixup -#endif - ret lr + retcs lr .previous +#endif
This construct gave me pause for a while.
A few observations:
- The kuser_cmpxchg32_fixup symbol is no longer referenced, so it can be removed from the next fixup code block too.
- If __LINUX_ARM_ARCH__ >= 6 then the kuser_cmpxchg32 doesn't need any fixup and the above sequence will end in:
retcs lr
ret lr
Note a big deal though, and the increased code clarity is worth it.
- Given a single linear fixup block it might be more appropriate to rename kuser_cmpxchg64_fixup to kuser_fixup so not to imply it is only for cmpxchg64.
And you may add to the whole series:
Nicolas
cover kuser updates for ARM-only vs Thumb
In reply to Russell King - ARM LinuxThus wrote Russell King - ARM Linux (linux at armlinux.org.uk):
Quoted 9 lines
A while back, an issue was raised about the return instruction used in the kuser page when building an ARMv4 and later environment.
In order to fix this, I suggested building the kuser code for both variants and selecting the appropriate version at run time. This seemed to be a simple solution, but due to the fix-ups and need to build the appropriate version for the
Kconfigoptions selected, turned out to be not quite as trivial as I hoped.
Quoted 5 lines
Nevertheless, this patch series provides that solution.
As a side effect of this, the first patch is one which should be merged irrespective of the remainder as it provides a useful cleanup to the large number of dependencies for the
ARM_THUMBoption.
Since this was merged (commit bf4b17749f8632696134c8705f294ce02c85c1fa), linux-next would stop working on my imx258 (ARM926T).
Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000004
It turned out that CONFIG_ARM_THUMB was not set in my kernel config, enabling it fixed the problem.
Does this mean the kuser helpers now use thumb instructions and a user space binary crashes when it uses the helpers and thumb binaries are not supported?
If CONFIG_CPU_THUMB_CAPABLE requires CONFIG_ARM_THUMB, should we make this more explicit in the code?
Thanks,
Martin
Russell King - ARM Linux
maintainercover kuser updates for ARM-only vs Thumb
Quoted 11 lines · Martin Kaiser
Thus wrote Russell King - ARM Linux (linux at armlinux.org.uk):
Quoted 8 lines
A while back, an issue was raised about the return instruction used in the kuser page when building an ARMv4 and later environment.
In order to fix this, I suggested building the kuser code for both variants and selecting the appropriate version at run time. This seemed to be a simple solution, but due to the fix-ups and need to build the appropriate version for the
Kconfigoptions selected, turned out to be not quite as trivial as I hoped.
Quoted 8 lines
Quoted 5 lines
Nevertheless, this patch series provides that solution.
As a side effect of this, the first patch is one which should be merged irrespective of the remainder as it provides a useful cleanup to the large number of dependencies for the
ARM_THUMBoption.Since this was merged (commit
bf4b17749f8632696134c8705f294ce02c85c1fa), linux-next would stop working on my imx258 (ARM926T).
Thanks for the report.
Quoted 11 lines
Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000004It turned out that
CONFIG_ARM_THUMBwas not set in my kernel config, enabling it fixed the problem.Does this mean the kuser helpers now use thumb instructions and a user space binary crashes when it uses the helpers and thumb binaries are not supported?
If
CONFIG_CPU_THUMB_CAPABLErequiresCONFIG_ARM_THUMB, should we make this more explicit in the code?
No, that makes no sense:
"CPU_THUMB_CAPABLE" => "is this CPU capable of thumb support?" "ARM_THUMB" => "this CPU supports thumb and we want userspace support"
Clearly, it does _not_ make sense to turn that upside down, especially given that ARM_THUMB depends on CPU_THUMB_CAPABLE being set.
The problem here is that this test:
if (!(elf_hwcap & HWCAP_THUMB))
kuser_v4_init(vectors);
else
kuser_thumb_init(vectors);is insufficient - if CONFIG_ARM_THUMB is disabled, we clear the thumb bit in elf_hwcap, so we try to use the v4 code. The v4 code is only built into the kernel if we're supporting an ARMv3 or ARMv4 CPU, so we end up with no kuser helpers at all.
This is not the point in the cycle to start messing around trying to fix this, so I'll have to drop it for 4.11, and we'll have another go for 4.12.
Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.