Skip to contentSkip to conversation

spi: bcm-qspi: Remove unnecessary platform_set_drvdata()

PATCH In review Wei Yongjun 2 participants 2 messages Feb 9, 2017 – Feb 16, 2017 1 message not in the archive

Subsystems (2)
SPI Broadcom SPI driver
lore
Share & tools
lore

Wei Yongjun

author
#0 lore raw

PATCH 1/1 spi: bcm-qspi: Remove unnecessary platform_set_drvdata()

From: Wei Yongjun <[email protected]>

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Wei Yongjun <[email protected]>
---
 drivers/spi/spi-bcm-qspi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-bcm-qspi.c +0 -1
index 227096a..b3745d4 100644
@@ -1399,7 +1399,6 @@ int bcm_qspi_remove(struct platform_device *pdev)
 {
 	struct bcm_qspi *qspi = platform_get_drvdata(pdev);
 
-	platform_set_drvdata(pdev, NULL);
 	bcm_qspi_hw_uninit(qspi);
 	clk_disable_unprepare(qspi->clk);
 	kfree(qspi->dev_ids);

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20170209153221.2698-1-weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

Applied "spi: bcm-qspi: Remove unnecessary platform_set_drvdata()" to the spi tree

The patch

spi: bcm-qspi: Remove unnecessary platform_set_drvdata()

has been applied to the spi tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 973f7dd575891d0e67469861b47f43175553f30a Mon Sep 17 00:00:00 2001

From: Wei Yongjun <[email protected]>
Date: Thu, 9 Feb 2017 15:32:21 +0000
Subject: [PATCH] spi: bcm-qspi: Remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Wei Yongjun <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 drivers/spi/spi-bcm-qspi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-bcm-qspi.c +0 -1
index 99b3057531a5..958fb4ee972d 100644
@@ -1408,7 +1408,6 @@ int bcm_qspi_remove(struct platform_device *pdev)
 {
 	struct bcm_qspi *qspi = platform_get_drvdata(pdev);
 
-	platform_set_drvdata(pdev, NULL);
 	bcm_qspi_hw_uninit(qspi);
 	clk_disable_unprepare(qspi->clk);
 	kfree(qspi->dev_ids);
Signature · 6 lines
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html