ASoC: jack - check status of GPIO-based pins on resume

PATCH In review Dmitry Torokhov 2 participants 6 messages Mar 21, 2017 – Mar 24, 2017

Subsystems (2)

Sound ASoC

lore

Share & tools

lore

Dmitry Torokhov

author

2017-03-21 23:50 UTC #0 lore raw

PATCH 1/1 ASoC: jack - check status of GPIO-based pins on resume

From: Dmitry Torokhov <[email protected]>

For GPIO-backed pins that are not configured as wakeup sources, we may miss change in their state that happens while system is suspended. Let's use PM notifier to refresh their state upon resume.

Signed-off-by Dmitry Torokhov <[email protected]>

---
 include/sound/soc.h  |  1 +
 sound/soc/soc-jack.c | 30 ++++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+)

include/sound/soc.h +1 -0

index b86168a21d56..c0b8bf463940 100644
@@ -722,6 +722,7 @@ struct snd_soc_jack_gpio {
 	/* private: */
 	struct snd_soc_jack *jack;
 	struct delayed_work work;
+	struct notifier_block pm_notifier;
 	struct gpio_desc *desc;
 
 	void *data;

sound/soc/soc-jack.c +30 -0

index fbaa1bb41102..d90af94ec1be 100644
@@ -19,6 +19,7 @@
 #include <linux/workqueue.h>
 #include <linux/delay.h>
 #include <linux/export.h>
+#include <linux/suspend.h>
 #include <trace/events/asoc.h>
 
 /**

@@ -293,6 +294,27 @@ static void gpio_work(struct work_struct *work)
 	snd_soc_jack_gpio_detect(gpio);
 }
 
+static int snd_soc_jack_pm_notifier(struct notifier_block *nb,
+				    unsigned long action, void *data)
+{
+	struct snd_soc_jack_gpio *gpio =
+			container_of(nb, struct snd_soc_jack_gpio, pm_notifier);
+
+	switch (action) {
+	case PM_POST_SUSPEND:
+	case PM_POST_HIBERNATION:
+	case PM_POST_RESTORE:
+		/*
+		 * Use workqueue so we do not have to care about running
+		 * concurrently with work triggered by the interrupt handler.
+		 */
+		queue_delayed_work(system_power_efficient_wq, &gpio->work, 0);
+		break;
+	}
+
+	return NOTIFY_DONE;
+}
+
 /**
  * snd_soc_jack_add_gpios - Associate GPIO pins with an ASoC jack
  *

@@ -369,6 +391,13 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count,
 					i, ret);
 		}
 
+		/*
+		 * Register PM notifier so we do not miss state transitions
+		 * happening while system is asleep.
+		 */
+		gpios[i].pm_notifier.notifier_call = snd_soc_jack_pm_notifier;
+		register_pm_notifier(&gpios[i].pm_notifier);
+
 		/* Expose GPIO value over sysfs for diagnostic purposes */
 		gpiod_export(gpios[i].desc, false);

@@ -428,6 +457,7 @@ void snd_soc_jack_free_gpios(struct snd_soc_jack *jack, int count,
 
 	for (i = 0; i < count; i++) {
 		gpiod_unexport(gpios[i].desc);
+		unregister_pm_notifier(&gpios[i].pm_notifier);
 		free_irq(gpiod_to_irq(gpios[i].desc), &gpios[i]);
 		cancel_delayed_work_sync(&gpios[i].work);
 		gpiod_put(gpios[i].desc);

Signature · 5 lines

2.12.1.500.gab5fba24ee-goog


-- 
Dmitry

Mark Brown

maintainer

2017-03-24 18:52 UTC #1 lore raw

Quoted 8 lines · Dmitry Torokhov

From: Dmitry Torokhov <[email protected]>
For GPIO-backed pins that are not configured as wakeup sources, we may miss change in their state that happens while system is suspended. Let's use PM notifier to refresh their state upon resume.
Signed-off-by Dmitry Torokhov <[email protected]>
---

Please send patches from the mail account corresponding to the signoff, not doing that makes the patch look like it's missing a signoff (as it's got the From line so more than one signoff is expected but there's only one) which slows down review.

Dmitry Torokhov

author

2017-03-24 19:22 UTC #2 lore raw

Quoted 7 lines · Mark Brown

Quoted 6 lines · Dmitry Torokhov
From: Dmitry Torokhov <[email protected]>
For GPIO-backed pins that are not configured as wakeup sources, we may miss change in their state that happens while system is suspended. Let's use PM notifier to refresh their state upon resume.

Quoted 7 lines

Quoted 2 lines
Signed-off-by Dmitry Torokhov <[email protected]>
---
Please send patches from the mail account corresponding to the signoff, not doing that makes the patch look like it's missing a signoff (as it's got the From line so more than one signoff is expected but there's only one) which slows down review.

Resent from @chromium.

Signature · 1 line

Dmitry

Mark Brown

maintainer

2017-03-24 19:26 UTC #3 lore raw

Quoted 8 lines · Dmitry Torokhov

Quoted 4 lines · Mark Brown
Please send patches from the mail account corresponding to the signoff, not doing that makes the patch look like it's missing a signoff (as it's got the From line so more than one signoff is expected but there's only one) which slows down review.
Resent from @chromium.

Sorry, that was a note for future submissions - I'd already applied when I sent.

Dmitry Torokhov

author

2017-03-24 19:28 UTC #4 lore raw

Quoted 8 lines · Mark Brown

Quoted 6 lines · Dmitry Torokhov
Quoted 4 lines · Mark Brown
Please send patches from the mail account corresponding to the signoff, not doing that makes the patch look like it's missing a signoff (as it's got the From line so more than one signoff is expected but there's only one) which slows down review.

Quoted 4 lines

Quoted 1 line
Resent from @chromium.
Sorry, that was a note for future submissions - I'd already applied when I sent.

Ah, sorry, well, it was a test for my updated script then ;)

Signature · 1 line

Dmitry

Mark Brown

maintainer

2017-03-24 19:16 UTC #5 lore raw

Applied "ASoC: jack - check status of GPIO-based pins on resume" to the asoc tree

In reply to Dmitry Torokhov

The patch

ASoC: jack - check status of GPIO-based pins on resume

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 73548dd316adec41172c31d63a0c35a97bf9577f Mon Sep 17 00:00:00 2001

From: Dmitry Torokhov <[email protected]>
Date: Tue, 21 Mar 2017 16:50:43 -0700
Subject: [PATCH] ASoC: jack - check status of GPIO-based pins on resume

For GPIO-backed pins that are not configured as wakeup sources, we may miss change in their state that happens while system is suspended. Let's use PM notifier to refresh their state upon resume.

Signed-off-by Dmitry Torokhov <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 include/sound/soc.h  |  1 +
 sound/soc/soc-jack.c | 30 ++++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+)

include/sound/soc.h +1 -0

index 2b502f6cc6d0..1d20abec4995 100644
@@ -722,6 +722,7 @@ struct snd_soc_jack_gpio {
 	/* private: */
 	struct snd_soc_jack *jack;
 	struct delayed_work work;
+	struct notifier_block pm_notifier;
 	struct gpio_desc *desc;
 
 	void *data;

sound/soc/soc-jack.c +30 -0

index fbaa1bb41102..a03dcbb94baf 100644
@@ -19,6 +19,7 @@
 #include <linux/workqueue.h>
 #include <linux/delay.h>
 #include <linux/export.h>
+#include <linux/suspend.h>
 #include <trace/events/asoc.h>
 
 /**

@@ -293,6 +294,27 @@ static void gpio_work(struct work_struct *work)
 	snd_soc_jack_gpio_detect(gpio);
 }
 
+static int snd_soc_jack_pm_notifier(struct notifier_block *nb,
+				    unsigned long action, void *data)
+{
+	struct snd_soc_jack_gpio *gpio =
+			container_of(nb, struct snd_soc_jack_gpio, pm_notifier);
+
+	switch (action) {
+	case PM_POST_SUSPEND:
+	case PM_POST_HIBERNATION:
+	case PM_POST_RESTORE:
+		/*
+		 * Use workqueue so we do not have to care about running
+		 * concurrently with work triggered by the interrupt handler.
+		 */
+		queue_delayed_work(system_power_efficient_wq, &gpio->work, 0);
+		break;
+	}
+
+	return NOTIFY_DONE;
+}
+
 /**
  * snd_soc_jack_add_gpios - Associate GPIO pins with an ASoC jack
  *

@@ -369,6 +391,13 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count,
 					i, ret);
 		}
 
+		/*
+		 * Register PM notifier so we do not miss state transitions
+		 * happening while system is asleep.
+		 */
+		gpios[i].pm_notifier.notifier_call = snd_soc_jack_pm_notifier;
+		register_pm_notifier(&gpios[i].pm_notifier);
+
 		/* Expose GPIO value over sysfs for diagnostic purposes */
 		gpiod_export(gpios[i].desc, false);

@@ -428,6 +457,7 @@ void snd_soc_jack_free_gpios(struct snd_soc_jack *jack, int count,
 
 	for (i = 0; i < count; i++) {
 		gpiod_unexport(gpios[i].desc);
+		unregister_pm_notifier(&gpios[i].pm_notifier);
 		free_irq(gpiod_to_irq(gpios[i].desc), &gpios[i]);
 		cancel_delayed_work_sync(&gpios[i].work);
 		gpiod_put(gpios[i].desc);

Signature · 1 line

2.11.0