Skip to contentSkip to conversation

ASoC: rt5665: make local symbol rt5665_i2c_driver static

PATCH In review Wei Yongjun 2 participants 3 messages May 16, 2017 – May 17, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: rt5665: make local symbol rt5665_i2c_driver static

From: Wei Yongjun <[email protected]>

Fixes the following sparse warnings:

sound/soc/codecs/rt5665.c:4928:19: warning:
symbol 'rt5665_i2c_driver' was not declared. Should it be static?

---
 sound/soc/codecs/rt5665.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/rt5665.c +1 -1
index 26bf157..bb440bd 100644
@@ -4925,7 +4925,7 @@ static struct acpi_device_id rt5665_acpi_match[] = {
 MODULE_DEVICE_TABLE(acpi, rt5665_acpi_match);
 #endif
 
-struct i2c_driver rt5665_i2c_driver = {
+static struct i2c_driver rt5665_i2c_driver = {
 	.driver = {
 		.name = "rt5665",
 		.of_match_table = of_match_ptr(rt5665_of_match),
maintainer
#1 lore raw
Quoted 1 line · Wei Yongjun

From: Wei Yongjun <[email protected]>

Please try to send your mails from the address you're using for the signoffs - if you send from another address it looks like you're forwarding on someone else's patch without adding your signoff which sets off alarm bells.

maintainer
#2 lore raw

Applied "ASoC: rt5665: make local symbol rt5665_i2c_driver static" to the asoc tree

In reply to Wei Yongjun

The patch

ASoC: rt5665: make local symbol rt5665_i2c_driver static

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 18fe7869764c0b86e8ce6539bbb6e528f1d9928f Mon Sep 17 00:00:00 2001

From: Wei Yongjun <[email protected]>
Date: Tue, 16 May 2017 16:24:56 +0000
Subject: [PATCH] ASoC: rt5665: make local symbol rt5665_i2c_driver static

Fixes the following sparse warnings:

sound/soc/codecs/rt5665.c:4928:19: warning:
symbol 'rt5665_i2c_driver' was not declared. Should it be static?

---
 sound/soc/codecs/rt5665.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/rt5665.c +1 -1
index c0f36d85ee4d..7420010fd8e9 100644
@@ -4929,7 +4929,7 @@ static struct acpi_device_id rt5665_acpi_match[] = {
 MODULE_DEVICE_TABLE(acpi, rt5665_acpi_match);
 #endif
 
-struct i2c_driver rt5665_i2c_driver = {
+static struct i2c_driver rt5665_i2c_driver = {
 	.driver = {
 		.name = "rt5665",
 		.of_match_table = of_match_ptr(rt5665_of_match),
Signature · 1 line
2.11.0