Skip to contentSkip to conversation

ASoC: wm_adsp: Fix type warning in sprintf

PATCH In review Richard Fitzgerald 2 participants 4 messages May 24, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ASoC: wm_adsp: Fix type warning in sprintf

The shift member of struct soc_mixer_control is unsigned int.

---
 sound/soc/codecs/wm_adsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/wm_adsp.c +1 -1
index 20695b6..a7dc760 100644
@@ -2654,7 +2654,7 @@ int wm_adsp2_preloader_put(struct snd_kcontrol *kcontrol,
 		(struct soc_mixer_control *)kcontrol->private_value;
 	char preload[32];
 
-	snprintf(preload, ARRAY_SIZE(preload), "DSP%d Preload", mc->shift);
+	snprintf(preload, ARRAY_SIZE(preload), "DSP%u Preload", mc->shift);
 
 	dsp->preloaded = ucontrol->value.integer.value[0];
 
Signature · 1 line
1.9.1
#1 lore raw

PATCH 2/2 ASoC: wm_adsp: Remove unused member of struct wm_coeff_ctl_ops

The xinfo member of struct wm_coeff_ctl_ops is never used.

---
 sound/soc/codecs/wm_adsp.c | 2 --
 1 file changed, 2 deletions(-)
sound/soc/codecs/wm_adsp.c +0 -2
index a7dc760..5aff83b 100644
@@ -482,8 +482,6 @@ struct wm_coeff_ctl_ops {
 		    struct snd_ctl_elem_value *ucontrol);
 	int (*xput)(struct snd_kcontrol *kcontrol,
 		    struct snd_ctl_elem_value *ucontrol);
-	int (*xinfo)(struct snd_kcontrol *kcontrol,
-		     struct snd_ctl_elem_info *uinfo);
 };
 
 struct wm_coeff_ctl {
Signature · 1 line
1.9.1
maintainer
#2 lore raw

Applied "ASoC: wm_adsp: Remove unused member of struct wm_coeff_ctl_ops" to the asoc tree

The patch

ASoC: wm_adsp: Remove unused member of struct wm_coeff_ctl_ops

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From f6db09488f58372909728cea5a7c063ebf78f386 Mon Sep 17 00:00:00 2001

From: Richard Fitzgerald <[email protected]>
Date: Wed, 24 May 2017 10:59:39 +0100
Subject: [PATCH] ASoC: wm_adsp: Remove unused member of struct
wm_coeff_ctl_ops

The xinfo member of struct wm_coeff_ctl_ops is never used.

---
 sound/soc/codecs/wm_adsp.c | 2 --
 1 file changed, 2 deletions(-)
sound/soc/codecs/wm_adsp.c +0 -2
index a7dc76030ee4..5aff83be375c 100644
@@ -482,8 +482,6 @@ struct wm_coeff_ctl_ops {
 		    struct snd_ctl_elem_value *ucontrol);
 	int (*xput)(struct snd_kcontrol *kcontrol,
 		    struct snd_ctl_elem_value *ucontrol);
-	int (*xinfo)(struct snd_kcontrol *kcontrol,
-		     struct snd_ctl_elem_info *uinfo);
 };
 
 struct wm_coeff_ctl {
Signature · 1 line
2.11.0
maintainer
#3 lore raw

Applied "ASoC: wm_adsp: Fix type warning in sprintf" to the asoc tree

In reply to Richard Fitzgerald

The patch

ASoC: wm_adsp: Fix type warning in sprintf

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 6298117a5c5c5c5217b59640d6df7fe078fa7d88 Mon Sep 17 00:00:00 2001

From: Richard Fitzgerald <[email protected]>
Date: Wed, 24 May 2017 10:59:38 +0100
Subject: [PATCH] ASoC: wm_adsp: Fix type warning in sprintf

The shift member of struct soc_mixer_control is unsigned int.

---
 sound/soc/codecs/wm_adsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/wm_adsp.c +1 -1
index 20695b691aff..a7dc76030ee4 100644
@@ -2654,7 +2654,7 @@ int wm_adsp2_preloader_put(struct snd_kcontrol *kcontrol,
 		(struct soc_mixer_control *)kcontrol->private_value;
 	char preload[32];
 
-	snprintf(preload, ARRAY_SIZE(preload), "DSP%d Preload", mc->shift);
+	snprintf(preload, ARRAY_SIZE(preload), "DSP%u Preload", mc->shift);
 
 	dsp->preloaded = ucontrol->value.integer.value[0];
 
Signature · 1 line
2.11.0