Skip to contentSkip to conversation

ASoC: ak4613: Fix out of bounds array access for ak4613_iface

PATCH In review Axel Lin 3 participants 3 messages Jun 9, 2017

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ASoC: ak4613: Fix out of bounds array access for ak4613_iface

---
 sound/soc/codecs/ak4613.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/ak4613.c +1 -1
index e3121ca..c87ec49 100644
@@ -347,7 +347,7 @@ static int ak4613_dai_hw_params(struct snd_pcm_substream *substream,
 		if (ak4613_dai_fmt_matching(priv->iface, is_play, fmt, width))
 			iface = priv->iface;
 	} else {
-		for (i = ARRAY_SIZE(ak4613_iface); i >= 0; i--) {
+		for (i = ARRAY_SIZE(ak4613_iface) - 1; i >= 0; i--) {
 			if (!ak4613_dai_fmt_matching(ak4613_iface + i,
 						     is_play,
 						     fmt, width))
Signature · 1 line
2.9.3
Acked-by on v1 1/1
#1 lore raw

Hi

Quoted 2 lines

---

Wow !! indeed

Quoted 19 lines
 sound/soc/codecs/ak4613.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/ak4613.c +1 -1
index e3121ca..c87ec49 100644
@@ -347,7 +347,7 @@ static int ak4613_dai_hw_params(struct snd_pcm_substream *substream,
 		if (ak4613_dai_fmt_matching(priv->iface, is_play, fmt, width))
 			iface = priv->iface;
 	} else {
-		for (i = ARRAY_SIZE(ak4613_iface); i >= 0; i--) {
+		for (i = ARRAY_SIZE(ak4613_iface) - 1; i >= 0; i--) {
 			if (!ak4613_dai_fmt_matching(ak4613_iface + i,
 						     is_play,
 						     fmt, width))
Signature · 1 line
2.9.3
maintainer
#2 lore raw

Applied "ASoC: ak4613: Fix out of bounds array access for ak4613_iface" to the asoc tree

In reply to Axel Lin

The patch

ASoC: ak4613: Fix out of bounds array access for ak4613_iface

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From b5f2a487f524e6eeeec38651e7b58760ebfd843e Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Fri, 9 Jun 2017 15:01:21 +0800
Subject: [PATCH] ASoC: ak4613: Fix out of bounds array access for ak4613_iface

---
 sound/soc/codecs/ak4613.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/ak4613.c +1 -1
index b2dfddead227..987918628d5b 100644
@@ -345,7 +345,7 @@ static int ak4613_dai_hw_params(struct snd_pcm_substream *substream,
 		if (ak4613_dai_fmt_matching(priv->iface, is_play, fmt, width))
 			iface = priv->iface;
 	} else {
-		for (i = ARRAY_SIZE(ak4613_iface); i >= 0; i--) {
+		for (i = ARRAY_SIZE(ak4613_iface) - 1; i >= 0; i--) {
 			if (!ak4613_dai_fmt_matching(ak4613_iface + i,
 						     is_play,
 						     fmt, width))
Signature · 1 line
2.11.0