Skip to contentSkip to conversation

ASoC: wm_adsp: Fix some signedness errors in register access

PATCH In review Richard Fitzgerald 2 participants 2 messages Feb 16, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: wm_adsp: Fix some signedness errors in register access

base and sysclk_reg should be unsigned int, as that is what regmap takes as a register address.

sysclk_mask is used to mask unsigned register values so should be unsigned.

sysclk_shift is a shift value so is not allowed to be negative.

---
 sound/soc/codecs/wm_adsp.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
sound/soc/codecs/wm_adsp.h +4 -4
index 41cc11c19b83..d4042c95315e 100644
@@ -64,10 +64,10 @@ struct wm_adsp {
 	struct regmap *regmap;
 	struct snd_soc_codec *codec;
 
-	int base;
-	int sysclk_reg;
-	int sysclk_mask;
-	int sysclk_shift;
+	unsigned int base;
+	unsigned int sysclk_reg;
+	unsigned int sysclk_mask;
+	unsigned int sysclk_shift;
 
 	struct list_head alg_regions;
 
Signature · 1 line
2.11.0
maintainer
#1 lore raw

Applied "ASoC: wm_adsp: Fix some signedness errors in register access" to the asoc tree

The patch

ASoC: wm_adsp: Fix some signedness errors in register access

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From e21a5acfab2f13eeffe50d5d5f87c099540a3bf3 Mon Sep 17 00:00:00 2001

From: Richard Fitzgerald <[email protected]>
Date: Fri, 16 Feb 2018 14:36:10 +0000
Subject: [PATCH] ASoC: wm_adsp: Fix some signedness errors in register access

base and sysclk_reg should be unsigned int, as that is what regmap takes as a register address.

sysclk_mask is used to mask unsigned register values so should be unsigned.

sysclk_shift is a shift value so is not allowed to be negative.

---
 sound/soc/codecs/wm_adsp.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
sound/soc/codecs/wm_adsp.h +4 -4
index 41cc11c19b83..d4042c95315e 100644
@@ -64,10 +64,10 @@ struct wm_adsp {
 	struct regmap *regmap;
 	struct snd_soc_codec *codec;
 
-	int base;
-	int sysclk_reg;
-	int sysclk_mask;
-	int sysclk_shift;
+	unsigned int base;
+	unsigned int sysclk_reg;
+	unsigned int sysclk_mask;
+	unsigned int sysclk_shift;
 
 	struct list_head alg_regions;
 
Signature · 1 line
2.16.1