ASoC: soc-generic-dmaengine-pcm: Add a DMA debugfs_prefix entry
Subsystems (3)
PATCH 1/1 ASoC: soc-generic-dmaengine-pcm: Add a DMA debugfs_prefix entry
From: Fabio Estevam <[email protected]>
After the conversion from platform to component the following warnings are seen:
fsl-ssi-dai 2028000.ssi: ASoC: Failed to create component debugfs directory
fsl-spdif-dai 2004000.spdif: ASoC: Failed to createcomponent debugfs directory
As explained by Mark Brown:
"It's a legit warning - we shouldn't really be creating two components for the same device. However this is a bit of a corner case as it's the dmaengine platform driver which is kind of a virtual device, it's not really the device that we use with DMA that's being represented but rather the link between that and the DMA controller."
Disambiguate the DMA component name by adding a "dma" debugfs_prefix entry.
--- sound/soc/soc-generic-dmaengine-pcm.c | 3 +++ 1 file changed, 3 insertions(+)
sound/soc/soc-generic-dmaengine-pcm.c +3 -0
@@ -442,6 +442,9 @@ int snd_dmaengine_pcm_register(struct device *dev,if (!pcm)return -ENOMEM ; +#ifdef CONFIG_DEBUG_FS + pcm->component.debugfs_prefix ="dma" ; +#endif pcm->config = config; pcm->flags = flags;
Signature · 1 line
2.7.4
Mark Brown
maintainerApplied "ASoC: soc-generic-dmaengine-pcm: Add a DMA debugfs_prefix entry" to the asoc tree
The patch
ASoC: soc-generic-dmaengine-pcm: Add a DMA debugfs_prefix entry
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
f0b3bdbd5c63c3f69f3b6a869355c676d22fd348Mon Sep 17 00:00:00 2001
From: Fabio Estevam <[email protected]>
Date: Wed, 21 Feb 2018 14:57:33 -0300
Subject: [PATCH] ASoC: soc-generic-dmaengine-pcm: Add a DMA debugfs_prefix
entry
After the conversion from platform to component the following warnings are seen:
fsl-ssi-dai 2028000.ssi: ASoC: Failed to create component debugfs directory
fsl-spdif-dai 2004000.spdif: ASoC: Failed to create component debugfs directory
As explained by Mark Brown:
"It's a legit warning - we shouldn't really be creating two components for the same device. However this is a bit of a corner case as it's the dmaengine platform driver which is kind of a virtual device, it's not really the device that we use with DMA that's being represented but rather the link between that and the DMA controller."
Disambiguate the DMA component name by adding a "dma" debugfs_prefix entry.
--- sound/soc/soc-generic-dmaengine-pcm.c | 3 +++ 1 file changed, 3 insertions(+)
sound/soc/soc-generic-dmaengine-pcm.c +3 -0
@@ -431,6 +431,9 @@ int snd_dmaengine_pcm_register(struct device *dev,if (!pcm)return -ENOMEM ; +#ifdef CONFIG_DEBUG_FS + pcm->component.debugfs_prefix ="dma" ; +#endif pcm->config = config; pcm->flags = flags;
Signature · 1 line
2.16.1