Skip to contentSkip to conversation

arm: rockchip: make_fit_atf: remove unneeded imports

PATCH New Peter Robinson 3 participants 9 messages Apr 25, 2018 – Apr 26, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm: rockchip: make_fit_atf: remove unneeded imports

From: Patrick Uiterwijk <[email protected]>

These imports are entirely unused in the entire script.

---
 arch/arm/mach-rockchip/make_fit_atf.py | 2 --
 1 file changed, 2 deletions(-)
arch/arm/mach-rockchip/make_fit_atf.py +0 -2
index 7c6dd57678..9a404d1d32 100755
@@ -13,8 +13,6 @@ import getopt
 
 # pip install pyelftools
 from elftools.elf.elffile import ELFFile
-from elftools.elf.sections import SymbolTableSection
-from elftools.elf.segments import Segment, InterpSegment, NoteSegment
 
 ELF_SEG_P_TYPE='p_type'
 ELF_SEG_P_PADDR='p_paddr'
Signature · 1 line
2.17.0
#1 lore raw

PATCH 2/2 config: evb-rk3399: enable make uboot.itb

Similar to firefly 3399 enable the ability to create a FIT image with combined arm-trusted-firmware.

---
 configs/evb-rk3399_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/evb-rk3399_defconfig +3 -0
index b36f232dcb..67ba0ce015 100644
@@ -11,6 +11,7 @@ CONFIG_DEFAULT_DEVICE_TREE="rk3399-evb"
 CONFIG_DEBUG_UART=y
 CONFIG_FIT=y
 CONFIG_SPL_LOAD_FIT=y
+CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-rockchip/make_fit_atf.py"
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_SPL_STACK_R=y
@@ -25,6 +26,8 @@ CONFIG_CMD_TIME=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
 CONFIG_SPL_OF_PLATDATA=y
+CONFIG_SPL_ATF=y
+CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_REGMAP=y
Signature · 1 line
2.17.0
#4 lore raw

PATCH 2/2 config: evb-rk3399: enable make uboot.itb

In reply to Peter Robinson

Hi Peter,

Quoted 4 lines · Peter Robinson

Similar to firefly 3399 enable the ability to create a FIT image with combined arm-trusted-firmware.

Looks good to me.

Thanks,
- Kever

Quoted 25 lines
---
 configs/evb-rk3399_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/evb-rk3399_defconfig +3 -0
index b36f232dcb..67ba0ce015 100644
@@ -11,6 +11,7 @@ CONFIG_DEFAULT_DEVICE_TREE="rk3399-evb"
 CONFIG_DEBUG_UART=y
 CONFIG_FIT=y
 CONFIG_SPL_LOAD_FIT=y
+CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-rockchip/make_fit_atf.py"
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_SPL_STACK_R=y
@@ -25,6 +26,8 @@ CONFIG_CMD_TIME=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
 CONFIG_SPL_OF_PLATDATA=y
+CONFIG_SPL_ATF=y
+CONFIG_SPL_ATF_NO_PLATFORM_PARAM=y
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_REGMAP=y
#5 lore raw

PATCH 2/2 config: evb-rk3399: enable make uboot.itb

In reply to Peter Robinson
Quoted 11 lines

Similar to firefly 3399 enable the ability to create a FIT image with combined arm-trusted-firmware.

---
 configs/evb-rk3399_defconfig | 3 +++
 1 file changed, 3 insertions(+)

Applied to u-boot-rockchip, thanks!

#8 lore raw

PATCH 1/2 arm: rockchip: make_fit_atf: remove unneeded imports

In reply to Peter Robinson
Quoted 4 lines

From: Patrick Uiterwijk <[email protected]>

These imports are entirely unused in the entire script.

Quoted 8 lines
---
 arch/arm/mach-rockchip/make_fit_atf.py | 2 --
 1 file changed, 2 deletions(-)

Applied to u-boot-rockchip, thanks!