rockchip: enable SYS_NS16550 for all SoCs by default

PATCH New Kever Yang 3 participants 12 messages Apr 19, 2018 – May 8, 2018

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm Rockchip

lore

Share & tools

lore

Kever Yang

author

2018-04-19 03:37 UTC #0 lore raw

PATCH v2 1/2 rockchip: enable SYS_NS16550 for all SoCs by default

All rockchip SoCs can use ns16550 driver, enable it for all and set SYS_NS16550_MEM32 for all SoCs.

Version-changes: 2
- use imply instead of select

Signed-off-by Kever Yang <[email protected]>

---

Changes in v2: None

 arch/arm/Kconfig                  | 1 +
 arch/arm/mach-rockchip/Kconfig    | 1 -
 include/configs/rk3036_common.h   | 3 ---
 include/configs/rk3128_common.h   | 2 --
 include/configs/rk3188_common.h   | 2 --
 include/configs/rk322x_common.h   | 1 -
 include/configs/rk3288_common.h   | 2 --
 include/configs/rk3328_common.h   | 2 --
 include/configs/rk3368_common.h   | 2 --
 include/configs/rk3399_common.h   | 2 --
 include/configs/rockchip-common.h | 2 ++
 include/configs/rv1108_common.h   | 3 ---
 12 files changed, 3 insertions(+), 20 deletions(-)

arch/arm/Kconfig +1 -0

index 068ea1e..a90f870 100644
@@ -1199,6 +1199,7 @@ config ARCH_ROCKCHIP
 	imply TPL_SYSRESET
 	imply ADC
 	imply SARADC_ROCKCHIP
+	imply SYS_NS16550
 
 config TARGET_THUNDERX_88XX
 	bool "Support ThunderX 88xx"

arch/arm/mach-rockchip/Kconfig +0 -1

index 55d3d5c..15b3ab5 100644
@@ -103,7 +103,6 @@ config ROCKCHIP_RK3368
 	imply SPL_SERIAL_SUPPORT
 	imply TPL_SERIAL_SUPPORT
 	select DEBUG_UART_BOARD_INIT
-	select SYS_NS16550
 	help
 	  The Rockchip RK3368 is a ARM-based SoC with a octa-core (organised
 	  into a big and little cluster with 4 cores each) Cortex-A53 including

include/configs/rk3036_common.h +0 -3

index 7d83f81..effc74f 100644
@@ -18,9 +18,6 @@
 #define CONFIG_SYS_ARCH_TIMER
 #define CONFIG_SYS_HZ_CLOCK		24000000
 
-#define CONFIG_SYS_NS16550
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_INIT_SP_ADDR		0x60100000
 #define CONFIG_SYS_LOAD_ADDR		0x60800800
 #define CONFIG_SPL_STACK		0x10081fff

include/configs/rk3128_common.h +0 -2

index e7e137b..5643873 100644
@@ -19,8 +19,6 @@
 #define CONFIG_SYS_ARCH_TIMER
 #define CONFIG_SYS_HZ_CLOCK		24000000
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_INIT_SP_ADDR		0x60100000
 #define CONFIG_SYS_LOAD_ADDR		0x60800800

include/configs/rk3188_common.h +0 -2

index e07facd..4f51f40 100644
@@ -17,8 +17,6 @@
 #define CONFIG_SYS_MALLOC_LEN		(32 << 20)
 #define CONFIG_SYS_CBSIZE		1024
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #ifdef CONFIG_SPL_ROCKCHIP_BACK_TO_BROM
 /* Bootrom will load u-boot binary to 0x60000000 once return from SPL */
 #endif

include/configs/rk322x_common.h +0 -1

index 8f8a1ef..2549d41 100644
@@ -18,7 +18,6 @@
 #define CONFIG_SYS_ARCH_TIMER
 #define CONFIG_SYS_HZ_CLOCK		24000000
 
-#define CONFIG_SYS_NS16550_MEM32
 #define CONFIG_SYS_INIT_SP_ADDR		0x60100000
 #define CONFIG_SYS_LOAD_ADDR		0x60800800
 #define CONFIG_SPL_STACK		0x10088000

include/configs/rk3288_common.h +0 -2

index 98cc9be..92ad203 100644
@@ -19,8 +19,6 @@
 #define CONFIG_SYS_ARCH_TIMER
 #define CONFIG_SYS_HZ_CLOCK		24000000
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #ifdef CONFIG_SPL_ROCKCHIP_BACK_TO_BROM
 /* Bootrom will load u-boot binary to 0x0 once return from SPL */
 #endif

include/configs/rk3328_common.h +0 -2

index 517d058..b6c3cc0 100644
@@ -13,8 +13,6 @@
 #define CONFIG_SYS_CBSIZE		1024
 #define CONFIG_SKIP_LOWLEVEL_INIT
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_INIT_SP_ADDR		0x00300000
 #define CONFIG_SYS_LOAD_ADDR		0x00800800

include/configs/rk3368_common.h +0 -2

index 10f643f..f85b76f 100644
@@ -24,8 +24,6 @@
 
 #define COUNTER_FREQUENCY               24000000
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_INIT_SP_ADDR		0x00300000
 #define CONFIG_SYS_LOAD_ADDR		0x00280000

include/configs/rk3399_common.h +0 -2

index f0e550d..f43dc7e 100644
@@ -19,8 +19,6 @@
 
 #define COUNTER_FREQUENCY               24000000
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_INIT_SP_ADDR		0x00300000
 #define CONFIG_SYS_LOAD_ADDR		0x00800800
 #define CONFIG_SPL_STACK		0xff8effff

include/configs/rockchip-common.h +2 -0

index 26d41b5..72333e2 100644
@@ -8,6 +8,8 @@
 #define _ROCKCHIP_COMMON_H_
 #include <linux/sizes.h>
 
+#define CONFIG_SYS_NS16550_MEM32
+
 #ifndef CONFIG_SPL_BUILD
 
 /* First try to boot from SD (index 0), then eMMC (index 1) */

include/configs/rv1108_common.h +0 -3

index 349c53c..cd204e9 100644
@@ -18,9 +18,6 @@
 #define CONFIG_SYS_TIMER_BASE		0x10350020
 #define CONFIG_SYS_TIMER_COUNTER	(CONFIG_SYS_TIMER_BASE + 8)
 
-#define CONFIG_SYS_NS16550
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_SDRAM_BASE		0x60000000
 #define CONFIG_NR_DRAM_BANKS		1
 #define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_TEXT_BASE + 0x100000)

Signature · 1 line

1.9.1

Kever Yang

author

2018-04-19 03:37 UTC #1 lore raw

PATCH v2 2/2 rockchip: defconfig: remove CONFIG_SYS_NS16550

We have enable NS16550 in Kconfig, do not need enable at defconfig

Signed-off-by Kever Yang <[email protected]>

---

Changes in v2:
- check and add some missing board

 configs/chromebit_mickey_defconfig  | 1 -
 configs/chromebook_jerry_defconfig  | 1 -
 configs/chromebook_minnie_defconfig | 1 -
 configs/evb-rk3128_defconfig        | 1 -
 configs/evb-rk3229_defconfig        | 1 -
 configs/evb-rk3288_defconfig        | 1 -
 configs/evb-rk3328_defconfig        | 1 -
 configs/evb-rk3399_defconfig        | 1 -
 configs/fennec-rk3288_defconfig     | 1 -
 configs/firefly-rk3288_defconfig    | 1 -
 configs/firefly-rk3399_defconfig    | 1 -
 configs/miqi-rk3288_defconfig       | 1 -
 configs/phycore-rk3288_defconfig    | 1 -
 configs/popmetal-rk3288_defconfig   | 1 -
 configs/puma-rk3399_defconfig       | 1 -
 configs/rock2_defconfig             | 1 -
 configs/rock_defconfig              | 1 -
 configs/tinker-rk3288_defconfig     | 1 -
 configs/vyasa-rk3288_defconfig      | 1 -
 19 files changed, 19 deletions(-)

configs/chromebit_mickey_defconfig +0 -1

index fbe0e5d..35b339d 100644
@@ -70,7 +70,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_ROCKCHIP_SERIAL=y
 CONFIG_ROCKCHIP_SPI=y
 CONFIG_SYSRESET=y

configs/chromebook_jerry_defconfig +0 -1

index bced22e..0f734df 100644
@@ -71,7 +71,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_ROCKCHIP_SERIAL=y
 CONFIG_ROCKCHIP_SPI=y
 CONFIG_SYSRESET=y

configs/chromebook_minnie_defconfig +0 -1

index 913b32e..3eec404 100644
@@ -70,7 +70,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_ROCKCHIP_SERIAL=y
 CONFIG_ROCKCHIP_SPI=y
 CONFIG_SYSRESET=y

configs/evb-rk3128_defconfig +0 -1

index e7414c9..367c654 100644
@@ -33,7 +33,6 @@ CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_BASE=0x20068000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y

configs/evb-rk3229_defconfig +0 -1

index 5ec9788..96afda8 100644
@@ -45,7 +45,6 @@ CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_BASE=0x11030000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y

configs/evb-rk3288_defconfig +0 -1

index 7ba7178..b8189fd 100644
@@ -64,7 +64,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y

configs/evb-rk3328_defconfig +0 -1

index 266d699..3fb1cfc 100644
@@ -43,7 +43,6 @@ CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_BASE=0xFF130000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y

configs/evb-rk3399_defconfig +0 -1

index b5ae073..7e3e97d 100644
@@ -55,7 +55,6 @@ CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_BASE=0xFF1A0000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y

configs/fennec-rk3288_defconfig +0 -1

index 11112ca..0b6e8b9 100644
@@ -63,7 +63,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y

configs/firefly-rk3288_defconfig +0 -1

index adb6b5d..dc856b0 100644
@@ -67,7 +67,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y

configs/firefly-rk3399_defconfig +0 -1

index 03d0324..ed30652 100644
@@ -57,7 +57,6 @@ CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_BASE=0xFF1A0000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y

configs/miqi-rk3288_defconfig +0 -1

index a2e58a7..c62158a 100644
@@ -63,7 +63,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y

configs/phycore-rk3288_defconfig +0 -1

index bd698f5..8e4e04d 100644
@@ -67,7 +67,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y

configs/popmetal-rk3288_defconfig +0 -1

index 0d85349..2beee6e 100644
@@ -63,7 +63,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y

configs/puma-rk3399_defconfig +0 -1

index 32aa72c..5d69b0e 100644
@@ -81,7 +81,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xFF180000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_ROCKCHIP_SPI=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y

configs/rock2_defconfig +0 -1

index 744a84a..4e220fe 100644
@@ -64,7 +64,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y

configs/rock_defconfig +0 -1

index e46cc29..2e27768 100644
@@ -49,7 +49,6 @@ CONFIG_RAM=y
 CONFIG_DEBUG_UART_BASE=0x20064000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_ROCKCHIP_USB2_PHY=y

configs/tinker-rk3288_defconfig +0 -1

index f8ff916..1c28817 100644
@@ -66,7 +66,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y

configs/vyasa-rk3288_defconfig +0 -1

index 24a955a..90f1028 100644
@@ -63,7 +63,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y

Signature · 1 line

1.9.1

Philipp Tomsich

2018-04-25 10:29 UTC #2 lore raw

PATCH v2 2/2 rockchip: defconfig: remove CONFIG_SYS_NS16550

Quoted 20 lines

We have enable NS16550 in Kconfig, do not need enable at defconfig

Signed-off-by Kever Yang <[email protected]>

---

Changes in v2:
- check and add some missing board

 configs/chromebit_mickey_defconfig  | 1 -
 configs/chromebook_jerry_defconfig  | 1 -
 configs/chromebook_minnie_defconfig | 1 -
 configs/evb-rk3128_defconfig        | 1 -
 configs/evb-rk3229_defconfig        | 1 -
 configs/evb-rk3288_defconfig        | 1 -
 configs/evb-rk3328_defconfig        | 1 -
 configs/evb-rk3399_defconfig        | 1 -
 configs/fennec-rk3288_defconfig     | 1 -
 configs/firefly-rk3288_defconfig    | 1 -
 configs/firefly-rk3399_defconfig    | 1 -
 configs/miqi-rk3288_defconfig       | 1 -

Quoted 9 lines

 configs/phycore-rk3288_defconfig    | 1 -
 configs/popmetal-rk3288_defconfig   | 1 -
 configs/puma-rk3399_defconfig       | 1 -
 configs/rock2_defconfig             | 1 -
 configs/rock_defconfig              | 1 -
 configs/tinker-rk3288_defconfig     | 1 -
 configs/vyasa-rk3288_defconfig      | 1 -
 19 files changed, 19 deletions(-)

Acked-by Philipp Tomsich <[email protected]>

Philipp Tomsich

2018-04-25 10:29 UTC #3 lore raw

PATCH v2 2/2 rockchip: defconfig: remove CONFIG_SYS_NS16550

In reply to Kever Yang

Quoted 20 lines

We have enable NS16550 in Kconfig, do not need enable at defconfig

Signed-off-by Kever Yang <[email protected]>

---

Changes in v2:
- check and add some missing board

 configs/chromebit_mickey_defconfig  | 1 -
 configs/chromebook_jerry_defconfig  | 1 -
 configs/chromebook_minnie_defconfig | 1 -
 configs/evb-rk3128_defconfig        | 1 -
 configs/evb-rk3229_defconfig        | 1 -
 configs/evb-rk3288_defconfig        | 1 -
 configs/evb-rk3328_defconfig        | 1 -
 configs/evb-rk3399_defconfig        | 1 -
 configs/fennec-rk3288_defconfig     | 1 -
 configs/firefly-rk3288_defconfig    | 1 -
 configs/firefly-rk3399_defconfig    | 1 -
 configs/miqi-rk3288_defconfig       | 1 -

Quoted 9 lines

 configs/phycore-rk3288_defconfig    | 1 -
 configs/popmetal-rk3288_defconfig   | 1 -
 configs/puma-rk3399_defconfig       | 1 -
 configs/rock2_defconfig             | 1 -
 configs/rock_defconfig              | 1 -
 configs/tinker-rk3288_defconfig     | 1 -
 configs/vyasa-rk3288_defconfig      | 1 -
 19 files changed, 19 deletions(-)

Reviewed-by Philipp Tomsich <[email protected]>

Philipp Tomsich

2018-04-25 10:29 UTC #5 lore raw

PATCH v2 1/2 rockchip: enable SYS_NS16550 for all SoCs by default

In reply to Kever Yang

Quoted 11 lines

All rockchip SoCs can use ns16550 driver, enable it for all and set SYS_NS16550_MEM32 for all SoCs.
Version-changes: 2
- use imply instead of select
Signed-off-by Kever Yang <[email protected]>
---
Changes in v2: None

Quoted 14 lines

 arch/arm/Kconfig                  | 1 +
 arch/arm/mach-rockchip/Kconfig    | 1 -
 include/configs/rk3036_common.h   | 3 ---
 include/configs/rk3128_common.h   | 2 --
 include/configs/rk3188_common.h   | 2 --
 include/configs/rk322x_common.h   | 1 -
 include/configs/rk3288_common.h   | 2 --
 include/configs/rk3328_common.h   | 2 --
 include/configs/rk3368_common.h   | 2 --
 include/configs/rk3399_common.h   | 2 --
 include/configs/rockchip-common.h | 2 ++
 include/configs/rv1108_common.h   | 3 ---
 12 files changed, 3 insertions(+), 20 deletions(-)

Acked-by Philipp Tomsich <[email protected]>

Philipp Tomsich

2018-04-25 10:29 UTC #6 lore raw

PATCH v2 1/2 rockchip: enable SYS_NS16550 for all SoCs by default

In reply to Kever Yang

Quoted 11 lines

All rockchip SoCs can use ns16550 driver, enable it for all and set SYS_NS16550_MEM32 for all SoCs.
Version-changes: 2
- use imply instead of select
Signed-off-by Kever Yang <[email protected]>
---
Changes in v2: None

Quoted 14 lines

 arch/arm/Kconfig                  | 1 +
 arch/arm/mach-rockchip/Kconfig    | 1 -
 include/configs/rk3036_common.h   | 3 ---
 include/configs/rk3128_common.h   | 2 --
 include/configs/rk3188_common.h   | 2 --
 include/configs/rk322x_common.h   | 1 -
 include/configs/rk3288_common.h   | 2 --
 include/configs/rk3328_common.h   | 2 --
 include/configs/rk3368_common.h   | 2 --
 include/configs/rk3399_common.h   | 2 --
 include/configs/rockchip-common.h | 2 ++
 include/configs/rv1108_common.h   | 3 ---
 12 files changed, 3 insertions(+), 20 deletions(-)

Reviewed-by Philipp Tomsich <[email protected]>

Jonathan Gray

2018-05-08 07:30 UTC #8 lore raw

PATCH v2 1/2 rockchip: enable SYS_NS16550 for all SoCs by default

Quoted 28 lines · Philipp Tomsich

Quoted 13 lines
All rockchip SoCs can use ns16550 driver, enable it for all and set SYS_NS16550_MEM32 for all SoCs.
Version-changes: 2
- use imply instead of select
Signed-off-by Kever Yang <[email protected]>
Acked-by Philipp Tomsich <[email protected]>
Reviewed-by Philipp Tomsich <[email protected]>
---
Changes in v2: None
Quoted 14 lines
 arch/arm/Kconfig                  | 1 +
 arch/arm/mach-rockchip/Kconfig    | 1 -
 include/configs/rk3036_common.h   | 3 ---
 include/configs/rk3128_common.h   | 2 --
 include/configs/rk3188_common.h   | 2 --
 include/configs/rk322x_common.h   | 1 -
 include/configs/rk3288_common.h   | 2 --
 include/configs/rk3328_common.h   | 2 --
 include/configs/rk3368_common.h   | 2 --
 include/configs/rk3399_common.h   | 2 --
 include/configs/rockchip-common.h | 2 ++
 include/configs/rv1108_common.h   | 3 ---
 12 files changed, 3 insertions(+), 20 deletions(-)

Quoted 1 line

Applied to u-boot-rockchip, thanks!

With U-Boot 2018.05 there is no serial console output on tinker-rk3288, a regression from 2018.03. I have bisected it to this commit.

Reverting c3c0331db1fb7b1f4ff41e144fc04353b37c785c and eb3d707e99fcd2213d5f8f0fe4ae53ad416b377e restores serial output with 2018.05.

c3c0331db1fb7b1f4ff41e144fc04353b37c785c is the first bad commit commit c3c0331db1fb7b1f4ff41e144fc04353b37c785c

Author: Kever Yang <[email protected]>
Date:   Thu Apr 19 11:37:09 2018 +0800

rockchip: enable SYS_NS16550 for all SoCs by default

All rockchip SoCs can use ns16550 driver, enable it for all and set SYS_NS16550_MEM32 for all SoCs.

Version-changes: 2
- use imply instead of select

Signed-off-by Kever Yang <[email protected]>

Acked-by Philipp Tomsich <[email protected]>

Reviewed-by Philipp Tomsich <[email protected]>

:040000 040000 f7cc8b28ae8179fdc15896bbb55279f205a54008 d07108bbf467735f31f31c083a9068dff71da247 M arch
:040000 040000 d0a0422fc55afdcb5abb82f24b9a0af8de3d39a6 33c7fcf6f28f44a8c416f95313e7a30b2f73f8f0 M include

Dr. Philipp Tomsich

2018-05-08 07:41 UTC #9 lore raw

PATCH v2 1/2 rockchip: enable SYS_NS16550 for all SoCs by default

Kever,

Could you analyse and provide (against master) a patch for this? Weâ€™ll need to catch any left-overs from your changes at the start of the cycle before we try to merge any of the more invasive changes you have in-flight.

Thanks,
Philipp.

Quoted 59 lines · Jonathan Gray

Quoted 28 lines · Philipp Tomsich
Quoted 13 lines
All rockchip SoCs can use ns16550 driver, enable it for all and set SYS_NS16550_MEM32 for all SoCs.
Version-changes: 2
- use imply instead of select
Signed-off-by Kever Yang <[email protected]>
Acked-by Philipp Tomsich <[email protected]>
Reviewed-by Philipp Tomsich <[email protected]>
---
Changes in v2: None
Quoted 14 lines
arch/arm/Kconfig                  | 1 +
arch/arm/mach-rockchip/Kconfig    | 1 -
include/configs/rk3036_common.h   | 3 ---
include/configs/rk3128_common.h   | 2 --
include/configs/rk3188_common.h   | 2 --
include/configs/rk322x_common.h   | 1 -
include/configs/rk3288_common.h   | 2 --
include/configs/rk3328_common.h   | 2 --
include/configs/rk3368_common.h   | 2 --
include/configs/rk3399_common.h   | 2 --
include/configs/rockchip-common.h | 2 ++
include/configs/rv1108_common.h   | 3 ---
12 files changed, 3 insertions(+), 20 deletions(-)
Quoted 1 line
Applied to u-boot-rockchip, thanks!
With U-Boot 2018.05 there is no serial console output on tinker-rk3288, a regression from 2018.03. I have bisected it to this commit.
Reverting c3c0331db1fb7b1f4ff41e144fc04353b37c785c and eb3d707e99fcd2213d5f8f0fe4ae53ad416b377e restores serial output with 2018.05.
c3c0331db1fb7b1f4ff41e144fc04353b37c785c is the first bad commit commit c3c0331db1fb7b1f4ff41e144fc04353b37c785c
Author: Kever Yang <kever.yang at rock-chips.com <mailto:[email protected]>>
Date:   Thu Apr 19 11:37:09 2018 +0800
rockchip: enable SYS_NS16550 for all SoCs by default
All rockchip SoCs can use ns16550 driver, enable it for all and set SYS_NS16550_MEM32 for all SoCs.
Version-changes: 2
- use imply instead of select
Signed-off-by Kever Yang <kever.yang at rock-chips.com <mailto:[email protected]>>
Acked-by Philipp Tomsich <philipp.tomsich at theobroma-systems.com <mailto:[email protected]>>
Reviewed-by Philipp Tomsich <philipp.tomsich at theobroma-systems.com <mailto:[email protected]>>
:040000 040000 f7cc8b28ae8179fdc15896bbb55279f205a54008 d07108bbf467735f31f31c083a9068dff71da247 M arch
:040000 040000 d0a0422fc55afdcb5abb82f24b9a0af8de3d39a6 33c7fcf6f28f44a8c416f95313e7a30b2f73f8f0 M include

Jonathan Gray

2018-05-08 10:31 UTC #10 lore raw

PATCH v2 1/2 rockchip: enable SYS_NS16550 for all SoCs by default

Quoted 8 lines · Dr. Philipp Tomsich

Kever,
Could you analyse and provide (against master) a patch for this? We???ll need to catch any left-overs from your changes at the start of the cycle before we try to merge any of the more invasive changes you have in-flight.
Thanks,
Philipp.

The patch in https://patchwork.ozlabs.org/patch/900546/ had a change in include/configs/rockchip-common.h which was not included in the commit that made it into to tree as c3c0331db1fb7b1f4ff41e144fc04353b37c785c.

After adding that back it works.

include/configs/rockchip-common.h +2 -0

index dee82ca99d..68e1105a4b 100644
@@ -7,6 +7,8 @@
 #define _ROCKCHIP_COMMON_H_
 #include <linux/sizes.h>
 
+#define CONFIG_SYS_NS16550_MEM32
+
 #ifndef CONFIG_SPL_BUILD
 
 /* First try to boot from SD (index 0), then eMMC (index 1) */

Dr. Philipp Tomsich

2018-05-08 10:47 UTC #11 lore raw

PATCH v2 1/2 rockchip: enable SYS_NS16550 for all SoCs by default

Good catch. I had a few merge-conflicts when merging that series. That one might have gotten lost.

Quoted 31 lines · Jonathan Gray

Quoted 8 lines · Dr. Philipp Tomsich
Kever,
Could you analyse and provide (against master) a patch for this? We???ll need to catch any left-overs from your changes at the start of the cycle before we try to merge any of the more invasive changes you have in-flight.
Thanks,
Philipp.
The patch in https://patchwork.ozlabs.org/patch/900546/ had a change in include/configs/rockchip-common.h which was not included in the commit that made it into to tree as c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
After adding that back it works.
include/configs/rockchip-common.h +2 -0
index dee82ca99d..68e1105a4b 100644
@@ -7,6 +7,8 @@
 #define _ROCKCHIP_COMMON_H_
 #include <linux/sizes.h>
 
+#define CONFIG_SYS_NS16550_MEM32
+
 #ifndef CONFIG_SPL_BUILD
 
 /* First try to boot from SD (index 0), then eMMC (index 1) */