ASoC: pxa: code refactoring
Subsystems (4)
Daniel Mack
maintainercover ASoC: pxa: code refactoring
This is a series to clean up the code base in the ASoC/PXA area a bit. It folds some implementations, removes some files and brings pcm ops to the CPU DAIS, so they can be used on DT platforms without platform drivers.
They are a preparation for some more patches that will follow on top.
Daniel Mack (7):
ASoC: fold pxa2xx-pcm into its only user, pxa2xx-ac97
ASoC: pxa: clean up function names in pxa2xx-lib
ASoC: pxa: move some functions to pxa2xx-lib
ASoC: pxa2xx-pcm-lib: fix indenting
ASoC: pxa: provide PCM ops for ssp, i2s and ac97 components
ASoC: pxa: remove bindings from pxa2xx-pcm
ASoC: pxa: make SND_PXA2XX_SOC_I2S selectable
.../bindings/sound/mrvl,pxa2xx-pcm.txt | 15 -- include/sound/pxa2xx-lib.h | 13 +- sound/arm/Kconfig | 5 - sound/arm/Makefile | 3 - sound/arm/pxa2xx-ac97.c | 114 ++++++++++------ sound/arm/pxa2xx-pcm-lib.c | 69 ++++++++-- sound/arm/pxa2xx-pcm.c | 129 ------------------ sound/arm/pxa2xx-pcm.h | 27 ---- sound/soc/pxa/Kconfig | 2 +- sound/soc/pxa/pxa-ssp.c | 4 +- sound/soc/pxa/pxa2xx-ac97.c | 3 + sound/soc/pxa/pxa2xx-i2s.c | 3 + sound/soc/pxa/pxa2xx-pcm.c | 73 ---------- 13 files changed, 148 insertions(+), 312 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/mrvl,pxa2xx-pcm.txt delete mode 100644 sound/arm/pxa2xx-pcm.c delete mode 100644 sound/arm/pxa2xx-pcm.h
Signature · 1 line
2.17.1
Daniel Mack
maintainerPATCH 1/7 ASoC: fold pxa2xx-pcm into its only user, pxa2xx-ac97
Now that the PXA SSP bits are ported over to generic DMA, the pxa2xx-pcm code only has a single user left. This patch folds the remaining bits into its only user and removes the unnecessary glue layer along with its header file.
The include dependency to linux/dma/pxa-dma.h is also gone now.
--- sound/arm/Kconfig | 5 -- sound/arm/Makefile | 3 - sound/arm/pxa2xx-ac97.c | 114 +++++++++++++++++++++----------- sound/arm/pxa2xx-pcm-lib.c | 2 - sound/arm/pxa2xx-pcm.c | 129 ------------------------------------- sound/arm/pxa2xx-pcm.h | 27 -------- sound/soc/pxa/pxa-ssp.c | 1 - sound/soc/pxa/pxa2xx-pcm.c | 2 - 8 files changed, 76 insertions(+), 207 deletions(-) delete mode 100644 sound/arm/pxa2xx-pcm.c delete mode 100644 sound/arm/pxa2xx-pcm.h
sound/arm/Kconfig +0 -5
@@ -17,14 +17,9 @@ config SND_ARMAACI select SND_PCM select SND_AC97_CODEC -config SND_PXA2XX_PCM - tristate - select SND_PCM - config SND_PXA2XX_AC97 tristate "AC97 driver for the Intel PXA2xx chip" depends on ARCH_PXA - select SND_PXA2XX_PCM select SND_AC97_CODEC select SND_PXA2XX_LIB select SND_PXA2XX_LIB_AC97
sound/arm/Makefile +0 -3
@@ -6,9 +6,6 @@ obj-$(CONFIG_SND_ARMAACI) += snd-aaci.o snd-aaci-objs := aaci.o -obj-$(CONFIG_SND_PXA2XX_PCM) += snd-pxa2xx-pcm.o -snd-pxa2xx-pcm-objs := pxa2xx-pcm.o - obj-$(CONFIG_SND_PXA2XX_LIB) += snd-pxa2xx-lib.o snd-pxa2xx-lib-y := pxa2xx-pcm-lib.o snd-pxa2xx-lib-$(CONFIG_SND_PXA2XX_LIB_AC97) += pxa2xx-ac97-lib.o
sound/arm/pxa2xx-ac97.c +76 -38
172 lines not on this page · raw message
sound/arm/pxa2xx-pcm-lib.c +0 -2
@@ -16,8 +16,6 @@#include <sound/pxa2xx-lib.h> #include <sound/dmaengine_pcm.h> -#include "pxa2xx-pcm.h" -static const struct snd_pcm_hardware pxa2xx_pcm_hardware = { .info =SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID |
sound/arm/pxa2xx-pcm.c deleted +0 -129
129 lines not on this page · raw message
sound/arm/pxa2xx-pcm.h deleted +0 -27
@@ -1,27 +0,0 @@ -/* -* linux/sound/arm/pxa2xx-pcm.h -- ALSA PCM interface for the Intel PXA2xx chip -* -* Author: Nicolas Pitre -* Created: Nov 30, 2004 -* Copyright: MontaVista Software, Inc. -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -*/ - -struct pxa2xx_runtime_data { -int dma_ch; -struct snd_dmaengine_dai_dma_data *params; -}; - -struct pxa2xx_pcm_client { -struct snd_dmaengine_dai_dma_data *playback_params; -struct snd_dmaengine_dai_dma_data *capture_params; -int (*startup)(struct snd_pcm_substream *); -void (*shutdown)(struct snd_pcm_substream *); -int (*prepare)(struct snd_pcm_substream *); -}; - -extern int pxa2xx_pcm_new (struct snd_card *,struct pxa2xx_pcm_client *,struct snd_pcm **); -
sound/soc/pxa/pxa-ssp.c +0 -1
@@ -34,7 +34,6 @@#include <sound/pxa2xx-lib.h> #include <sound/dmaengine_pcm.h> -#include "../../arm/pxa2xx-pcm.h" #include "pxa-ssp.h" /*
sound/soc/pxa/pxa2xx-pcm.c +0 -2
@@ -20,8 +20,6 @@#include <sound/pxa2xx-lib.h> #include <sound/dmaengine_pcm.h> -#include "../../arm/pxa2xx-pcm.h" -static int pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream,struct snd_pcm_hw_params *params) {
Signature · 1 line
2.17.1
Mark Brown
maintainerApplied "ASoC: fold pxa2xx-pcm into its only user, pxa2xx-ac97" to the asoc tree
The patch
ASoC: fold pxa2xx-pcm into its only user, pxa2xx-ac97
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
95acb005fef2aeaeb63c20de98aca0ed5bd0efa2Mon Sep 17 00:00:00 2001
From: Daniel Mack <[email protected]>
Date: Wed, 27 Jun 2018 21:33:53 +0200
Subject: [PATCH] ASoC: fold pxa2xx-pcm into its only user, pxa2xx-ac97
Now that the PXA SSP bits are ported over to generic DMA, the pxa2xx-pcm code only has a single user left. This patch folds the remaining bits into its only user and removes the unnecessary glue layer along with its header file.
The include dependency to linux/dma/pxa-dma.h is also gone now.
--- sound/arm/Kconfig | 5 -- sound/arm/Makefile | 3 - sound/arm/pxa2xx-ac97.c | 114 +++++++++++++++++++++----------- sound/arm/pxa2xx-pcm-lib.c | 2 - sound/arm/pxa2xx-pcm.c | 129 ------------------------------------- sound/arm/pxa2xx-pcm.h | 27 -------- sound/soc/pxa/pxa-ssp.c | 1 - sound/soc/pxa/pxa2xx-pcm.c | 2 - 8 files changed, 76 insertions(+), 207 deletions(-) delete mode 100644 sound/arm/pxa2xx-pcm.c delete mode 100644 sound/arm/pxa2xx-pcm.h
sound/arm/Kconfig +0 -5
@@ -17,14 +17,9 @@ config SND_ARMAACI select SND_PCM select SND_AC97_CODEC -config SND_PXA2XX_PCM - tristate - select SND_PCM - config SND_PXA2XX_AC97 tristate "AC97 driver for the Intel PXA2xx chip" depends on ARCH_PXA - select SND_PXA2XX_PCM select SND_AC97_CODEC select SND_PXA2XX_LIB select SND_PXA2XX_LIB_AC97
sound/arm/Makefile +0 -3
@@ -6,9 +6,6 @@ obj-$(CONFIG_SND_ARMAACI) += snd-aaci.o snd-aaci-objs := aaci.o -obj-$(CONFIG_SND_PXA2XX_PCM) += snd-pxa2xx-pcm.o -snd-pxa2xx-pcm-objs := pxa2xx-pcm.o - obj-$(CONFIG_SND_PXA2XX_LIB) += snd-pxa2xx-lib.o snd-pxa2xx-lib-y := pxa2xx-pcm-lib.o snd-pxa2xx-lib-$(CONFIG_SND_PXA2XX_LIB_AC97) += pxa2xx-ac97-lib.o
sound/arm/pxa2xx-ac97.c +76 -38
172 lines not on this page · raw message
sound/arm/pxa2xx-pcm-lib.c +0 -2
@@ -16,8 +16,6 @@#include <sound/pxa2xx-lib.h> #include <sound/dmaengine_pcm.h> -#include "pxa2xx-pcm.h" -static const struct snd_pcm_hardware pxa2xx_pcm_hardware = { .info =SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID |
sound/arm/pxa2xx-pcm.c deleted +0 -129
129 lines not on this page · raw message
sound/arm/pxa2xx-pcm.h deleted +0 -27
@@ -1,27 +0,0 @@ -/* -* linux/sound/arm/pxa2xx-pcm.h -- ALSA PCM interface for the Intel PXA2xx chip -* -* Author: Nicolas Pitre -* Created: Nov 30, 2004 -* Copyright: MontaVista Software, Inc. -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -*/ - -struct pxa2xx_runtime_data { -int dma_ch; -struct snd_dmaengine_dai_dma_data *params; -}; - -struct pxa2xx_pcm_client { -struct snd_dmaengine_dai_dma_data *playback_params; -struct snd_dmaengine_dai_dma_data *capture_params; -int (*startup)(struct snd_pcm_substream *); -void (*shutdown)(struct snd_pcm_substream *); -int (*prepare)(struct snd_pcm_substream *); -}; - -extern int pxa2xx_pcm_new (struct snd_card *,struct pxa2xx_pcm_client *,struct snd_pcm **); -
sound/soc/pxa/pxa-ssp.c +0 -1
@@ -34,7 +34,6 @@#include <sound/pxa2xx-lib.h> #include <sound/dmaengine_pcm.h> -#include "../../arm/pxa2xx-pcm.h" #include "pxa-ssp.h" /*
sound/soc/pxa/pxa2xx-pcm.c +0 -2
@@ -20,8 +20,6 @@#include <sound/pxa2xx-lib.h> #include <sound/dmaengine_pcm.h> -#include "../../arm/pxa2xx-pcm.h" -static int pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream,struct snd_pcm_hw_params *params) {
Signature · 1 line
2.18.0.rc2
Daniel Mack
maintainerPATCH 2/7 ASoC: pxa: clean up function names in pxa2xx-lib
In reply to Daniel MackClean up the namespace a bit and drop the __ prefix of all functions exported by pxa2xx-lib. This improves the readability of the code.
--- include/sound/pxa2xx-lib.h | 10 +++++----- sound/arm/pxa2xx-ac97.c | 10 +++++----- sound/arm/pxa2xx-pcm-lib.c | 22 +++++++++++----------- sound/soc/pxa/pxa2xx-pcm.c | 21 +++++++-------------- 4 files changed, 28 insertions(+), 35 deletions(-)
include/sound/pxa2xx-lib.h +5 -5
@@ -10,14 +10,14 @@ struct snd_pcm_substream;struct snd_pcm_hw_params ;struct snd_pcm ; -extern int __pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream, +extern int pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream,struct snd_pcm_hw_params *params); -extern int __pxa2xx_pcm_hw_free (struct snd_pcm_substream *substream); +extern int pxa2xx_pcm_hw_free (struct snd_pcm_substream *substream);extern int pxa2xx_pcm_trigger (struct snd_pcm_substream *substream,int cmd);extern snd_pcm_uframes_t pxa2xx_pcm_pointer (struct snd_pcm_substream *substream); -extern int __pxa2xx_pcm_prepare (struct snd_pcm_substream *substream); -extern int __pxa2xx_pcm_open (struct snd_pcm_substream *substream); -extern int __pxa2xx_pcm_close (struct snd_pcm_substream *substream); +extern int pxa2xx_pcm_prepare (struct snd_pcm_substream *substream); +extern int pxa2xx_pcm_open (struct snd_pcm_substream *substream); +extern int pxa2xx_pcm_close (struct snd_pcm_substream *substream);extern int pxa2xx_pcm_mmap (struct snd_pcm_substream *substream,struct vm_area_struct *vma);extern int pxa2xx_pcm_preallocate_dma_buffer (struct snd_pcm *pcm,int stream);
sound/arm/pxa2xx-ac97.c +5 -5
@@ -70,7 +70,7 @@ static int pxa2xx_ac97_pcm_open(struct snd_pcm_substream *substream)pxa2xx_audio_ops_t *platform_ops;int ret, i; - ret =__pxa2xx_pcm_open (substream); + ret =pxa2xx_pcm_open (substream);if (ret)return ret;
@@ -86,7 +86,7 @@ static int pxa2xx_ac97_pcm_open(struct snd_pcm_substream *substream)if (platform_ops && platform_ops->startup) { ret = platform_ops->startup (substream, platform_ops->priv);if (ret <0 ) -__pxa2xx_pcm_close (substream); +pxa2xx_pcm_close (substream); }return ret;
@@ -110,7 +110,7 @@ static int pxa2xx_ac97_pcm_prepare(struct snd_pcm_substream *substream) AC97_PCM_FRONT_DAC_RATE :AC97_PCM_LR_ADC_RATE ;int ret; - ret =__pxa2xx_pcm_prepare (substream); + ret =pxa2xx_pcm_prepare (substream);if (ret <0 )return ret;
@@ -178,8 +178,8 @@ static const struct snd_pcm_ops pxa2xx_pcm_ops = { .open = pxa2xx_ac97_pcm_open, .close = pxa2xx_ac97_pcm_close, .ioctl = snd_pcm_lib_ioctl, - .hw_params = __pxa2xx_pcm_hw_params, - .hw_free = __pxa2xx_pcm_hw_free, + .hw_params = pxa2xx_pcm_hw_params, + .hw_free = pxa2xx_pcm_hw_free, .prepare = pxa2xx_ac97_pcm_prepare, .trigger = pxa2xx_pcm_trigger, .pointer = pxa2xx_pcm_pointer,
sound/arm/pxa2xx-pcm-lib.c +11 -11
@@ -33,8 +33,8 @@ static const struct snd_pcm_hardware pxa2xx_pcm_hardware = { .fifo_size = 32, }; -int __pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream, -struct snd_pcm_hw_params *params) +int pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream, +struct snd_pcm_hw_params *params) {struct dma_chan *chan =snd_dmaengine_pcm_get_chan (substream);struct snd_soc_pcm_runtime *rtd = substream->private_data;
@@ -62,14 +62,14 @@ int __pxa2xx_pcm_hw_params(struct snd_pcm_substream *substream,return 0 ; } -EXPORT_SYMBOL (__pxa2xx_pcm_hw_params); +EXPORT_SYMBOL (pxa2xx_pcm_hw_params); -int __pxa2xx_pcm_hw_free (struct snd_pcm_substream *substream) +int pxa2xx_pcm_hw_free (struct snd_pcm_substream *substream) {snd_pcm_set_runtime_buffer (substream,NULL );return 0 ; } -EXPORT_SYMBOL (__pxa2xx_pcm_hw_free); +EXPORT_SYMBOL (pxa2xx_pcm_hw_free);int pxa2xx_pcm_trigger (struct snd_pcm_substream *substream,int cmd) {
@@ -84,13 +84,13 @@ pxa2xx_pcm_pointer(struct snd_pcm_substream *substream) }EXPORT_SYMBOL (pxa2xx_pcm_pointer); -int __pxa2xx_pcm_prepare (struct snd_pcm_substream *substream) +int pxa2xx_pcm_prepare (struct snd_pcm_substream *substream) {return 0 ; } -EXPORT_SYMBOL (__pxa2xx_pcm_prepare); +EXPORT_SYMBOL (pxa2xx_pcm_prepare); -int __pxa2xx_pcm_open (struct snd_pcm_substream *substream) +int pxa2xx_pcm_open (struct snd_pcm_substream *substream) {struct snd_soc_pcm_runtime *rtd = substream->private_data;struct snd_pcm_runtime *runtime = substream->runtime;
@@ -127,13 +127,13 @@ int __pxa2xx_pcm_open(struct snd_pcm_substream *substream) substream,dma_request_slave_channel (rtd->cpu_dai->dev, dma_params->chan_name)); } -EXPORT_SYMBOL (__pxa2xx_pcm_open); +EXPORT_SYMBOL (pxa2xx_pcm_open); -int __pxa2xx_pcm_close (struct snd_pcm_substream *substream) +int pxa2xx_pcm_close (struct snd_pcm_substream *substream) {return snd_dmaengine_pcm_close_release_chan (substream); } -EXPORT_SYMBOL (__pxa2xx_pcm_close); +EXPORT_SYMBOL (pxa2xx_pcm_close);int pxa2xx_pcm_mmap (struct snd_pcm_substream *substream,struct vm_area_struct *vma)
sound/soc/pxa/pxa2xx-pcm.c +7 -14
@@ -20,8 +20,8 @@#include <sound/pxa2xx-lib.h> #include <sound/dmaengine_pcm.h> -static int pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream, -struct snd_pcm_hw_params *params) +static int __pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream, +struct snd_pcm_hw_params *params) {struct snd_soc_pcm_runtime *rtd = substream->private_data;struct snd_dmaengine_dai_dma_data *dma;
@@ -33,23 +33,16 @@ static int pxa2xx_pcm_hw_params(struct snd_pcm_substream *substream,if (!dma)return 0 ; -return __pxa2xx_pcm_hw_params (substream, params); -} - -static int pxa2xx_pcm_hw_free (struct snd_pcm_substream *substream) -{ -__pxa2xx_pcm_hw_free (substream); - -return 0 ; +return pxa2xx_pcm_hw_params (substream, params); }static const struct snd_pcm_ops pxa2xx_pcm_ops = { - .open = __pxa2xx_pcm_open, - .close = __pxa2xx_pcm_close, + .open = pxa2xx_pcm_open, + .close = pxa2xx_pcm_close, .ioctl = snd_pcm_lib_ioctl, - .hw_params = pxa2xx_pcm_hw_params, + .hw_params = __pxa2xx_pcm_hw_params, .hw_free = pxa2xx_pcm_hw_free, - .prepare = __pxa2xx_pcm_prepare, + .prepare = pxa2xx_pcm_prepare, .trigger = pxa2xx_pcm_trigger, .pointer = pxa2xx_pcm_pointer, .mmap = pxa2xx_pcm_mmap,
Signature · 1 line
2.17.1
Mark Brown
maintainerApplied "ASoC: pxa: clean up function names in pxa2xx-lib" to the asoc tree
The patch
ASoC: pxa: clean up function names in pxa2xx-lib
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
a7160670b5e2d6b59e0f7a5b7e5bcef3b532c24cMon Sep 17 00:00:00 2001
From: Daniel Mack <[email protected]>
Date: Wed, 27 Jun 2018 21:33:54 +0200
Subject: [PATCH] ASoC: pxa: clean up function names in pxa2xx-lib
Clean up the namespace a bit and drop the __ prefix of all functions exported by pxa2xx-lib. This improves the readability of the code.
--- include/sound/pxa2xx-lib.h | 10 +++++----- sound/arm/pxa2xx-ac97.c | 10 +++++----- sound/arm/pxa2xx-pcm-lib.c | 22 +++++++++++----------- sound/soc/pxa/pxa2xx-pcm.c | 21 +++++++-------------- 4 files changed, 28 insertions(+), 35 deletions(-)
include/sound/pxa2xx-lib.h +5 -5
@@ -10,14 +10,14 @@ struct snd_pcm_substream;struct snd_pcm_hw_params ;struct snd_pcm ; -extern int __pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream, +extern int pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream,struct snd_pcm_hw_params *params); -extern int __pxa2xx_pcm_hw_free (struct snd_pcm_substream *substream); +extern int pxa2xx_pcm_hw_free (struct snd_pcm_substream *substream);extern int pxa2xx_pcm_trigger (struct snd_pcm_substream *substream,int cmd);extern snd_pcm_uframes_t pxa2xx_pcm_pointer (struct snd_pcm_substream *substream); -extern int __pxa2xx_pcm_prepare (struct snd_pcm_substream *substream); -extern int __pxa2xx_pcm_open (struct snd_pcm_substream *substream); -extern int __pxa2xx_pcm_close (struct snd_pcm_substream *substream); +extern int pxa2xx_pcm_prepare (struct snd_pcm_substream *substream); +extern int pxa2xx_pcm_open (struct snd_pcm_substream *substream); +extern int pxa2xx_pcm_close (struct snd_pcm_substream *substream);extern int pxa2xx_pcm_mmap (struct snd_pcm_substream *substream,struct vm_area_struct *vma);extern int pxa2xx_pcm_preallocate_dma_buffer (struct snd_pcm *pcm,int stream);
sound/arm/pxa2xx-ac97.c +5 -5
@@ -70,7 +70,7 @@ static int pxa2xx_ac97_pcm_open(struct snd_pcm_substream *substream)pxa2xx_audio_ops_t *platform_ops;int ret, i; - ret =__pxa2xx_pcm_open (substream); + ret =pxa2xx_pcm_open (substream);if (ret)return ret;
@@ -86,7 +86,7 @@ static int pxa2xx_ac97_pcm_open(struct snd_pcm_substream *substream)if (platform_ops && platform_ops->startup) { ret = platform_ops->startup (substream, platform_ops->priv);if (ret <0 ) -__pxa2xx_pcm_close (substream); +pxa2xx_pcm_close (substream); }return ret;
@@ -110,7 +110,7 @@ static int pxa2xx_ac97_pcm_prepare(struct snd_pcm_substream *substream) AC97_PCM_FRONT_DAC_RATE :AC97_PCM_LR_ADC_RATE ;int ret; - ret =__pxa2xx_pcm_prepare (substream); + ret =pxa2xx_pcm_prepare (substream);if (ret <0 )return ret;
@@ -178,8 +178,8 @@ static const struct snd_pcm_ops pxa2xx_pcm_ops = { .open = pxa2xx_ac97_pcm_open, .close = pxa2xx_ac97_pcm_close, .ioctl = snd_pcm_lib_ioctl, - .hw_params = __pxa2xx_pcm_hw_params, - .hw_free = __pxa2xx_pcm_hw_free, + .hw_params = pxa2xx_pcm_hw_params, + .hw_free = pxa2xx_pcm_hw_free, .prepare = pxa2xx_ac97_pcm_prepare, .trigger = pxa2xx_pcm_trigger, .pointer = pxa2xx_pcm_pointer,
sound/arm/pxa2xx-pcm-lib.c +11 -11
@@ -33,8 +33,8 @@ static const struct snd_pcm_hardware pxa2xx_pcm_hardware = { .fifo_size = 32, }; -int __pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream, -struct snd_pcm_hw_params *params) +int pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream, +struct snd_pcm_hw_params *params) {struct dma_chan *chan =snd_dmaengine_pcm_get_chan (substream);struct snd_soc_pcm_runtime *rtd = substream->private_data;
@@ -62,14 +62,14 @@ int __pxa2xx_pcm_hw_params(struct snd_pcm_substream *substream,return 0 ; } -EXPORT_SYMBOL (__pxa2xx_pcm_hw_params); +EXPORT_SYMBOL (pxa2xx_pcm_hw_params); -int __pxa2xx_pcm_hw_free (struct snd_pcm_substream *substream) +int pxa2xx_pcm_hw_free (struct snd_pcm_substream *substream) {snd_pcm_set_runtime_buffer (substream,NULL );return 0 ; } -EXPORT_SYMBOL (__pxa2xx_pcm_hw_free); +EXPORT_SYMBOL (pxa2xx_pcm_hw_free);int pxa2xx_pcm_trigger (struct snd_pcm_substream *substream,int cmd) {
@@ -84,13 +84,13 @@ pxa2xx_pcm_pointer(struct snd_pcm_substream *substream) }EXPORT_SYMBOL (pxa2xx_pcm_pointer); -int __pxa2xx_pcm_prepare (struct snd_pcm_substream *substream) +int pxa2xx_pcm_prepare (struct snd_pcm_substream *substream) {return 0 ; } -EXPORT_SYMBOL (__pxa2xx_pcm_prepare); +EXPORT_SYMBOL (pxa2xx_pcm_prepare); -int __pxa2xx_pcm_open (struct snd_pcm_substream *substream) +int pxa2xx_pcm_open (struct snd_pcm_substream *substream) {struct snd_soc_pcm_runtime *rtd = substream->private_data;struct snd_pcm_runtime *runtime = substream->runtime;
@@ -127,13 +127,13 @@ int __pxa2xx_pcm_open(struct snd_pcm_substream *substream) substream,dma_request_slave_channel (rtd->cpu_dai->dev, dma_params->chan_name)); } -EXPORT_SYMBOL (__pxa2xx_pcm_open); +EXPORT_SYMBOL (pxa2xx_pcm_open); -int __pxa2xx_pcm_close (struct snd_pcm_substream *substream) +int pxa2xx_pcm_close (struct snd_pcm_substream *substream) {return snd_dmaengine_pcm_close_release_chan (substream); } -EXPORT_SYMBOL (__pxa2xx_pcm_close); +EXPORT_SYMBOL (pxa2xx_pcm_close);int pxa2xx_pcm_mmap (struct snd_pcm_substream *substream,struct vm_area_struct *vma)
sound/soc/pxa/pxa2xx-pcm.c +7 -14
@@ -20,8 +20,8 @@#include <sound/pxa2xx-lib.h> #include <sound/dmaengine_pcm.h> -static int pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream, -struct snd_pcm_hw_params *params) +static int __pxa2xx_pcm_hw_params (struct snd_pcm_substream *substream, +struct snd_pcm_hw_params *params) {struct snd_soc_pcm_runtime *rtd = substream->private_data;struct snd_dmaengine_dai_dma_data *dma;
@@ -33,23 +33,16 @@ static int pxa2xx_pcm_hw_params(struct snd_pcm_substream *substream,if (!dma)return 0 ; -return __pxa2xx_pcm_hw_params (substream, params); -} - -static int pxa2xx_pcm_hw_free (struct snd_pcm_substream *substream) -{ -__pxa2xx_pcm_hw_free (substream); - -return 0 ; +return pxa2xx_pcm_hw_params (substream, params); }static const struct snd_pcm_ops pxa2xx_pcm_ops = { - .open = __pxa2xx_pcm_open, - .close = __pxa2xx_pcm_close, + .open = pxa2xx_pcm_open, + .close = pxa2xx_pcm_close, .ioctl = snd_pcm_lib_ioctl, - .hw_params = pxa2xx_pcm_hw_params, + .hw_params = __pxa2xx_pcm_hw_params, .hw_free = pxa2xx_pcm_hw_free, - .prepare = __pxa2xx_pcm_prepare, + .prepare = pxa2xx_pcm_prepare, .trigger = pxa2xx_pcm_trigger, .pointer = pxa2xx_pcm_pointer, .mmap = pxa2xx_pcm_mmap,
Signature · 1 line
2.18.0.rc2
Daniel Mack
maintainerPATCH 3/7 ASoC: pxa: move some functions to pxa2xx-lib
In reply to Daniel MackTo get rid of some intermediate platform layers, move pxa2xx_soc_pcm_new() and pxa2xx_pcm_ops in pxa2xx-lib.
--- include/sound/pxa2xx-lib.h | 3 +++ sound/arm/pxa2xx-ac97.c | 6 ++--- sound/arm/pxa2xx-pcm-lib.c | 41 ++++++++++++++++++++++++++++ sound/soc/pxa/pxa2xx-pcm.c | 55 -------------------------------------- 4 files changed, 47 insertions(+), 58 deletions(-)
include/sound/pxa2xx-lib.h +3 -0
@@ -8,6 +8,7 @@/* PCM */ struct snd_pcm_substream ;struct snd_pcm_hw_params ; +struct snd_soc_pcm_runtime ;struct snd_pcm ; extern int pxa2xx_pcm_hw_params(struct snd_pcm_substream *substream,
@@ -22,6 +23,8 @@ extern int pxa2xx_pcm_mmap(struct snd_pcm_substream *substream, struct vm_area_struct *vma);extern int pxa2xx_pcm_preallocate_dma_buffer (struct snd_pcm *pcm,int stream);extern void pxa2xx_pcm_free_dma_buffers (struct snd_pcm *pcm); +extern int pxa2xx_soc_pcm_new (struct snd_soc_pcm_runtime *rtd); +extern const struct snd_pcm_ops pxa2xx_pcm_ops;/* AC97 */
sound/arm/pxa2xx-ac97.c +3 -3
@@ -174,7 +174,7 @@ static int pxa2xx_ac97_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(pxa2xx_ac97_pm_ops, pxa2xx_ac97_suspend, pxa2xx_ac97_resume);#endif -static const struct snd_pcm_ops pxa2xx_pcm_ops = { +static const struct snd_pcm_ops pxa2xx_ac97_pcm_ops = { .open = pxa2xx_ac97_pcm_open, .close = pxa2xx_ac97_pcm_close, .ioctl = snd_pcm_lib_ioctl,
@@ -203,13 +203,13 @@ static int pxa2xx_ac97_pcm_new(struct snd_card *card) goto out; stream =SNDRV_PCM_STREAM_PLAYBACK ; -snd_pcm_set_ops (pcm, stream, &pxa2xx_pcm_ops); +snd_pcm_set_ops (pcm, stream, &pxa2xx_ac97_pcm_ops); ret =pxa2xx_pcm_preallocate_dma_buffer (pcm, stream);if (ret) goto out; stream =SNDRV_PCM_STREAM_CAPTURE ; -snd_pcm_set_ops (pcm, stream, &pxa2xx_pcm_ops); +snd_pcm_set_ops (pcm, stream, &pxa2xx_ac97_pcm_ops); ret =pxa2xx_pcm_preallocate_dma_buffer (pcm, stream);if (ret) goto out;
sound/arm/pxa2xx-pcm-lib.c +41 -0
47 lines not on this page · raw message
sound/soc/pxa/pxa2xx-pcm.c +0 -55
61 lines not on this page · raw message
Signature · 1 line
2.17.1
Mark Brown
maintainerApplied "ASoC: pxa: move some functions to pxa2xx-lib" to the asoc tree
The patch
ASoC: pxa: move some functions to pxa2xx-lib
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
7afd1b0b2ef9a8120951188a955010ef92bdf885Mon Sep 17 00:00:00 2001
From: Daniel Mack <[email protected]>
Date: Wed, 27 Jun 2018 21:33:55 +0200
Subject: [PATCH] ASoC: pxa: move some functions to pxa2xx-lib
To get rid of some intermediate platform layers, move pxa2xx_soc_pcm_new() and pxa2xx_pcm_ops in pxa2xx-lib.
--- include/sound/pxa2xx-lib.h | 3 +++ sound/arm/pxa2xx-ac97.c | 6 ++--- sound/arm/pxa2xx-pcm-lib.c | 41 ++++++++++++++++++++++++++++ sound/soc/pxa/pxa2xx-pcm.c | 55 -------------------------------------- 4 files changed, 47 insertions(+), 58 deletions(-)
include/sound/pxa2xx-lib.h +3 -0
@@ -8,6 +8,7 @@/* PCM */ struct snd_pcm_substream ;struct snd_pcm_hw_params ; +struct snd_soc_pcm_runtime ;struct snd_pcm ; extern int pxa2xx_pcm_hw_params(struct snd_pcm_substream *substream,
@@ -22,6 +23,8 @@ extern int pxa2xx_pcm_mmap(struct snd_pcm_substream *substream, struct vm_area_struct *vma);extern int pxa2xx_pcm_preallocate_dma_buffer (struct snd_pcm *pcm,int stream);extern void pxa2xx_pcm_free_dma_buffers (struct snd_pcm *pcm); +extern int pxa2xx_soc_pcm_new (struct snd_soc_pcm_runtime *rtd); +extern const struct snd_pcm_ops pxa2xx_pcm_ops;/* AC97 */
sound/arm/pxa2xx-ac97.c +3 -3
@@ -174,7 +174,7 @@ static int pxa2xx_ac97_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(pxa2xx_ac97_pm_ops, pxa2xx_ac97_suspend, pxa2xx_ac97_resume);#endif -static const struct snd_pcm_ops pxa2xx_pcm_ops = { +static const struct snd_pcm_ops pxa2xx_ac97_pcm_ops = { .open = pxa2xx_ac97_pcm_open, .close = pxa2xx_ac97_pcm_close, .ioctl = snd_pcm_lib_ioctl,
@@ -203,13 +203,13 @@ static int pxa2xx_ac97_pcm_new(struct snd_card *card) goto out; stream =SNDRV_PCM_STREAM_PLAYBACK ; -snd_pcm_set_ops (pcm, stream, &pxa2xx_pcm_ops); +snd_pcm_set_ops (pcm, stream, &pxa2xx_ac97_pcm_ops); ret =pxa2xx_pcm_preallocate_dma_buffer (pcm, stream);if (ret) goto out; stream =SNDRV_PCM_STREAM_CAPTURE ; -snd_pcm_set_ops (pcm, stream, &pxa2xx_pcm_ops); +snd_pcm_set_ops (pcm, stream, &pxa2xx_ac97_pcm_ops); ret =pxa2xx_pcm_preallocate_dma_buffer (pcm, stream);if (ret) goto out;
sound/arm/pxa2xx-pcm-lib.c +41 -0
47 lines not on this page · raw message
sound/soc/pxa/pxa2xx-pcm.c +0 -55
61 lines not on this page · raw message
Signature · 1 line
2.18.0.rc2
Daniel Mack
maintainerPATCH 4/7 ASoC: pxa2xx-pcm-lib: fix indenting
In reply to Daniel MackWhile at it, also fix some indenting.
--- sound/arm/pxa2xx-pcm-lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/arm/pxa2xx-pcm-lib.c +2 -2
@@ -23,8 +23,8 @@ static const struct snd_pcm_hardware pxa2xx_pcm_hardware = {SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME, .formats =SNDRV_PCM_FMTBIT_S16_LE | -SNDRV_PCM_FMTBIT_S24_LE | - SNDRV_PCM_FMTBIT_S32_LE, +SNDRV_PCM_FMTBIT_S24_LE | + SNDRV_PCM_FMTBIT_S32_LE, .period_bytes_min = 32, .period_bytes_max = 8192 - 32, .periods_min = 1,
Signature · 1 line
2.17.1
Mark Brown
maintainerApplied "ASoC: pxa2xx-pcm-lib: fix indenting" to the asoc tree
The patch
ASoC: pxa2xx-pcm-lib: fix indenting
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
456ec80876564edb74a0fff78499beb7ca286302Mon Sep 17 00:00:00 2001
From: Daniel Mack <[email protected]>
Date: Wed, 27 Jun 2018 21:33:56 +0200
Subject: [PATCH] ASoC: pxa2xx-pcm-lib: fix indenting
While at it, also fix some indenting.
--- sound/arm/pxa2xx-pcm-lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/arm/pxa2xx-pcm-lib.c +2 -2
@@ -23,8 +23,8 @@ static const struct snd_pcm_hardware pxa2xx_pcm_hardware = {SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME, .formats =SNDRV_PCM_FMTBIT_S16_LE | -SNDRV_PCM_FMTBIT_S24_LE | - SNDRV_PCM_FMTBIT_S32_LE, +SNDRV_PCM_FMTBIT_S24_LE | + SNDRV_PCM_FMTBIT_S32_LE, .period_bytes_min = 32, .period_bytes_max = 8192 - 32, .periods_min = 1,
Signature · 1 line
2.18.0.rc2
Daniel Mack
maintainerPATCH 5/7 ASoC: pxa: provide PCM ops for ssp, i2s and ac97 components
In reply to Daniel MackNow that the functions are now available through pxa2xx-lib, hook them up to pxa-sspi, pxa-ac97 and pxa-i2s. This allows DT platforms to use the DAIs without a platform driver.
--- sound/soc/pxa/pxa-ssp.c | 3 +++ sound/soc/pxa/pxa2xx-ac97.c | 3 +++ sound/soc/pxa/pxa2xx-i2s.c | 3 +++ 3 files changed, 9 insertions(+)
sound/soc/pxa/pxa-ssp.c +3 -0
@@ -841,6 +841,9 @@ static struct snd_soc_dai_driver pxa_ssp_dai = {static const struct snd_soc_component_driver pxa_ssp_component = { .name ="pxa-ssp" , + .ops = &pxa2xx_pcm_ops, + .pcm_new = pxa2xx_soc_pcm_new, + .pcm_free = pxa2xx_pcm_free_dma_buffers, };#ifdef CONFIG_OF
sound/soc/pxa/pxa2xx-ac97.c +3 -0
@@ -214,6 +214,9 @@ static struct snd_soc_dai_driver pxa_ac97_dai_driver[] = {static const struct snd_soc_component_driver pxa_ac97_component = { .name ="pxa-ac97" , + .ops = &pxa2xx_pcm_ops, + .pcm_new = pxa2xx_soc_pcm_new, + .pcm_free = pxa2xx_pcm_free_dma_buffers, };static int pxa2xx_ac97_dev_probe (struct platform_device *pdev)
sound/soc/pxa/pxa2xx-i2s.c +3 -0
@@ -364,6 +364,9 @@ static struct snd_soc_dai_driver pxa_i2s_dai = {static const struct snd_soc_component_driver pxa_i2s_component = { .name ="pxa-i2s" , + .ops = &pxa2xx_pcm_ops, + .pcm_new = pxa2xx_soc_pcm_new, + .pcm_free = pxa2xx_pcm_free_dma_buffers, };static int pxa2xx_i2s_drv_probe (struct platform_device *pdev)
Signature · 1 line
2.17.1
Daniel Mack
maintainerPATCH 6/7 ASoC: pxa: remove bindings from pxa2xx-pcm
In reply to Daniel MackThis platform is no longer needed on DT boards, so let's remove them to avoid confusion. DT bindings should use the CPU DAIs (I2S/SSP/AC97) directly.
--- .../devicetree/bindings/sound/mrvl,pxa2xx-pcm.txt | 15 --------------- sound/soc/pxa/pxa2xx-pcm.c | 9 --------- 2 files changed, 24 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/mrvl,pxa2xx-pcm.txt
Documentation/devicetree/bindings/sound/mrvl,pxa2xx-pcm.txt deleted +0 -15
@@ -1,15 +0,0 @@ -DT bindings for ARM PXA2xx PCM platform driver - -This is just a dummy driver that registers the PXA ASoC platform driver. -It does not have any resources assigned. - -Required properties: - - - compatible 'mrvl,pxa-pcm-audio' - -Example: - - pxa_pcm_audio: snd_soc_pxa_audio { - compatible = "mrvl,pxa-pcm-audio"; - }; -
sound/soc/pxa/pxa2xx-pcm.c +0 -9
@@ -32,18 +32,9 @@ static int pxa2xx_soc_platform_probe(struct platform_device *pdev) NULL, 0); } -#ifdef CONFIG_OF -static const struct of_device_id snd_soc_pxa_audio_match[] = { - { .compatible ="mrvl,pxa-pcm-audio" }, - { } -}; -MODULE_DEVICE_TABLE (of, snd_soc_pxa_audio_match); -#endif -static struct platform_driver pxa_pcm_driver = { .driver = { .name ="pxa-pcm-audio" , - .of_match_table =of_match_ptr (snd_soc_pxa_audio_match), }, .probe = pxa2xx_soc_platform_probe,
Signature · 1 line
2.17.1
Mark Brown
maintainerApplied "ASoC: pxa: remove bindings from pxa2xx-pcm" to the asoc tree
The patch
ASoC: pxa: remove bindings from pxa2xx-pcm
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
c7b4f15ddb4f28451679019374027f5223c616ceMon Sep 17 00:00:00 2001
From: Daniel Mack <[email protected]>
Date: Wed, 27 Jun 2018 21:33:58 +0200
Subject: [PATCH] ASoC: pxa: remove bindings from pxa2xx-pcm
This platform is no longer needed on DT boards, so let's remove them to avoid confusion. DT bindings should use the CPU DAIs (I2S/SSP/AC97) directly.
--- .../devicetree/bindings/sound/mrvl,pxa2xx-pcm.txt | 15 --------------- sound/soc/pxa/pxa2xx-pcm.c | 9 --------- 2 files changed, 24 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/mrvl,pxa2xx-pcm.txt
Documentation/devicetree/bindings/sound/mrvl,pxa2xx-pcm.txt deleted +0 -15
@@ -1,15 +0,0 @@ -DT bindings for ARM PXA2xx PCM platform driver - -This is just a dummy driver that registers the PXA ASoC platform driver. -It does not have any resources assigned. - -Required properties: - - - compatible 'mrvl,pxa-pcm-audio' - -Example: - - pxa_pcm_audio: snd_soc_pxa_audio { - compatible = "mrvl,pxa-pcm-audio"; - }; -
sound/soc/pxa/pxa2xx-pcm.c +0 -9
@@ -32,18 +32,9 @@ static int pxa2xx_soc_platform_probe(struct platform_device *pdev) NULL, 0); } -#ifdef CONFIG_OF -static const struct of_device_id snd_soc_pxa_audio_match[] = { - { .compatible ="mrvl,pxa-pcm-audio" }, - { } -}; -MODULE_DEVICE_TABLE (of, snd_soc_pxa_audio_match); -#endif -static struct platform_driver pxa_pcm_driver = { .driver = { .name ="pxa-pcm-audio" , - .of_match_table =of_match_ptr (snd_soc_pxa_audio_match), }, .probe = pxa2xx_soc_platform_probe,
Signature · 1 line
2.18.0.rc2
Daniel Mack
maintainerPATCH 7/7 ASoC: pxa: make SND_PXA2XX_SOC_I2S selectable
In reply to Daniel Mack--- sound/soc/pxa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/pxa/Kconfig +1 -1
@@ -31,7 +31,7 @@ config SND_PXA2XX_SOC_I2S tristate config SND_PXA_SOC_SSP - tristate + tristate "Soc Audio via PXA2xx/PXA3xx SSP ports" select PXA_SSP config SND_MMP_SOC_SSPA
Signature · 1 line
2.17.1
Mark Brown
maintainerApplied "ASoC: pxa: make SND_PXA2XX_SOC_I2S selectable" to the asoc tree
The patch
ASoC: pxa: make SND_PXA2XX_SOC_I2S selectable
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
0a94cf3457408058f894cc4d95e58d8e18eb7f75Mon Sep 17 00:00:00 2001
From: Daniel Mack <[email protected]>
Date: Wed, 27 Jun 2018 21:33:59 +0200
Subject: [PATCH] ASoC: pxa: make SND_PXA2XX_SOC_I2S selectable
--- sound/soc/pxa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/pxa/Kconfig +1 -1
@@ -31,7 +31,7 @@ config SND_PXA2XX_SOC_I2S tristate config SND_PXA_SOC_SSP - tristate + tristate "Soc Audio via PXA2xx/PXA3xx SSP ports" select PXA_SSP config SND_MMP_SOC_SSPA
Signature · 1 line
2.18.0.rc2