net: phylink: only call mac_config() during resolve when link is up
Subsystems (4)
PATCH 1/1 net: phylink: only call mac_config() during resolve when link is up
There's little point calling mac_config() when the link is down.
Signed-off-by Russell King <[email protected]>
--- drivers/net/phy/phylink.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/net/phy/phylink.c +9 -2
@@ -306,6 +306,13 @@ static void phylink_mac_config(struct phylink *pl, pl->ops->mac_config (pl->netdev, pl->link_an_mode, state); } +static void phylink_mac_config_up (struct phylink *pl, +const struct phylink_link_state *state) +{ +if (state->link) +phylink_mac_config (pl, state); +} +static void phylink_mac_an_restart (struct phylink *pl) { if (pl->link_config.an_enabled &&
@@ -405,12 +412,12 @@ static void phylink_resolve(struct work_struct *w)case MLO_AN_PHY : link_state = pl->phy_state;phylink_resolve_flow (pl, &link_state); -phylink_mac_config (pl, &link_state); +phylink_mac_config_up (pl, &link_state);break ;case MLO_AN_FIXED :phylink_get_fixed_state (pl, &link_state); -phylink_mac_config (pl, &link_state); +phylink_mac_config_up (pl, &link_state);break ;case MLO_AN_INBAND :
Signature · 1 line
2.7.4
From: Russell King <[email protected]>
Date: Mon, 11 Feb 2019 11:46:01 +0000
Quoted 3 lines
There's little point calling
mac_config()when the link is down.Signed-off-by Russell King <[email protected]>
Applied to net-next