Skip to contentSkip to conversation

net: marvell: mvpp2: phylink requires the link interrupt

PATCH In review Russell King 4 participants 7 messages Dec 10, 2019 – Dec 14, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: marvell: mvpp2: phylink requires the link interrupt

phylink requires the MAC to report when its link status changes when operating in inband modes. Failure to report link status changes means that phylink has no idea when the link events happen, which results in either the network interface's carrier remaining up or remaining permanently down.

For example, with a fiber module, if the interface is brought up and link is initially established, taking the link down at the far end will cut the optical power. The SFP module's LOS asserts, we deactivate the link, and the network interface reports no carrier.

When the far end is brought back up, the SFP module's LOS deasserts, but the MAC may be slower to establish link. If this happens (which in my tests is a certainty) then phylink never hears that the MAC has established link with the far end, and the network interface is stuck reporting no carrier. This means the interface is non-functional.

Avoiding the link interrupt when we have phylink is basically not an option, so remove the !port->phylink from the test.

---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +1 -1
index 111b3b8239e1..ef44c6979a31 100644
@@ -3674,7 +3674,7 @@ static int mvpp2_open(struct net_device *dev)
 		valid = true;
 	}
 
-	if (priv->hw_version == MVPP22 && port->link_irq && !port->phylink) {
+	if (priv->hw_version == MVPP22 && port->link_irq) {
 		err = request_irq(port->link_irq, mvpp2_link_status_isr, 0,
 				  dev->name, port);
 		if (err) {
Signature · 1 line
2.20.1
#1 lore raw
Quoted 18 lines · Russell King

phylink requires the MAC to report when its link status changes when operating in inband modes. Failure to report link status changes means that phylink has no idea when the link events happen, which results in either the network interface's carrier remaining up or remaining permanently down.

For example, with a fiber module, if the interface is brought up and link is initially established, taking the link down at the far end will cut the optical power. The SFP module's LOS asserts, we deactivate the link, and the network interface reports no carrier.

When the far end is brought back up, the SFP module's LOS deasserts, but the MAC may be slower to establish link. If this happens (which in my tests is a certainty) then phylink never hears that the MAC has established link with the far end, and the network interface is stuck reporting no carrier. This means the interface is non-functional.

Quoted 6 lines

Avoiding the link interrupt when we have phylink is basically not an option, so remove the !port->phylink from the test.

Fixes 4bb043262878 ("net: mvpp2: phylink support") ?

Seems like you maybe didn't want this backported to stable hence no fixes tag?

Please advise :)

Quoted 13 lines
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +1 -1
index 111b3b8239e1..ef44c6979a31 100644
@@ -3674,7 +3674,7 @@ static int mvpp2_open(struct net_device *dev)
 		valid = true;
 	}
 
-	if (priv->hw_version == MVPP22 && port->link_irq && !port->phylink) {
+	if (priv->hw_version == MVPP22 && port->link_irq) {
 		err = request_irq(port->link_irq, mvpp2_link_status_isr, 0,
 				  dev->name, port);
 		if (err) {
#2 lore raw
Quoted 26 lines · Jakub Kicinski
Quoted 18 lines · Russell King

phylink requires the MAC to report when its link status changes when operating in inband modes. Failure to report link status changes means that phylink has no idea when the link events happen, which results in either the network interface's carrier remaining up or remaining permanently down.

For example, with a fiber module, if the interface is brought up and link is initially established, taking the link down at the far end will cut the optical power. The SFP module's LOS asserts, we deactivate the link, and the network interface reports no carrier.

When the far end is brought back up, the SFP module's LOS deasserts, but the MAC may be slower to establish link. If this happens (which in my tests is a certainty) then phylink never hears that the MAC has established link with the far end, and the network interface is stuck reporting no carrier. This means the interface is non-functional.

Quoted 6 lines

Avoiding the link interrupt when we have phylink is basically not an option, so remove the !port->phylink from the test.

Quoted 6 lines
Fixes 4bb043262878 ("net: mvpp2: phylink support") ?

Seems like you maybe didn't want this backported to stable hence no fixes tag?

Please advise :)

Speaking for myself, I'd very much like to get it into stable in order to avoid having to keep this local patch on top of latest stable!

Willy

#3 lore raw
In reply to Jakub Kicinski
Quoted 22 lines · Jakub Kicinski
Quoted 21 lines · Russell King

phylink requires the MAC to report when its link status changes when operating in inband modes. Failure to report link status changes means that phylink has no idea when the link events happen, which results in either the network interface's carrier remaining up or remaining permanently down.

For example, with a fiber module, if the interface is brought up and link is initially established, taking the link down at the far end will cut the optical power. The SFP module's LOS asserts, we deactivate the link, and the network interface reports no carrier.

When the far end is brought back up, the SFP module's LOS deasserts, but the MAC may be slower to establish link. If this happens (which in my tests is a certainty) then phylink never hears that the MAC has established link with the far end, and the network interface is stuck reporting no carrier. This means the interface is non-functional.

Avoiding the link interrupt when we have phylink is basically not an option, so remove the !port->phylink from the test.

Quoted 8 lines
Quoted 3 lines
Fixes 4bb043262878 ("net: mvpp2: phylink support") ?

Seems like you maybe didn't want this backported to stable hence no fixes tag?

Correct, because backporting just this patch will break the Macchiatobin.

This patch is dependent on the previous two patches, which are more about correct use of the API. I suspect if you try to backport the series, things will get very hairly very quickly.

Quoted 18 lines

Please advise :)

Quoted 13 lines
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +1 -1
index 111b3b8239e1..ef44c6979a31 100644
@@ -3674,7 +3674,7 @@ static int mvpp2_open(struct net_device *dev)
 		valid = true;
 	}
 
-	if (priv->hw_version == MVPP22 && port->link_irq && !port->phylink) {
+	if (priv->hw_version == MVPP22 && port->link_irq) {
 		err = request_irq(port->link_irq, mvpp2_link_status_isr, 0,
 				  dev->name, port);
 		if (err) {
Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#4 lore raw
Quoted 32 lines · Russell King - ARM Linux admin
Quoted 22 lines · Jakub Kicinski
Quoted 21 lines · Russell King

phylink requires the MAC to report when its link status changes when operating in inband modes. Failure to report link status changes means that phylink has no idea when the link events happen, which results in either the network interface's carrier remaining up or remaining permanently down.

For example, with a fiber module, if the interface is brought up and link is initially established, taking the link down at the far end will cut the optical power. The SFP module's LOS asserts, we deactivate the link, and the network interface reports no carrier.

When the far end is brought back up, the SFP module's LOS deasserts, but the MAC may be slower to establish link. If this happens (which in my tests is a certainty) then phylink never hears that the MAC has established link with the far end, and the network interface is stuck reporting no carrier. This means the interface is non-functional.

Avoiding the link interrupt when we have phylink is basically not an option, so remove the !port->phylink from the test.

Quoted 8 lines
Quoted 3 lines
Fixes 4bb043262878 ("net: mvpp2: phylink support") ?

Seems like you maybe didn't want this backported to stable hence no fixes tag?

Quoted 6 lines

Correct, because backporting just this patch will break the Macchiatobin.

This patch is dependent on the previous two patches, which are more about correct use of the API. I suspect if you try to backport the series, things will get very hairly very quickly.

Oh, sorry, too early, wrong patch. Yes, please add the fixes tag.

Quoted 24 lines
Quoted 19 lines

Please advise :)

Quoted 13 lines
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +1 -1
index 111b3b8239e1..ef44c6979a31 100644
@@ -3674,7 +3674,7 @@ static int mvpp2_open(struct net_device *dev)
 		valid = true;
 	}
 
-	if (priv->hw_version == MVPP22 && port->link_irq && !port->phylink) {
+	if (priv->hw_version == MVPP22 && port->link_irq) {
 		err = request_irq(port->link_irq, mvpp2_link_status_isr, 0,
 				  dev->name, port);
 		if (err) {
Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#5 lore raw
Quoted 33 lines · Russell King - ARM Linux admin
Quoted 32 lines · Russell King - ARM Linux admin
Quoted 30 lines · Jakub Kicinski
Quoted 18 lines · Russell King

phylink requires the MAC to report when its link status changes when operating in inband modes. Failure to report link status changes means that phylink has no idea when the link events happen, which results in either the network interface's carrier remaining up or remaining permanently down.

For example, with a fiber module, if the interface is brought up and link is initially established, taking the link down at the far end will cut the optical power. The SFP module's LOS asserts, we deactivate the link, and the network interface reports no carrier.

When the far end is brought back up, the SFP module's LOS deasserts, but the MAC may be slower to establish link. If this happens (which in my tests is a certainty) then phylink never hears that the MAC has established link with the far end, and the network interface is stuck reporting no carrier. This means the interface is non-functional.

Quoted 6 lines

Avoiding the link interrupt when we have phylink is basically not an option, so remove the !port->phylink from the test.

Fixes 4bb043262878 ("net: mvpp2: phylink support") ?

Seems like you maybe didn't want this backported to stable hence no fixes tag?

Quoted 8 lines
Quoted 6 lines

Correct, because backporting just this patch will break the Macchiatobin.

This patch is dependent on the previous two patches, which are more about correct use of the API. I suspect if you try to backport the series, things will get very hairly very quickly.

Oh, sorry, too early, wrong patch. Yes, please add the fixes tag.

I prefer :-) Because indeed I only have this one on top of 5.4.2 which solved the problem. You can even add my tested-by if you want (though I don't care).

Thanks,
Willy

#6 lore raw
Quoted 6 lines · Willy Tarreau
Quoted 2 lines
Quoted 1 line
Quoted 1 line
Fixes 4bb043262878 ("net: mvpp2: phylink support") ?

Oh, sorry, too early, wrong patch. Yes, please add the fixes tag.

I prefer :-) Because indeed I only have this one on top of 5.4.2 which solved the problem. You can even add my tested-by if you want (though I don't care).

OK, applied, and queued for stable, thanks!