net: phylink: only restart AN if the link mode is using in-band AN
Subsystems (4)
PATCH 1/1 net: phylink: only restart AN if the link mode is using in-band AN
If we are not using in-band autonegotiation, there is no point passing the request to restart autonegotiation on to the driver.
Signed-off-by Russell King <[email protected]>
--- drivers/net/phy/phylink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/phy/phylink.c +2 -1
@@ -429,7 +429,8 @@ static void phylink_mac_config_up(struct phylink *pl,static void phylink_mac_pcs_an_restart (struct phylink *pl) {if (pl->link_config.an_enabled && -phy_interface_mode_is_8023z (pl->link_config.interface)) { +phy_interface_mode_is_8023z (pl->link_config.interface) && +phylink_autoneg_inband (pl->cur_link_an_mode)) {if (pl->pcs_ops) pl->pcs_ops->pcs_an_restart (pl->config);else
Signature · 1 line
2.20.1
Quoted 4 lines · Russell King
If we are not using in-band autonegotiation, there is no point passing the request to restart autonegotiation on to the driver.
Signed-off-by Russell King <[email protected]>
Reviewed-by Florian Fainelli <[email protected]>
Signature · 1 line
Florian
From: Russell King <[email protected]>
Date: Wed, 24 Jun 2020 12:30:04 +0100
Quoted 4 lines
If we are not using in-band autonegotiation, there is no point passing the request to restart autonegotiation on to the driver.
Signed-off-by Russell King <[email protected]>
Applied, thank you.