Skip to contentSkip to conversation

net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state()

PATCH Applied Russell King (Oracle) 4 participants 4 messages Mar 19, 2023 – Mar 21, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state()

pcs_get_state() implementations are not supposed to alter an_enabled. Remove this assignment.

Fixes b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")
---
 drivers/net/dsa/qca/qca8k-8xxx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/dsa/qca/qca8k-8xxx.c +0 -1
index 55df4479ea30..62810903f1b3 100644
@@ -1483,7 +1483,6 @@ static void qca8k_pcs_get_state(struct phylink_pcs *pcs,
 
 	state->link = !!(reg & QCA8K_PORT_STATUS_LINK_UP);
 	state->an_complete = state->link;
-	state->an_enabled = !!(reg & QCA8K_PORT_STATUS_LINK_AUTO);
 	state->duplex = (reg & QCA8K_PORT_STATUS_DUPLEX) ? DUPLEX_FULL :
 							   DUPLEX_HALF;
 
Signature · 1 line
2.30.2
maintainer
#1 lore raw

Hello,

Quoted 5 lines · Russell King (Oracle)

pcs_get_state() implementations are not supposed to alter an_enabled. Remove this assignment.

Fixes b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")

Any special reason to target the net-next tree? the fixes commit is quite old, and this looks like a -net candidate to me?!?

Thanks!

Paolo

#2 lore raw
Quoted 11 lines · Paolo Abeni

Hello,

Quoted 5 lines · Russell King (Oracle)

pcs_get_state() implementations are not supposed to alter an_enabled. Remove this assignment.

Fixes b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")

Any special reason to target the net-next tree? the fixes commit is quite old, and this looks like a -net candidate to me?!?

It's a correctness issue rather than a bug fix, so I don't see why it should be applied to a -rc kernel.

Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
#3 lore raw
In reply to Russell King (Oracle)
This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Sun, 19 Mar 2023 12:33:29 +0000 you wrote:

pcs_get_state() implementations are not supposed to alter an_enabled. Remove this assignment.

Fixes b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")
---
 drivers/net/dsa/qca/qca8k-8xxx.c | 1 -
 1 file changed, 1 deletion(-)

Here is the summary with links:
- [net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state()

    https://git.kernel.org/netdev/net-next/c/9ef70d0130f2

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html