ARM: dts: armada388-clearfog: add missing phy-modes

PATCH In review Russell King (Oracle) 3 participants 3 messages May 13, 2023 – May 15, 2023 Device tree bindings

Share & tools

Russell King (Oracle)

author

2023-05-13 10:21 UTC #0 lore raw

PATCH 1/1 ARM: dts: armada388-clearfog: add missing phy-modes

The DSA framework has got more picky about always having a phy-mode, particularly for the CPU port. Add the missing phy-mode properties for every port which does not have an integrated PHY.

Add a phy-mode property to the ethernet interface facing the switch as this was configured using SGMII - as the switch is actually using 1000base-x, let's have some consistency between the two link partners.

Additionally, the cpu label has never actually been used in the binding, so remove it.

Signed-off-by Russell King (Oracle) <[email protected]>

---
This continues on with Andrew's patch set from April, fixing up SolidRun's Armada-388 based Clearfog board with a 88e6176 switch.

 arch/arm/boot/dts/armada-388-clearfog.dts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

arch/arm/boot/dts/armada-388-clearfog.dts +6 -1

index 95299167dcf5..32c569df142f 100644
@@ -47,6 +47,8 @@ button-0 {
 
 &eth1 {
 	/* ethernet@30000 */
+	phy-mode = "1000base-x";
+
 	fixed-link {
 		speed = <1000>;
 		full-duplex;

@@ -129,8 +131,9 @@ port@4 {
 
 			port@5 {
 				reg = <5>;
-				label = "cpu";
 				ethernet = <&eth1>;
+				phy-mode = "1000base-x";
+
 				fixed-link {
 					speed = <1000>;
 					full-duplex;

@@ -141,6 +144,8 @@ port@6 {
 				/* 88E1512 external phy */
 				reg = <6>;
 				label = "lan6";
+				phy-mode = "rgmii-id";
+
 				fixed-link {
 					speed = <1000>;
 					full-duplex;

Signature · 1 line

2.30.2

Andrew Lunn

Reviewed-by on v1 1/1

2023-05-13 13:53 UTC #1 lore raw

Quoted 9 lines · Russell King (Oracle)

The DSA framework has got more picky about always having a phy-mode, particularly for the CPU port. Add the missing phy-mode properties for every port which does not have an integrated PHY.
Add a phy-mode property to the ethernet interface facing the switch as this was configured using SGMII - as the switch is actually using 1000base-x, let's have some consistency between the two link partners.

Quoted 4 lines

Additionally, the cpu label has never actually been used in the binding, so remove it.
Signed-off-by Russell King (Oracle) <[email protected]>

Thanks Russell

The changes for most of the IMX board where merged recently. So hopefully by the merge window, we will have all boards updated.

Reviewed-by Andrew Lunn <[email protected]>

Andrew

Gregory CLEMENT

2023-05-15 07:50 UTC #2 lore raw

Quoted 15 lines · Andrew Lunn

Quoted 9 lines · Russell King (Oracle)
The DSA framework has got more picky about always having a phy-mode, particularly for the CPU port. Add the missing phy-mode properties for every port which does not have an integrated PHY.
Add a phy-mode property to the ethernet interface facing the switch as this was configured using SGMII - as the switch is actually using 1000base-x, let's have some consistency between the two link partners.
Quoted 4 lines
Additionally, the cpu label has never actually been used in the binding, so remove it.
Signed-off-by Russell King (Oracle) <[email protected]>

Quoted 8 lines

Thanks Russell
The changes for most of the IMX board where merged recently. So hopefully by the merge window, we will have all boards updated.
Reviewed-by Andrew Lunn <[email protected]>
Andrew

Applied on mvebu/dt

Thanks,

Gregory

Signature · 3 lines

Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com